CountTasksHandler::__invoke() - Code Metrics - Inspection of "Merge pull request #224 from kreta/feature/task-qu..." - kreta/Kreta - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cdb55b...3f24cf )

by Gorka

created 2016-12-11 21:58 UTC

CountTasksHandler::__invoke() B

↳ Parent: CountTasksHandler

Complexity

Conditions	3
Paths	3

Size

Total Lines	30
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	30
c	0
b	0
f	0
cc	3
eloc	20
nc	3
nop	1
rs	8.8571

<?php

/*
 * This file is part of the Kreta package.
 *
 * (c) Beñat Espiña <[email protected]>
 * (c) Gorka Laucirica <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Kreta\TaskManager\Application\Query\Project\Task;

use Kreta\TaskManager\Domain\Model\Organization\OrganizationRepository;
use Kreta\TaskManager\Domain\Model\Project\Project;
use Kreta\TaskManager\Domain\Model\Project\ProjectId;
use Kreta\TaskManager\Domain\Model\Project\ProjectRepository;
use Kreta\TaskManager\Domain\Model\Project\ProjectSpecificationFactory;
use Kreta\TaskManager\Domain\Model\Project\Task\TaskRepository;
use Kreta\TaskManager\Domain\Model\Project\Task\TaskSpecificationFactory;
use Kreta\TaskManager\Domain\Model\Project\UnauthorizedProjectResourceException;
use Kreta\TaskManager\Domain\Model\User\UserId;

class CountTasksHandler
{
    private $repository;
    private $specificationFactory;
    private $projectRepository;
    private $projectSpecificationFactory;

    public function __construct(

        ProjectRepository $projectRepository,
        ProjectSpecificationFactory $projectSpecificationFactory,
        OrganizationRepository $organizationRepository,
        TaskRepository $repository,
        TaskSpecificationFactory $specificationFactory
    ) {
        $this->projectRepository = $projectRepository;
        $this->projectSpecificationFactory = $projectSpecificationFactory;
        $this->organizationRepository = $organizationRepository;

        $this->repository = $repository;
        $this->specificationFactory = $specificationFactory;
    }

    public function __invoke(CountTasksQuery $query): int
    {
        $projectIds = [ProjectId::generate($query->projectId())];
        $project = $this->projectRepository->projectOfId($projectIds[0]);
        if ($project instanceof Project) {
            $organization = $this->organizationRepository->organizationOfId(

                $project->organizationId()
            );
            if (!$organization->isOrganizationMember(UserId::generate($query->userId()))) {
                throw new UnauthorizedProjectResourceException();
            }
        } else {
            $projects = $this->projectRepository->query(
                $this->projectSpecificationFactory->buildFilterableSpecification(
                    null,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    UserId::generate($query->userId())
                )
            );
            $projectIds = array_map(function (Project $project) {
                return $project->id();
            }, $projects);
        }

        return $this->repository->count(
            $this->specificationFactory->buildFilterableSpecification(
                $projectIds,
                $query->title()
            )
        );
    }
}


1		<?php
2
3		/*
4		* This file is part of the Kreta package.
5		*
6		* (c) Beñat Espiña <[email protected]>
7		* (c) Gorka Laucirica <[email protected]>
8		*
9		* For the full copyright and license information, please view the LICENSE
10		* file that was distributed with this source code.
11		*/
12
13		declare(strict_types=1);
14
15		namespace Kreta\TaskManager\Application\Query\Project\Task;
16
17		use Kreta\TaskManager\Domain\Model\Organization\OrganizationRepository;
18		use Kreta\TaskManager\Domain\Model\Project\Project;
19		use Kreta\TaskManager\Domain\Model\Project\ProjectId;
20		use Kreta\TaskManager\Domain\Model\Project\ProjectRepository;
21		use Kreta\TaskManager\Domain\Model\Project\ProjectSpecificationFactory;
22		use Kreta\TaskManager\Domain\Model\Project\Task\TaskRepository;
23		use Kreta\TaskManager\Domain\Model\Project\Task\TaskSpecificationFactory;
24		use Kreta\TaskManager\Domain\Model\Project\UnauthorizedProjectResourceException;
25		use Kreta\TaskManager\Domain\Model\User\UserId;
26
27		class CountTasksHandler
28		{
29		private $repository;
30		private $specificationFactory;
31		private $projectRepository;
32		private $projectSpecificationFactory;
33
34	View Code Duplication	public function __construct(
		0 ignored issues – show Duplication introduced 2016-12-11 17:34 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
35		ProjectRepository $projectRepository,
36		ProjectSpecificationFactory $projectSpecificationFactory,
37		OrganizationRepository $organizationRepository,
38		TaskRepository $repository,
39		TaskSpecificationFactory $specificationFactory
40		) {
41		$this->projectRepository = $projectRepository;
42		$this->projectSpecificationFactory = $projectSpecificationFactory;
43		$this->organizationRepository = $organizationRepository;
		0 ignored issues – show Bug introduced 2016-12-11 17:34 UTC by Report Bug Copy Issue Report The property `organizationRepository` does not seem to exist. Did you mean `repository`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
44		$this->repository = $repository;
45		$this->specificationFactory = $specificationFactory;
46		}
47
48		public function __invoke(CountTasksQuery $query): int
49		{
50		$projectIds = [ProjectId::generate($query->projectId())];
51		$project = $this->projectRepository->projectOfId($projectIds[0]);
52		if ($project instanceof Project) {
53		$organization = $this->organizationRepository->organizationOfId(
		0 ignored issues – show Bug introduced 2016-12-11 17:34 UTC by Report Bug Copy Issue Report The property `organizationRepository` does not seem to exist. Did you mean `repository`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
54		$project->organizationId()
55		);
56		if (!$organization->isOrganizationMember(UserId::generate($query->userId()))) {
57		throw new UnauthorizedProjectResourceException();
58		}
59		} else {
60		$projects = $this->projectRepository->query(
61		$this->projectSpecificationFactory->buildFilterableSpecification(
62		null,
		0 ignored issues – show Documentation introduced 2016-12-11 17:34 UTC by Report Bug Copy Issue Report `null` is of type `null`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
63		UserId::generate($query->userId())
64		)
65		);
66		$projectIds = array_map(function (Project $project) {
67		return $project->id();
68		}, $projects);
69		}
70
71		return $this->repository->count(
72		$this->specificationFactory->buildFilterableSpecification(
73		$projectIds,
74		$query->title()
75		)
76		);
77		}
78		}
79

kreta / Kreta

Push — master ( cdb55b...3f24cf )

CountTasksHandler::__invoke() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like