PhpRedisConnection::__construct() - Code Metrics - Inspection of "Update hella lot of documentation" - krenor/prometheus-client - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( 8c6599...c9bdac )

by Stan

created 2019-01-18 15:14 UTC

PhpRedisConnection::__construct() A

↳ Parent: PhpRedisConnection

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	1
dl	0
loc	3
ccs	0
cts	2
cp	0
crap	2
rs	10
c	0
b	0
f	0

<?php

namespace Krenor\Prometheus\Storage\Redis;

use Redis;

class PhpRedisConnection extends Connection
{
    /**
     * PhpRedisConnection constructor.
     *
     * @param Redis $redis
     */
    public function __construct(Redis $redis)
    {
        $this->client = $redis;

    }

    /**
     * {@inheritdoc}
     */
    public function hset(string $key, string $field, $value): int
    {
        return (int) $this->client->hset($key, $field, $value);
    }
}


1		<?php
2
3		namespace Krenor\Prometheus\Storage\Redis;
4
5		use Redis;
6
7		class PhpRedisConnection extends Connection
8		{
9		/**
10		* PhpRedisConnection constructor.
11		*
12		* @param Redis $redis
13		*/
14		public function __construct(Redis $redis)
15		{
16		$this->client = $redis;
		1 ignored issue – show Documentation Bug introduced 2019-01-18 15:19 UTC by Report Bug Copy Issue Report It seems like `$redis` of type `Redis` is incompatible with the declared type `Predis\Client` of property `$client`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
17		}
18
19		/**
20		* {@inheritdoc}
21		*/
22	2	public function hset(string $key, string $field, $value): int
23		{
24	2	return (int) $this->client->hset($key, $field, $value);
25		}
26		}
27

krenor / prometheus-client

Push — develop ( 8c6599...c9bdac )

PhpRedisConnection::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like