ServerPushMiddlewareTest::getResponse() - Code Metrics - Inspection of "Add CI ✨" - krenor/http2-pusher - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( 6e78c9...4aabf2 )

by Stan

created 2017-12-13 10:55 UTC

ServerPushMiddlewareTest::getResponse() A

↳ Parent: ServerPushMiddlewareTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	5
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	1

<?php

use Illuminate\Http\Request;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Krenor\Http2Pusher\Response;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Illuminate\Http\RedirectResponse;
use Krenor\Http2Pusher\Tests\TestCase;
use Krenor\Http2Pusher\Middleware\ServerPush;

class ServerPushMiddlewareTest extends TestCase
{
    /**
     * @var ServerPush
     */
    private $middleware;

    /**
     * Bootstrap the test environment.
     */
    public function setUp()
    {
        parent::setUp();

        $this->createManifestFile();

        $this->middleware = new ServerPush($this->builder);
    }

    /**
     * Clean the test environment for the next test.
     */
    public function tearDown()
    {
        $manifest = public_path('mix-manifest.json');

        if (file_exists($manifest)) {
            unlink($manifest);
        }
    }

    /** @test */
    public function it_should_not_push_anything_when_its_a_redirect_response()

    {
        $response = function ($request) {
        $response = function (/** @scrutinizer ignore-unused */ $request) {
            return new RedirectResponse('http://laravel.com');
        };

        $response = $this->middleware->handle(
            $this->request,
            $response
        );

        $this->assertFalse($response->headers->has('Link'));
        $this->assertInstanceOf(RedirectResponse::class, $response);
    }

    /** @test */
    public function it_should_not_push_anything_when_its_a_json_request()

    {
        $this->request->headers->set('Content-Type', 'application/json');

        $response = function ($request) {
        $response = function (/** @scrutinizer ignore-unused */ $request) {
            return new Response;
        };

        $response = $this->middleware->handle(
            $this->request,
            $response
        );

        $this->assertFalse($response->headers->has('Link'));
    }

    /** @test */
    public function it_should_not_push_anything_when_its_an_ajax_request()

    {
        $this->request->headers->set('X-Requested-With', 'XMLHttpRequest');

        $response = function ($request) {
        $response = function (/** @scrutinizer ignore-unused */ $request) {
            return new Response;
        };

        $response = $this->middleware->handle(
            $this->request,
            $response
        );

        $this->assertFalse($response->headers->has('Link'));
    }

    /** @test */
    public function it_should_crawl_for_scripts_and_push_them()

    {
        $includes = [
            'https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/4.0.0-beta/js/bootstrap.min.js',
            '/js/manifest.js',
            '/js/vendor.js',
            '/js/app.js',
        ];

        $response = $this->middleware->handle(
            $this->request,
            $this->getResponse('with-scripts')
        );

        $this->assertTrue($response->headers->has('Link'));

        $link = $response->headers->get('Link');

        foreach ($includes as $include) {
            $this->assertContains($include, $link);
        }

        $this->assertCount(count($includes), explode(',', $link));
    }

    /** @test */
    public function it_should_crawl_for_style_sheets_and_push_them()

    {
        $includes = [
            'https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/4.0.0-beta/css/bootstrap-grid.min.css',
            '/css/app.css',
        ];

        $response = $this->middleware->handle(
            $this->request,
            $this->getResponse('with-styles')
        );

        $this->assertTrue($response->headers->has('Link'));

        $link = $response->headers->get('Link');

        foreach ($includes as $include) {
            $this->assertContains($include, $link);
        }

        $this->assertCount(count($includes), explode(',', $link));
    }

    /** @test */
    public function it_should_crawl_for_images_and_push_them()

    {
        $includes = [
            'http://stylecampaign.com/blog/blogimages/SVG/fox-1.svg',
            'https://laravel.com/assets/img/laravel-logo-white.png',
            '/images/laravel.jpg',
            '/images/chrome.svg',
            '/images/github.png',
        ];

        $response = $this->middleware->handle(
            $this->request,
            $this->getResponse('with-images')
        );

        $this->assertTrue($response->headers->has('Link'));

        $link = $response->headers->get('Link');

        foreach ($includes as $include) {
            $this->assertContains($include, $link);
        }

        $this->assertCount(count($includes), explode(',', $link));
    }

    /**
     * @param string $page
     *
     * @return Closure
     */
    private function getResponse($page)
    {
        return function ($request) use ($page) {
        return function (/** @scrutinizer ignore-unused */ $request) use ($page) {
            return new Response(
                file_get_contents(__DIR__ . "/fixtures/pages/{$page}.html")
            );
        };
    }

    /**
     * Create the manifest file manually for tests regarding said file.
     *
     * @return void
     */
    private function createManifestFile()
    {
        $content = '{
            "/js/vendor.js": "/js/vendor.js?id=911084212bac1b5ea2a5",
            "/js/app.js": "/js/app.js?id=8e38929b2d5501e6808e",
            "/css/app.css": "/css/app.css?id=516707d9f36d4fb7d866",
            "/js/manifest.js": "/js/manifest.js?id=ac5def271276f7bf7ec1"
        }';

        file_put_contents(public_path('mix-manifest.json'), $content);
    }
}


krenor / http2-pusher

Push — develop ( 6e78c9...4aabf2 )

ServerPushMiddlewareTest::getResponse() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like