Searchable::resolveSearch() - Code Metrics - kouks/laravel-filters - Measure and Improve Code Quality continuously with Scrutinizer

Searchable::resolveSearch() A
last analyzed 2016-11-07 17:56 UTC

↳ Parent: Searchable

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	2

<?php

namespace Koch\Filters\Behavior;

trait Searchable
{
    /**
     * Searches given columns.
     *
     * @param  string  $pattern
     * @return void
     */
    public function search($pattern = null)
    {
        if (! $pattern) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            return;
        }

        foreach ($this->searchable as $column) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $this->resolveSearch($column, $pattern);
        }
    }

    /**
     * Recursively build up the search query.
     *
     * @param  string  $column
     * @param  string  $key
     * @return void
     */
    protected function resolveSearch($column, $key)
    {
        $this->resolve($column, $key, $this->getTableName(), function ($query, $pattern) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $this->builder->orWhere($query, 'LIKE', "%{$pattern}%");
class MyClass { }

$x = new MyClass();
$x->foo = true;
        });
    }
}


1			<?php
2
3			namespace Koch\Filters\Behavior;
4
5			trait Searchable
6			{
7			/**
8			* Searches given columns.
9			*
10			* @param string $pattern
11			* @return void
12			*/
13			public function search($pattern = null)
14			{
15			if (! $pattern) {
			0 ignored issues – show Bug Best Practice introduced 2016-11-07 17:37 UTC by Report Bug Copy Issue Report The expression `$pattern` of type `string\|null` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
16			return;
17			}
18
19			foreach ($this->searchable as $column) {
			0 ignored issues – show Bug introduced 2016-11-07 17:37 UTC by Report Bug Copy Issue Report The property `searchable` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
20			$this->resolveSearch($column, $pattern);
21			}
22			}
23
24			/**
25			* Recursively build up the search query.
26			*
27			* @param string $column
28			* @param string $key
29			* @return void
30			*/
31			protected function resolveSearch($column, $key)
32			{
33			$this->resolve($column, $key, $this->getTableName(), function ($query, $pattern) {
			0 ignored issues – show Bug introduced 2016-11-07 17:37 UTC by Report Bug Copy Issue Report It seems like `getTableName()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2016-11-07 17:37 UTC by Report Bug Copy Issue Report The method `resolve()` does not exist on `Koch\Filters\Behavior\Searchable`. Did you maybe mean `resolveSearch()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
34			$this->builder->orWhere($query, 'LIKE', "%{$pattern}%");
			0 ignored issues – show Bug introduced 2016-11-07 17:37 UTC by Report Bug Copy Issue Report The property `builder` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
35			});
36			}
37			}
38

kouks / laravel-filters

Searchable::resolveSearch() A last analyzed 2016-11-07 17:56 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Searchable::resolveSearch() A
last analyzed 2016-11-07 17:56 UTC