LoggerObserver - Code Metrics - Inspection of "codestyle fixes" - kot13/bootstrapi - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f65d8f...4f3de5 )

by Pavel

created 2017-01-07 21:41 UTC

LoggerObserver A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	67
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	67
rs	10
wmc	6
lcom	1
cbo	5

5 Methods

Rating	Name	Size	Complexity
A	created()	4	1
A	updated()	4	1
A	deleted()	4	1
A	restored()	4	1
A	logEvent()	16	2

<?php
namespace App\Observers;

use App\Model\BaseModel;
use App\Model\Log;
use App\Common\Auth;

final class LoggerObserver extends BaseObserver
{
    /**
     * Listen to the BaseModel created event.
     *
     * @param  BaseModel  $model
     * @return void
     */
    public function created(BaseModel $model)
    {
        $this->logEvent('CREATE', $model);
    }

    /**
     * Listen to the BaseModel updated event.
     *
     * @param  BaseModel  $model
     * @return void
     */
    public function updated(BaseModel $model)
    {
        $this->logEvent('UPDATE', $model);
    }

    /**
     * Listen to the BaseModel deleted event.
     *
     * @param  BaseModel  $model
     * @return void
     */
    public function deleted(BaseModel $model)
    {
        $this->logEvent('DELETE', $model);
    }

    /**
     * Listen to the BaseModel restored event.
     *
     * @param  BaseModel  $model
     * @return void
     */
    public function restored(BaseModel $model)
    {
        $this->logEvent('RESTORE', $model);
    }

    /**
     * @param string $event
     * @param BaseModel $model
     */
    private function logEvent($event, BaseModel $model)
    {
        $user = Auth::getUser();

        if (!is_null($user)) {

            Log::create([
                'action'      => $event,
                'entity_id'   => $model->id,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                'entity_type' => get_class($model),
                'state'       => $model->toJson(),
                'created_by'  => $user->id,
            ]);

        }
    }
}

1			<?php
2			namespace App\Observers;
3
4			use App\Model\BaseModel;
5			use App\Model\Log;
6			use App\Common\Auth;
7
8			final class LoggerObserver extends BaseObserver
9			{
10			/**
11			* Listen to the BaseModel created event.
12			*
13			* @param BaseModel $model
14			* @return void
15			*/
16			public function created(BaseModel $model)
17			{
18			$this->logEvent('CREATE', $model);
19			}
20
21			/**
22			* Listen to the BaseModel updated event.
23			*
24			* @param BaseModel $model
25			* @return void
26			*/
27			public function updated(BaseModel $model)
28			{
29			$this->logEvent('UPDATE', $model);
30			}
31
32			/**
33			* Listen to the BaseModel deleted event.
34			*
35			* @param BaseModel $model
36			* @return void
37			*/
38			public function deleted(BaseModel $model)
39			{
40			$this->logEvent('DELETE', $model);
41			}
42
43			/**
44			* Listen to the BaseModel restored event.
45			*
46			* @param BaseModel $model
47			* @return void
48			*/
49			public function restored(BaseModel $model)
50			{
51			$this->logEvent('RESTORE', $model);
52			}
53
54			/**
55			* @param string $event
56			* @param BaseModel $model
57			*/
58			private function logEvent($event, BaseModel $model)
59			{
60			$user = Auth::getUser();
61
62			if (!is_null($user)) {
63
64			Log::create([
65			'action' => $event,
66			'entity_id' => $model->id,
			0 ignored issues – show Documentation introduced 2017-01-07 12:55 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<App\Model\BaseModel>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
67			'entity_type' => get_class($model),
68			'state' => $model->toJson(),
69			'created_by' => $user->id,
70			]);
71
72			}
73			}
74			}

kot13 / bootstrapi

Push — master ( f65d8f...4f3de5 )

LoggerObserver A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

Duplication Side-by-Side

Filter issues like