RunTestCommand::execute() - Code Metrics - Inspection of "Partisan refactoring" - kot13/bootstrapi - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#20)

by Pavel

created 2018-02-21 18:58 UTC

RunTestCommand::execute() A

↳ Parent: RunTestCommand

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	2

<?php

namespace App\Console\Commands;

use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * RunTestCommand
 */
class RunTestCommand extends Command
{
    /**
     * Configuration of command
     */
    protected function configure()
    {
        $this
            ->setName('run:test')
            ->setDescription('Command for run tests')
        ;
    }

    /**
     * Execute method of command
     *
     * @param InputInterface $input
     * @param OutputInterface $output
     *
     * @return int|null|void
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        exec('./vendor/bin/codecept run', $result);

        $output->writeln($result);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }
}


1			<?php
2
3			namespace App\Console\Commands;
4
5			use Symfony\Component\Console\Command\Command;
6			use Symfony\Component\Console\Input\InputInterface;
7			use Symfony\Component\Console\Output\OutputInterface;
8
9			/**
10			* RunTestCommand
11			*/
12			class RunTestCommand extends Command
13			{
14			/**
15			* Configuration of command
16			*/
17			protected function configure()
18			{
19			$this
20			->setName('run:test')
21			->setDescription('Command for run tests')
22			;
23			}
24
25			/**
26			* Execute method of command
27			*
28			* @param InputInterface $input
29			* @param OutputInterface $output
30			*
31			* @return int\|null\|void
32			*/
33			protected function execute(InputInterface $input, OutputInterface $output)
34			{
35			exec('./vendor/bin/codecept run', $result);
36
37			$output->writeln($result);
			0 ignored issues – show Bug introduced 2018-02-19 09:21 UTC by Report Bug Copy Issue Report It seems like `$result` can also be of type `null`; however, `Symfony\Component\Consol...putInterface::writeln()` does only seem to accept `string\|array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
38			}
39			}
40

kot13 / bootstrapi

Pull Request — master (#20)

RunTestCommand::execute() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like