Helper::generateRandomString() - Code Metrics - Inspection of "Microfixes and move /lang and /mail folders" - kot13/bootstrapi - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#19)

by Pavel

created 2017-07-20 19:30 UTC

Helper::generateRandomString() A

↳ Parent: Helper

Complexity

Conditions	2
Paths	2

Size

Total Lines	18
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	12
nc	2
nop	1
dl	0
loc	18
rs	9.4285
c	1
b	0
f	0

<?php
namespace App\Common;

class Helper
{
    /**
     * @param string  $string
     * @param bool    $capitalizeFirstChar
     *
     * @return string
     */
    public static function dashesToCamelCase($string, $capitalizeFirstChar = false)
    {
        return static::replace($string, '-', $capitalizeFirstChar);
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}
    }

    /**
     * @param string $string
     * @param bool   $capitalizeFirstChar
     *
     * @return string
     */
    public static function underscoreToCamelCase($string, $capitalizeFirstChar = false)
    {
        return static::replace($string, '_', $capitalizeFirstChar);
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}
    }

    /**
     * @param int $length
     *
     * @return string
     */
    public static function generateRandomString($length = 32)
    {
        $chars      = 'abcdefghijkmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ023456789';
        $charsCount = strlen($chars);

        srand((double)microtime() * 1000000);
        $i     = 1;
        $token = '';

        while ($i <= $length) {
            $num = rand() % $charsCount;
            $tmp = substr($chars, $num, 1);
            $token .= $tmp;
            $i++;
        }

        return $token;
    }

    /**
     * @param string $string
     * @param string $symbol
     * @param bool   $capitalizeFirstChar
     *
     * @return mixed|string

     */
    private static function replace($string, $symbol, $capitalizeFirstChar = false)
    {
        $str = str_replace(' ', '', ucwords(str_replace($symbol, ' ', $string)));

        if (!$capitalizeFirstChar) {
            $str = lcfirst($str);
        }

        return $str;
    }
}


1			<?php
2			namespace App\Common;
3
4			class Helper
5			{
6			/**
7			* @param string $string
8			* @param bool $capitalizeFirstChar
9			*
10			* @return string
11			*/
12			public static function dashesToCamelCase($string, $capitalizeFirstChar = false)
13			{
14			return static::replace($string, '-', $capitalizeFirstChar);
			0 ignored issues – show Bug introduced 2017-07-20 19:32 UTC by Report Bug Copy Issue Report Since `replace()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `replace()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history...
15			}
16
17			/**
18			* @param string $string
19			* @param bool $capitalizeFirstChar
20			*
21			* @return string
22			*/
23			public static function underscoreToCamelCase($string, $capitalizeFirstChar = false)
24			{
25			return static::replace($string, '_', $capitalizeFirstChar);
			0 ignored issues – show Bug introduced 2017-07-20 19:32 UTC by Report Bug Copy Issue Report Since `replace()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `replace()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history...
26			}
27
28			/**
29			* @param int $length
30			*
31			* @return string
32			*/
33			public static function generateRandomString($length = 32)
34			{
35			$chars = 'abcdefghijkmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ023456789';
36			$charsCount = strlen($chars);
37
38			srand((double)microtime() * 1000000);
39			$i = 1;
40			$token = '';
41
42			while ($i <= $length) {
43			$num = rand() % $charsCount;
44			$tmp = substr($chars, $num, 1);
45			$token .= $tmp;
46			$i++;
47			}
48
49			return $token;
50			}
51
52			/**
53			* @param string $string
54			* @param string $symbol
55			* @param bool $capitalizeFirstChar
56			*
57			* @return mixed\|string
			0 ignored issues – show Documentation introduced 2017-07-20 19:32 UTC by Report Bug Copy Issue Report Consider making the return type a bit more specific; maybe use `string`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history...
58			*/
59			private static function replace($string, $symbol, $capitalizeFirstChar = false)
60			{
61			$str = str_replace(' ', '', ucwords(str_replace($symbol, ' ', $string)));
62
63			if (!$capitalizeFirstChar) {
64			$str = lcfirst($str);
65			}
66
67			return $str;
68			}
69			}
70

kot13 / bootstrapi

Pull Request — master (#19)

Helper::generateRandomString() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like