CreatedByAndUpdatedByObserver - Code Metrics - kot13/bootstrapi - Measure and Improve Code Quality continuously with Scrutinizer

CreatedByAndUpdatedByObserver A
last analyzed 2018-05-19 12:59 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	31
rs	10
wmc	4
lcom	0
cbo	3

2 Methods

Rating	Name	Duplication	Size	Complexity
A	creating()	0	7	2
A	updating()	0	7	2

<?php
namespace App\Observers;

use App\Model\BaseModel;
use App\Common\Auth;

final class CreatedByAndUpdatedByObserver extends BaseObserver
{
    /**
     * Listen to the BaseModel creating event.
     *
     * @param  BaseModel  $model
     * @return void
     */
    public function creating(BaseModel $model)
    {
        $user = Auth::getUser();
        if (!is_null($user)) {
            $model->created_by = $user->id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
    }


    /**
     * Listen to the BaseModel updating event.
     *
     * @param  BaseModel  $model
     * @return void
     */
    public function updating(BaseModel $model)
    {
        $user = Auth::getUser();
        if (!is_null($user)) {
            $model->updated_by = $user->id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
    }
}


1			<?php
2			namespace App\Observers;
3
4			use App\Model\BaseModel;
5			use App\Common\Auth;
6
7			final class CreatedByAndUpdatedByObserver extends BaseObserver
8			{
9			/**
10			* Listen to the BaseModel creating event.
11			*
12			* @param BaseModel $model
13			* @return void
14			*/
15			public function creating(BaseModel $model)
16			{
17			$user = Auth::getUser();
18			if (!is_null($user)) {
19			$model->created_by = $user->id;
			0 ignored issues – show Documentation introduced 2017-01-07 12:55 UTC by Report Bug Copy Issue Report The property `created_by` does not exist on `object<App\Model\BaseModel>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
20			}
21			}
22
23
24			/**
25			* Listen to the BaseModel updating event.
26			*
27			* @param BaseModel $model
28			* @return void
29			*/
30			public function updating(BaseModel $model)
31			{
32			$user = Auth::getUser();
33			if (!is_null($user)) {
34			$model->updated_by = $user->id;
			0 ignored issues – show Documentation introduced 2017-01-07 12:55 UTC by Report Bug Copy Issue Report The property `updated_by` does not exist on `object<App\Model\BaseModel>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
35			}
36			}
37			}
38

kot13 / bootstrapi

CreatedByAndUpdatedByObserver A last analyzed 2018-05-19 12:59 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like

CreatedByAndUpdatedByObserver A
last analyzed 2018-05-19 12:59 UTC