SpyCompiler::hasBoundMethod() - Code Metrics - Inspection of "extract ModuleString" - koriym/Ray.Di - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — log ( 7a269a...6f9673 )

by Akihito

created 2018-05-06 22:03 UTC

SpyCompiler::hasBoundMethod() A

↳ Parent: SpyCompiler

Complexity

Conditions	3
Paths	3

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	7
cts	7
cp	1
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	7
nc	3
nop	2
crap	3

<?php

declare(strict_types=1);
/**
 * This file is part of the Ray.Di package.
 *
 * @license http://opensource.org/licenses/MIT MIT
 */
namespace Ray\Di;

use Ray\Aop\BindInterface;
use Ray\Aop\CompilerInterface;

final class SpyCompiler implements CompilerInterface
{
    /**
     * {@inheritdoc}
     */
    public function newInstance($class, array $args, BindInterface $bind)
    {
    }

    /**
     * {@inheritdoc}
     */
    public function compile($class, BindInterface $bind) : string
    {
        if ($this->hasNoBinding($class, $bind)) {
            return $class;
        }
        $newClass = $class . $this->getInterceptors($bind);

        return $newClass;
    }

    private function hasNoBinding($class, BindInterface $bind) : bool
    {
        $hasMethod = $this->hasBoundMethod($class, $bind);

        return ! $bind->getBindings() && ! $hasMethod;
    }

    private function hasBoundMethod(string $class, BindInterface $bind) : bool
    {
        $bindingMethods = array_keys($bind->getBindings());
        $hasMethod = false;
        foreach ($bindingMethods as $bindingMethod) {
            if (method_exists($class, $bindingMethod)) {
                $hasMethod = true;
            }
        }

        return $hasMethod;
    }

    private function getInterceptors(BindInterface $bind) : string
    {
        $bindings = $bind->getBindings();
        if (! $bindings) {

            return '';
        }
        $log = ' (aop)';
        foreach ($bindings as $mehtod => $intepceptors) {
            $log .= sprintf(
                ' +%s(%s)',
                $mehtod,
                implode(', ', $intepceptors)
            );
        }

        return $log;
    }
}


1		<?php
2
3		declare(strict_types=1);
4		/**
5		* This file is part of the Ray.Di package.
6		*
7		* @license http://opensource.org/licenses/MIT MIT
8		*/
9		namespace Ray\Di;
10
11		use Ray\Aop\BindInterface;
12		use Ray\Aop\CompilerInterface;
13
14		final class SpyCompiler implements CompilerInterface
15		{
16		/**
17		* {@inheritdoc}
18		*/
19		public function newInstance($class, array $args, BindInterface $bind)
20		{
21		}
22
23		/**
24		* {@inheritdoc}
25		*/
26	1	public function compile($class, BindInterface $bind) : string
27		{
28	1	if ($this->hasNoBinding($class, $bind)) {
29		return $class;
30		}
31	1	$newClass = $class . $this->getInterceptors($bind);
32
33	1	return $newClass;
34		}
35
36	1	private function hasNoBinding($class, BindInterface $bind) : bool
37		{
38	1	$hasMethod = $this->hasBoundMethod($class, $bind);
39
40	1	return ! $bind->getBindings() && ! $hasMethod;
41		}
42
43	1	private function hasBoundMethod(string $class, BindInterface $bind) : bool
44		{
45	1	$bindingMethods = array_keys($bind->getBindings());
46	1	$hasMethod = false;
47	1	foreach ($bindingMethods as $bindingMethod) {
48	1	if (method_exists($class, $bindingMethod)) {
49	1	$hasMethod = true;
50		}
51		}
52
53	1	return $hasMethod;
54		}
55
56	1	private function getInterceptors(BindInterface $bind) : string
57		{
58	1	$bindings = $bind->getBindings();
59	1	if (! $bindings) {
		0 ignored issues – show Bug Best Practice introduced 2018-05-06 22:04 UTC by Report Bug Copy Issue Report The expression `$bindings` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
60		return '';
61		}
62	1	$log = ' (aop)';
63	1	foreach ($bindings as $mehtod => $intepceptors) {
64	1	$log .= sprintf(
65	1	' +%s(%s)',
66	1	$mehtod,
67	1	implode(', ', $intepceptors)
68		);
69		}
70
71	1	return $log;
72		}
73		}
74

koriym / Ray.Di

Push — log ( 7a269a...6f9673 )

SpyCompiler::hasBoundMethod() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like