MapProvider::get() - Code Metrics - Inspection of "Merge branch '2.x' into error-message" - koriym/Ray.Di - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — error-message ( b7292a...ff40fa )

by Akihito

created 2022-03-19 10:39 UTC

MapProvider::get() A

↳ Parent: MapProvider

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
eloc	5
c	2
b	0
f	0
dl	0
loc	12
rs	10
cc	2
nc	2
nop	0

<?php

declare(strict_types=1);

namespace Ray\Di\MultiBinding;

use Koriym\ParamReader\ParamReaderInterface;
use Ray\Di\Di\Set;
use Ray\Di\Exception\SetNotFound;
use Ray\Di\InjectionPointInterface;
use Ray\Di\InjectorInterface;
use Ray\Di\ProviderInterface;

final class MapProvider implements ProviderInterface
{
    /** @var MultiBindings */
    private $multiBindings;

    /** @var InjectionPointInterface */
    private $ip;

    /** @var InjectorInterface */
    private $injector;

    /** @var ParamReaderInterface  */
    private $reader;

    public function __construct(
        InjectionPointInterface $ip,
        MultiBindings $multiBindings,
        InjectorInterface $injector,
        ParamReaderInterface $reader
    ) {
        $this->multiBindings = $multiBindings;
        $this->ip = $ip;
        $this->injector = $injector;
        $this->reader = $reader;
    }

    public function get(): Map
    {
        /** @var ?Set $set */
        $set = $this->reader->getParametrAnnotation($this->ip->getParameter(), Set::class);
        if ($set === null) {
            throw new SetNotFound((string) $this->ip->getParameter());
        }

        /** @var array<string, LazyTo<object>> $lazies */
        $lazies = $this->multiBindings[$set->interface];

        return new Map($lazies, $this->injector);
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Ray\Di\MultiBinding;
6
7			use Koriym\ParamReader\ParamReaderInterface;
8			use Ray\Di\Di\Set;
9			use Ray\Di\Exception\SetNotFound;
10			use Ray\Di\InjectionPointInterface;
11			use Ray\Di\InjectorInterface;
12			use Ray\Di\ProviderInterface;
13
14			final class MapProvider implements ProviderInterface
15			{
16			/** @var MultiBindings */
17			private $multiBindings;
18
19			/** @var InjectionPointInterface */
20			private $ip;
21
22			/** @var InjectorInterface */
23			private $injector;
24
25			/** @var ParamReaderInterface */
26			private $reader;
27
28			public function __construct(
29			InjectionPointInterface $ip,
30			MultiBindings $multiBindings,
31			InjectorInterface $injector,
32			ParamReaderInterface $reader
33			) {
34			$this->multiBindings = $multiBindings;
35			$this->ip = $ip;
36			$this->injector = $injector;
37			$this->reader = $reader;
38			}
39
40			public function get(): Map
41			{
42			/** @var ?Set $set */
43			$set = $this->reader->getParametrAnnotation($this->ip->getParameter(), Set::class);
44			if ($set === null) {
45			throw new SetNotFound((string) $this->ip->getParameter());
46			}
47
48			/** @var array<string, LazyTo<object>> $lazies */
49			$lazies = $this->multiBindings[$set->interface];
50
51			return new Map($lazies, $this->injector);
			0 ignored issues – show Bug Best Practice introduced 2022-03-09 10:24 UTC by Report Bug Copy Issue Report The expression `return new Ray\Di\MultiB...azies, $this->injector)` returns the type `Ray\Di\MultiBinding\Map` which is incompatible with the return type mandated by `Ray\Di\ProviderInterface::get()` of `Ray\Di\T`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
52			}
53			}
54

koriym / Ray.Di

Push — error-message ( b7292a...ff40fa )

MapProvider::get() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like