ProviderSetProvider - Code Metrics - Inspection of "Merge branch '2.x' into error-message" - koriym/Ray.Di - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — error-message ( b7292a...ff40fa )

by Akihito

created 2022-03-19 10:39 UTC

ProviderSetProvider A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Importance

Changes

Metric	Value
wmc	3
eloc	16
dl	0
loc	52
rs	10
c	0
b	0
f	0

4 Methods

Rating	Name	Size	Complexity
A	__construct()	8	1
A	hp$0 ➔ get()	3	1
	get()	28	?
A	hp$0 ➔ __construct()	4	1

<?php

declare(strict_types=1);

namespace Ray\Di;

use Koriym\ParamReader\ParamReaderInterface;
use Ray\Di\Di\Set;
use Ray\Di\Exception\SetNotFound;

final class ProviderSetProvider implements ProviderInterface
{
    /** @var InjectionPointInterface */
    private $ip;

    /** @var InjectorInterface */
    private $injector;

    /** @var ParamReaderInterface  */
    private $reader;

    public function __construct(
        InjectionPointInterface $ip,
        InjectorInterface $injector,
        ParamReaderInterface $reader
    ) {
        $this->ip = $ip;
        $this->injector = $injector;
        $this->reader = $reader;
    }

    /**
     * @return mixed
     */
    public function get()
    {
        /** @var ?Set $set */
        $set = $this->reader->getParametrAnnotation($this->ip->getParameter(), Set::class);
        if ($set === null) {
            throw new SetNotFound((string) $this->ip->getParameter());
        }

        return new class ($this->injector, $set) implements ProviderInterface
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
        {
            /** @var InjectorInterface  */
            private $injector;

            /** @var Set  */
            private $set;

            public function __construct(InjectorInterface $injector, Set $set)
            {
                $this->injector = $injector;
                $this->set = $set;
            }

            /**
             * @return mixed
             */
            public function get()
            {
                return $this->injector->getInstance($this->set->interface, $this->set->name);
            }
        };
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Ray\Di;
6
7			use Koriym\ParamReader\ParamReaderInterface;
8			use Ray\Di\Di\Set;
9			use Ray\Di\Exception\SetNotFound;
10
11			final class ProviderSetProvider implements ProviderInterface
12			{
13			/** @var InjectionPointInterface */
14			private $ip;
15
16			/** @var InjectorInterface */
17			private $injector;
18
19			/** @var ParamReaderInterface */
20			private $reader;
21
22			public function __construct(
23			InjectionPointInterface $ip,
24			InjectorInterface $injector,
25			ParamReaderInterface $reader
26			) {
27			$this->ip = $ip;
28			$this->injector = $injector;
29			$this->reader = $reader;
30			}
31
32			/**
33			* @return mixed
34			*/
35			public function get()
36			{
37			/** @var ?Set $set */
38			$set = $this->reader->getParametrAnnotation($this->ip->getParameter(), Set::class);
39			if ($set === null) {
40			throw new SetNotFound((string) $this->ip->getParameter());
41			}
42
43			return new class ($this->injector, $set) implements ProviderInterface
			0 ignored issues – show Bug Best Practice introduced 2022-03-09 10:24 UTC by Report Bug Copy Issue Report The expression `return new ClassNode($this->injector, $set)` returns the type `anonymous//src/di/ProviderSetProvider.php$0` which is incompatible with the return type mandated by `Ray\Di\ProviderInterface::get()` of `Ray\Di\T`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
44			{
45			/** @var InjectorInterface */
46			private $injector;
47
48			/** @var Set */
49			private $set;
50
51			public function __construct(InjectorInterface $injector, Set $set)
52			{
53			$this->injector = $injector;
54			$this->set = $set;
55			}
56
57			/**
58			* @return mixed
59			*/
60			public function get()
61			{
62			return $this->injector->getInstance($this->set->interface, $this->set->name);
63			}
64			};
65			}
66			}
67

koriym / Ray.Di

Push — error-message ( b7292a...ff40fa )

ProviderSetProvider A

Complexity

Size/Duplication

Importance

4 Methods

Duplication Side-by-Side

Filter issues like