Unbound::buildMessage() - Code Metrics - Inspection of "test coverage" - koriym/Ray.Di - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — assisted ( 48bf6b...70342f )

by Akihito

created 2016-02-17 12:08 UTC

Unbound::buildMessage() A

↳ Parent: Unbound

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	2

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	12
ccs	9
cts	9
cp	1
rs	9.4285
cc	2
eloc	8
nc	2
nop	2
crap	2

<?php
/**
 * This file is part of the Ray.Di package.
 *
 * @license http://opensource.org/licenses/MIT MIT
 */
namespace Ray\Di\Exception;

use Ray\Di\Exception;

class Unbound extends \LogicException implements ExceptionInterface
{
    public function __toString()
    {
        $messages = [sprintf("- %s\n", $this->getMessage())];
        $e = $this->getPrevious();
        if (! $e instanceof \Exception) {
            return $this->getMainMessage($this);
        }

        return $this->buildMessage($e, $messages) . "\n" . $e->getTraceAsString();

    }

    /**
     * @param Unbound $e
     * @param array   $msg
     *
     * @return string
     */
    private function buildMessage(Unbound $e, array $msg)
    {
        while ($e instanceof Unbound) {
            $msg[] = sprintf("- %s\n", $e->getMessage());
            $lastE = $e;
            $e = $e->getPrevious();
        }
        array_pop($msg);
        $msg = array_reverse($msg);

        return $this->getMainMessage($lastE) . implode('', $msg);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }

    private function getMainMessage(Unbound $e)
    {
        return sprintf(
            "exception '%s' with message '%s'\n",
            get_class($e),
            $e->getMessage()
        );
    }
}


1		<?php
2		/**
3		* This file is part of the Ray.Di package.
4		*
5		* @license http://opensource.org/licenses/MIT MIT
6		*/
7		namespace Ray\Di\Exception;
8
9		use Ray\Di\Exception;
10
11		class Unbound extends \LogicException implements ExceptionInterface
12		{
13	2	public function __toString()
14		{
15	2	$messages = [sprintf("- %s\n", $this->getMessage())];
16	2	$e = $this->getPrevious();
17	2	if (! $e instanceof \Exception) {
18	1	return $this->getMainMessage($this);
19		}
20
21	1	return $this->buildMessage($e, $messages) . "\n" . $e->getTraceAsString();
		0 ignored issues – show Compatibility introduced 2016-02-07 10:49 UTC by Report Bug Copy Issue Report `$e` of type `object<Exception>` is not a sub-type of `object<Ray\Di\Exception\Unbound>`. It seems like you assume a child class of the class `Exception` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
22		}
23
24		/**
25		* @param Unbound $e
26		* @param array $msg
27		*
28		* @return string
29		*/
30	1	private function buildMessage(Unbound $e, array $msg)
31		{
32	1	while ($e instanceof Unbound) {
33	1	$msg[] = sprintf("- %s\n", $e->getMessage());
34	1	$lastE = $e;
35	1	$e = $e->getPrevious();
36	1	}
37	1	array_pop($msg);
38	1	$msg = array_reverse($msg);
39
40	1	return $this->getMainMessage($lastE) . implode('', $msg);
		0 ignored issues – show Bug introduced 2016-02-07 10:49 UTC by Report Bug Copy Issue Report The variable `$lastE` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
41		}
42
43	2	private function getMainMessage(Unbound $e)
44		{
45	2	return sprintf(
46	2	"exception '%s' with message '%s'\n",
47	2	get_class($e),
48	2	$e->getMessage()
49	2	);
50		}
51		}
52

koriym / Ray.Di

Push — assisted ( 48bf6b...70342f )

Unbound::buildMessage() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like