Issues in MethodSignatureString.php (2.x) - Issues in 2.x - koriym/Ray.Aop - Measure and Improve Code Quality continuously with Scrutinizer

Issues (56)

Security Analysis no request data

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

Header Injection

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/MethodSignatureString.php (3 issues)

Labels

Bug 2

Severity

<?php

declare(strict_types=1);

namespace Ray\Aop;

use Reflection;
use ReflectionMethod;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use ReflectionParameter;
use UnitEnum;
filter:
    dependency_paths: ["lib/*"]

use function implode;
use function is_numeric;
use function is_string;
use function preg_replace;
use function sprintf;
use function str_replace;
use function var_export;

use const PHP_EOL;
use const PHP_MAJOR_VERSION;

final class MethodSignatureString
{
    private const PHP_VERSION_8 = 80000;
    private const NULLABLE_PHP8 = 'null|';
    private const NULLABLE_PHP7 = '?';
    private const INDENT = '    ';

    /** @var TypeString */
    private $typeString;

    public function __construct(int $phpVersion)
    {
        $nullableStr = $phpVersion >= self::PHP_VERSION_8 ? self::NULLABLE_PHP8 : self::NULLABLE_PHP7;
        $this->typeString = new TypeString($nullableStr);
    }

    public function get(ReflectionMethod $method): string
    {
        $signatureParts = $this->getDocComment($method);
        $this->addAttributes($method, $signatureParts);
        $this->addAccessModifiers($method, $signatureParts);
        $this->addMethodSignature($method, $signatureParts);

        return implode(' ', $signatureParts);
    }

    /** @return array<string> */
    private function getDocComment(ReflectionMethod $method): array
    {
        $docComment = $method->getDocComment();

        return is_string($docComment) ? [$docComment . PHP_EOL] : [];

    }

    /** @param array<string> $signatureParts */
    private function addAttributes(ReflectionMethod $method, array &$signatureParts): void
    {
        if (PHP_MAJOR_VERSION < 8) {
            return;
        }

        $attributes = $method->getAttributes();
        foreach ($attributes as $attribute) {
            $argsList = $attribute->getArguments();
            $formattedArgs = [];
            /** @var mixed $value */
            foreach ($argsList as $name => $value) {
                $formattedArgs[] = $this->formatArg($name, $value);
            }

            $signatureParts[] = sprintf('    #[\\%s(%s)]', $attribute->getName(), implode(', ', $formattedArgs)) . PHP_EOL;
        }

        if (empty($signatureParts)) {
            return;
        }

        $signatureParts[] = self::INDENT;
    }

    /** @param array<string> $signatureParts */
    private function addAccessModifiers(ReflectionMethod $method, array &$signatureParts): void
    {
        $modifier = implode(' ', Reflection::getModifierNames($method->getModifiers()));

        $signatureParts[] = $modifier;
    }

    /** @param array<string> $signatureParts */
    private function addMethodSignature(ReflectionMethod $method, array &$signatureParts): void
    {
        $params = [];
        foreach ($method->getParameters() as $param) {
            $params[] = $this->generateParameterCode($param);
        }

        $parmsList = implode(', ', $params);
        $rType = $method->getReturnType();
        $return = $rType ? ': ' . ($this->typeString)($rType) : '';

        $signatureParts[] = sprintf('function %s(%s)%s', $method->getName(), $parmsList, $return);
    }

    /**
     * @param string|int $name
     * @param mixed      $value
     */
    private function formatArg($name, $value): string
    {
        $formattedValue = $value instanceof UnitEnum ?
            '\\' . var_export($value, true)
            : preg_replace('/\s+/', '', var_export($value, true));

        return is_numeric($name) ? (string) $formattedValue : "{$name}: {$formattedValue}";
    }

    private function generateParameterCode(ReflectionParameter $param): string
    {
        $typeStr = ($this->typeString)($param->getType());
        $typeStrWithSpace = $typeStr ? $typeStr . ' ' : $typeStr;
        $variadicStr = $param->isVariadic() ? '...' : '';
        $referenceStr = $param->isPassedByReference() ? '&' : '';
        $defaultStr = '';
        if ($param->isDefaultValueAvailable()) {
            $default = var_export($param->getDefaultValue(), true);
            $defaultStr = ' = ' . str_replace(["\r", "\n"], '', $default);
        }

        return "{$typeStrWithSpace}{$referenceStr}{$variadicStr}\${$param->getName()}{$defaultStr}";
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Ray\Aop;
6
7			use Reflection;
8			use ReflectionMethod;
			0 ignored issues – show Bug introduced 2024-11-03 09:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this This use statement conflicts with another class in this namespace, `Ray\Aop\ReflectionMethod`. Consider defining an alias. Let?s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let?s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
9			use ReflectionParameter;
10			use UnitEnum;
			0 ignored issues – show Bug introduced 2024-11-03 09:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this The type `UnitEnum` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
11
12			use function implode;
13			use function is_numeric;
14			use function is_string;
15			use function preg_replace;
16			use function sprintf;
17			use function str_replace;
18			use function var_export;
19
20			use const PHP_EOL;
21			use const PHP_MAJOR_VERSION;
22
23			final class MethodSignatureString
24			{
25			private const PHP_VERSION_8 = 80000;
26			private const NULLABLE_PHP8 = 'null\|';
27			private const NULLABLE_PHP7 = '?';
28			private const INDENT = ' ';
29
30			/** @var TypeString */
31			private $typeString;
32
33			public function __construct(int $phpVersion)
34			{
35			$nullableStr = $phpVersion >= self::PHP_VERSION_8 ? self::NULLABLE_PHP8 : self::NULLABLE_PHP7;
36			$this->typeString = new TypeString($nullableStr);
37			}
38
39			public function get(ReflectionMethod $method): string
40			{
41			$signatureParts = $this->getDocComment($method);
42			$this->addAttributes($method, $signatureParts);
43			$this->addAccessModifiers($method, $signatureParts);
44			$this->addMethodSignature($method, $signatureParts);
45
46			return implode(' ', $signatureParts);
47			}
48
49			/** @return array<string> */
50			private function getDocComment(ReflectionMethod $method): array
51			{
52			$docComment = $method->getDocComment();
53
54			return is_string($docComment) ? [$docComment . PHP_EOL] : [];
			0 ignored issues – show introduced 2024-11-03 09:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this The condition `is_string($docComment)` is always `true`. Loading history...
55			}
56
57			/** @param array<string> $signatureParts */
58			private function addAttributes(ReflectionMethod $method, array &$signatureParts): void
59			{
60			if (PHP_MAJOR_VERSION < 8) {
61			return;
62			}
63
64			$attributes = $method->getAttributes();
65			foreach ($attributes as $attribute) {
66			$argsList = $attribute->getArguments();
67			$formattedArgs = [];
68			/** @var mixed $value */
69			foreach ($argsList as $name => $value) {
70			$formattedArgs[] = $this->formatArg($name, $value);
71			}
72
73			$signatureParts[] = sprintf(' #[\\%s(%s)]', $attribute->getName(), implode(', ', $formattedArgs)) . PHP_EOL;
74			}
75
76			if (empty($signatureParts)) {
77			return;
78			}
79
80			$signatureParts[] = self::INDENT;
81			}
82
83			/** @param array<string> $signatureParts */
84			private function addAccessModifiers(ReflectionMethod $method, array &$signatureParts): void
85			{
86			$modifier = implode(' ', Reflection::getModifierNames($method->getModifiers()));
87
88			$signatureParts[] = $modifier;
89			}
90
91			/** @param array<string> $signatureParts */
92			private function addMethodSignature(ReflectionMethod $method, array &$signatureParts): void
93			{
94			$params = [];
95			foreach ($method->getParameters() as $param) {
96			$params[] = $this->generateParameterCode($param);
97			}
98
99			$parmsList = implode(', ', $params);
100			$rType = $method->getReturnType();
101			$return = $rType ? ': ' . ($this->typeString)($rType) : '';
102
103			$signatureParts[] = sprintf('function %s(%s)%s', $method->getName(), $parmsList, $return);
104			}
105
106			/**
107			* @param string\|int $name
108			* @param mixed $value
109			*/
110			private function formatArg($name, $value): string
111			{
112			$formattedValue = $value instanceof UnitEnum ?
113			'\\' . var_export($value, true)
114			: preg_replace('/\s+/', '', var_export($value, true));
115
116			return is_numeric($name) ? (string) $formattedValue : "{$name}: {$formattedValue}";
117			}
118
119			private function generateParameterCode(ReflectionParameter $param): string
120			{
121			$typeStr = ($this->typeString)($param->getType());
122			$typeStrWithSpace = $typeStr ? $typeStr . ' ' : $typeStr;
123			$variadicStr = $param->isVariadic() ? '...' : '';
124			$referenceStr = $param->isPassedByReference() ? '&' : '';
125			$defaultStr = '';
126			if ($param->isDefaultValueAvailable()) {
127			$default = var_export($param->getDefaultValue(), true);
128			$defaultStr = ' = ' . str_replace(["\r", "\n"], '', $default);
129			}
130
131			return "{$typeStrWithSpace}{$referenceStr}{$variadicStr}\${$param->getName()}{$defaultStr}";
132			}
133			}
134

koriym / Ray.Aop

Issues (56)

Security Analysis no request data

src/MethodSignatureString.php (3 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like