koomai / laravel-config

src/Console/Commands/AddDatabaseConfigCommand.php

<?php

namespace Koomai\LaravelConfig\Console\Commands;

use Illuminate\Console\Command;
use Koomai\LaravelConfig\DatabaseConfig;

class AddDatabaseConfigCommand extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'config:add 
                            {name : The config namespace, e.g. database, dashboard} 
                            {key : Attribute name – you can use Laravel "dot" notation for nested attributes}
                            {value* : Attribute value - pass multiple values separated by space for an array}
                            {--reset-cache : Resets config cache}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Add a configuration key/value pair in the database';

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        $name = $this->argument('name');
        $key = $this->argument('key');
        $value = self::parseValue($this->argument('value'));

It seems like $this->argument('value') can also be of type null and string; however, parameter $valueAsArray of Koomai\LaravelConfig\Console\Commands\AddDatabaseConfigCommand::parseValue() does only seem to accept array, maybe add an additional type check?

        $config = DatabaseConfig::find($name);

        if (! $config) {
            $attributes = [];
            $newConfig = new DatabaseConfig;
            $newConfig->name = $name;

The property name does not seem to exist on Koomai\LaravelConfig\DatabaseConfig. Are you sure there is no database migration missing?

            $newConfig->value = data_set($attributes, $key, $value);

The property value does not seem to exist on Koomai\LaravelConfig\DatabaseConfig. Are you sure there is no database migration missing?

            $newConfig->save();
        } else {
            $currentConfig = $config->value;
            data_set($currentConfig, $key, $value);

            $config->value = $currentConfig;
            $config->save();
        }

        $this->invalidateCache();
        $this->info("Config for [{$name}.{$key}] with value [".implode(',', (array) $value).'] added successfully');

        return 0;
    }

    /**
     * Allows arrays to be set as config values. But if there is only
     * one item in the array, it returns the value as a primitive.
     *
     * @param $valueAsArray
     *
     * @return mixed
     */
    private static function parseValue(array $valueAsArray)
    {
        return (count($valueAsArray) > 1)
            ? $valueAsArray
            : reset($valueAsArray);
    }

    /**
     * Flushes cache for database config
     * If --reset-cache option is passed, it will also re-cache app config.
     *
     * @return void
     */
    private function invalidateCache(): void
    {
        app('cache')->forget(config('database-config.cache_key'));

        if ($this->option('reset-cache')) {
            $this->call('config:cache');
        }
    }
}