App\Support\Mechanics\ChooseMechanic::forOS()

Complexity

Conditions	5
Paths	4

Size

Total Lines	16
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	5

Importance

Changes

0

<?php
    public static function forOS($os = null)
    {
        $os = $os ?: PHP_OS;

        switch (true) {

It seems like you are loosely comparing stristr($os, 'WIN') of type string to the boolean true. If you are specifically checking for a non-empty string, consider using the more explicit !== '' instead.

It seems like you are loosely comparing stristr($os, 'LINUX') of type string to the boolean true. If you are specifically checking for a non-empty string, consider using the more explicit !== '' instead.

It seems like you are loosely comparing stristr($os, 'DAR') of type string to the boolean true. If you are specifically checking for a non-empty string, consider using the more explicit !== '' instead.

            case stristr($os, 'DAR'):
                return app(MacOs::class);

            case stristr($os, 'WIN'):
                return app(Windows::class);

            case stristr($os, 'LINUX'):
                return app(Linux::class);

            default :
                return app(Untrained::class);
        }