CliCommandFactory - Code Metrics - Inspection of "ea6624cc16878bc3633746d2d1ce9a488a6f47b4" - konsulting/porter - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Branch — feature__set_up_scrutinizer (ea6624)

by Robin

created 2018-09-14 22:50 UTC

CliCommandFactory A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Test Coverage

Coverage

45.45%

Importance

Changes

Metric	Value
wmc	5
eloc	8
dl	0
loc	46
ccs	5
cts	11
cp	0.4545
rs	10
c	0
b	0
f	0

4 Methods

Rating	Name	Size	Complexity
A	execContainer()	3	1
A	runContainer()	6	2
A	__construct()	3	1
A	command()	3	1

<?php

namespace App\Support\Console\DockerCompose;

use App\Models\Site;
use App\Support\Contracts\Cli;

class CliCommandFactory
{
    /**
     * @var Cli
     */
    protected $cli;

    public function __construct(Cli $cli)
    {
        $this->cli = $cli;
    }

    /**
     * Create a Docker CLI command.
     *
     * @param string $command
     * @return CliCommand
     */
    public function command($command)
    {
        return new CliCommand($this->cli, $command);
    }

    /**
     * Construct a docker-compose exec {$container} command
     *
     * @param string|null $container
     * @return CliCommand
     */
    public function execContainer($container = null)
    {
        return new CliCommand($this->cli, "exec {$container}");
    }

    /**
     * Construct a docker-compose run {$container} command
     *
     * @param string|null $container
     * @return CliCommand
     */
    public function runContainer($container = null)
    {
        $site = Site::resolveFromPathOrCurrentWorkingDirectory();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $workingDir = $site ? '-w /srv/app/' . $site->name : '';


        return new CliCommand($this->cli, "run {$workingDir} --rm {$container}");
    }
}


1		<?php
2
3		namespace App\Support\Console\DockerCompose;
4
5		use App\Models\Site;
6		use App\Support\Contracts\Cli;
7
8		class CliCommandFactory
9		{
10		/**
11		* @var Cli
12		*/
13		protected $cli;
14
15	50	public function __construct(Cli $cli)
16		{
17	50	$this->cli = $cli;
18	50	}
19
20		/**
21		* Create a Docker CLI command.
22		*
23		* @param string $command
24		* @return CliCommand
25		*/
26	10	public function command($command)
27		{
28	10	return new CliCommand($this->cli, $command);
29		}
30
31		/**
32		* Construct a docker-compose exec {$container} command
33		*
34		* @param string\|null $container
35		* @return CliCommand
36		*/
37		public function execContainer($container = null)
38		{
39		return new CliCommand($this->cli, "exec {$container}");
40		}
41
42		/**
43		* Construct a docker-compose run {$container} command
44		*
45		* @param string\|null $container
46		* @return CliCommand
47		*/
48		public function runContainer($container = null)
49		{
50		$site = Site::resolveFromPathOrCurrentWorkingDirectory();
		0 ignored issues – show Bug introduced 2018-09-14 09:00 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$site` is correct as `App\Models\Site::resolve...rrentWorkingDirectory()` targeting `App\Models\Site::resolve...rrentWorkingDirectory()` seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
51		$workingDir = $site ? '-w /srv/app/' . $site->name : '';
		0 ignored issues – show introduced 2018-09-14 09:00 UTC by Report Bug Copy Issue Report `$site` is of type `null`, thus it always evaluated to `false`. Loading history...
52
53		return new CliCommand($this->cli, "run {$workingDir} --rm {$container}");
54		}
55		}
56

konsulting / porter

Branch — feature__set_up_scrutinizer (ea6624)

CliCommandFactory A

Complexity

Size/Duplication

Test Coverage

Importance

4 Methods

Duplication Side-by-Side

Filter issues like