Issues in Controller.php - All Issues - Inspection of "Bind default accessors in Container" - kokororin/Kotori.php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 859d66...4f628a )

by やかみ

created 2017-09-23 11:45 UTC

src/Core/Controller.php (8 issues)

Labels

Bug 8

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Kotori.php
 *
 * A Tiny Model-View-Controller PHP Framework
 *
 * This content is released under the Apache 2 License
 *
 * Copyright (c) 2015-2017 Kotori Technology. All rights reserved.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

/**
 * Application Controller Class
 *
 * This class object is the super class .
 *
 * @package     Kotori
 * @subpackage  Core
 * @author      Kokororin
 * @link        https://kotori.love
 */
namespace Kotori\Core;

use Kotori\Debug\Hook;

class Controller
{
    /**
     * DB selector
     *
     * @param  string   $key
     * @return \Kotori\Core\Database
     */
    protected function db($key = null)
    {
        return Database::getInstance($key);
    }

    /**
     * Class constructor
     *
     * Initialize view and database classes.
     *
     * @return void
     */
    public function __construct()
    {
        $this->view = new View();
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->response = Container::get('response');
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->request = Container::get('request');
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->route = Container::get('route');
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->db = $this->db();
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->model = Container::get('model/provider');
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->config = Container::get('config');
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->cache = Container::get('cache');
class MyClass { }

$x = new MyClass();
$x->foo = true;
        Hook::listen(__CLASS__);
    }

}


1			<?php
2			/**
3			* Kotori.php
4			*
5			* A Tiny Model-View-Controller PHP Framework
6			*
7			* This content is released under the Apache 2 License
8			*
9			* Copyright (c) 2015-2017 Kotori Technology. All rights reserved.
10			*
11			* Licensed under the Apache License, Version 2.0 (the "License");
12			* you may not use this file except in compliance with the License.
13			* You may obtain a copy of the License at
14			*
15			* http://www.apache.org/licenses/LICENSE-2.0
16			*
17			* Unless required by applicable law or agreed to in writing, software
18			* distributed under the License is distributed on an "AS IS" BASIS,
19			* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
20			* See the License for the specific language governing permissions and
21			* limitations under the License.
22			*/
23
24			/**
25			* Application Controller Class
26			*
27			* This class object is the super class .
28			*
29			* @package Kotori
30			* @subpackage Core
31			* @author Kokororin
32			* @link https://kotori.love
33			*/
34			namespace Kotori\Core;
35
36			use Kotori\Debug\Hook;
37
38			class Controller
39			{
40			/**
41			* DB selector
42			*
43			* @param string $key
44			* @return \Kotori\Core\Database
45			*/
46			protected function db($key = null)
47			{
48			return Database::getInstance($key);
49			}
50
51			/**
52			* Class constructor
53			*
54			* Initialize view and database classes.
55			*
56			* @return void
57			*/
58			public function __construct()
59			{
60			$this->view = new View();
			0 ignored issues – show Bug introduced 2017-08-07 03:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `view` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
61			$this->response = Container::get('response');
			0 ignored issues – show Bug introduced 2017-08-08 06:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `response` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
62			$this->request = Container::get('request');
			0 ignored issues – show Bug introduced 2017-08-08 06:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `request` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
63			$this->route = Container::get('route');
			0 ignored issues – show Bug introduced 2017-08-08 06:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `route` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
64			$this->db = $this->db();
			0 ignored issues – show Bug introduced 2017-08-08 06:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `db` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
65			$this->model = Container::get('model/provider');
			0 ignored issues – show Bug introduced 2017-08-08 06:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `model` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
66			$this->config = Container::get('config');
			0 ignored issues – show Bug introduced 2017-08-08 06:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `config` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
67			$this->cache = Container::get('cache');
			0 ignored issues – show Bug introduced 2017-08-08 06:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `cache` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
68			Hook::listen(__CLASS__);
69			}
70
71			}
72

GitHub Access Token became invalid

Push — master ( 859d66...4f628a )

src/Core/Controller.php (8 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

kokororin / Kotori.php

GitHub Access Token became invalid

Push — master ( 859d66...4f628a )

src/Core/Controller.php (8 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like