Issues in RepositoryAbstract.php (master) - Issues in master - koinephp/repository - Measure and Improve Code Quality continuously with Scrutinizer

Issues (3)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/RepositoryAbstract.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Koine\Repository;

use Koine\Repository\Exception\RecordNotFoundException;
use Koine\Repository\Storage\StorageInterface;
use Zend\Hydrator\HydratorInterface;

abstract class RepositoryAbstract implements RepositoryInterface
{
    /**
     * @var HydratorInterface
     */
    private $hydrator;

    /**
     * @var object
     */
    private $entityPrototype;

    /**
     * @var StorageInterface
     */
    private $storage;

    /**
     * @param StorageInterface $storage
     */
    public function __construct(StorageInterface $storage)
    {
        $this->storage = $storage;
    }

    /**
     * @return MySql
     */
    protected function getStorage()
    {
        return $this->storage;
    }

    /**
     * @param array $params
     *
     * @return object
     *
     * @throws RecordNotFoundException
     */
    public function findOneBy(array $params)
    {
        $rawData = $this->getStorage()->findOneBy($params);

        return $this->createEntity($rawData);
    }

    /**
     * @param array $rawData
     *
     * @return object
     */
    private function createEntity(array $rawData = array())
    {
        $entity = clone $this->getEntityPrototype();

        if ($rawData) {

            $this->getHydrator()->hydrate($rawData, $entity);
        }

        return $entity;
    }

    /**
     * @param array $params
     *
     * @return array
     */
    public function findAllBy(array $params = array())
    {
        $rawCollection = $this->getStorage()->findAllBy($params);
        $collection = array();

        foreach ($rawCollection as $rawData) {
            $collection[] = $this->createEntity($rawData);
        }

        return $collection;
    }

    /**
     * @param HydratorInterface $hydrator
     *
     * @return self
     */
    public function setHydrator(HydratorInterface $hydrator)
    {
        $this->hydrator = $hydrator;

        return $this;
    }

    /**
     * @return HydratorInterface
     */
    public function getHydrator()
    {
        if ($this->hydrator === null) {
            throw new \DomainException('Hydrator was not set');
        }

        return $this->hydrator;
    }

    /**
     * @param object $entityPrototype
     *
     * @return self
     */
    public function setEntityPrototype($entityPrototype)
    {
        $this->entityPrototype = $entityPrototype;

        return $this;
    }

    /**
     * @return object
     */
    public function getEntityPrototype()
    {
        if ($this->entityPrototype === null) {
            throw new \DomainException('Entity Prototype was not set');
        }

        return $this->entityPrototype;
    }
}


1			<?php
2
3			namespace Koine\Repository;
4
5			use Koine\Repository\Exception\RecordNotFoundException;
6			use Koine\Repository\Storage\StorageInterface;
7			use Zend\Hydrator\HydratorInterface;
8
9			abstract class RepositoryAbstract implements RepositoryInterface
10			{
11			/**
12			* @var HydratorInterface
13			*/
14			private $hydrator;
15
16			/**
17			* @var object
18			*/
19			private $entityPrototype;
20
21			/**
22			* @var StorageInterface
23			*/
24			private $storage;
25
26			/**
27			* @param StorageInterface $storage
28			*/
29			public function __construct(StorageInterface $storage)
30			{
31			$this->storage = $storage;
32			}
33
34			/**
35			* @return MySql
36			*/
37			protected function getStorage()
38			{
39			return $this->storage;
40			}
41
42			/**
43			* @param array $params
44			*
45			* @return object
46			*
47			* @throws RecordNotFoundException
48			*/
49			public function findOneBy(array $params)
50			{
51			$rawData = $this->getStorage()->findOneBy($params);
52
53			return $this->createEntity($rawData);
54			}
55
56			/**
57			* @param array $rawData
58			*
59			* @return object
60			*/
61			private function createEntity(array $rawData = array())
62			{
63			$entity = clone $this->getEntityPrototype();
64
65			if ($rawData) {
			0 ignored issues – show Bug Best Practice introduced 2016-01-13 13:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$rawData` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
66			$this->getHydrator()->hydrate($rawData, $entity);
67			}
68
69			return $entity;
70			}
71
72			/**
73			* @param array $params
74			*
75			* @return array
76			*/
77			public function findAllBy(array $params = array())
78			{
79			$rawCollection = $this->getStorage()->findAllBy($params);
80			$collection = array();
81
82			foreach ($rawCollection as $rawData) {
83			$collection[] = $this->createEntity($rawData);
84			}
85
86			return $collection;
87			}
88
89			/**
90			* @param HydratorInterface $hydrator
91			*
92			* @return self
93			*/
94			public function setHydrator(HydratorInterface $hydrator)
95			{
96			$this->hydrator = $hydrator;
97
98			return $this;
99			}
100
101			/**
102			* @return HydratorInterface
103			*/
104			public function getHydrator()
105			{
106			if ($this->hydrator === null) {
107			throw new \DomainException('Hydrator was not set');
108			}
109
110			return $this->hydrator;
111			}
112
113			/**
114			* @param object $entityPrototype
115			*
116			* @return self
117			*/
118			public function setEntityPrototype($entityPrototype)
119			{
120			$this->entityPrototype = $entityPrototype;
121
122			return $this;
123			}
124
125			/**
126			* @return object
127			*/
128			public function getEntityPrototype()
129			{
130			if ($this->entityPrototype === null) {
131			throw new \DomainException('Entity Prototype was not set');
132			}
133
134			return $this->entityPrototype;
135			}
136			}
137

koinephp / repository

Issues (3)

Security Analysis no request data

src/RepositoryAbstract.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like