Lua::deserialize() - Code Metrics - Inspection of "Update documentation" - koesie10/LuaSerializer - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( d251e3...0f10a6 )

by Koen

created 2015-12-21 18:18 UTC

Lua::deserialize() A

↳ Parent: Lua

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
ccs	0
cts	3
cp	0
rs	10
cc	1
eloc	3
nc	1
nop	1
crap	2

<?php
/**
 * Lua.php
 *
 * @author Koen Vlaswinkel <[email protected]>
 * @since  20/12/2015 14:47
 */

namespace Vlaswinkel\Lua;

/**
 * Class Lua
 *
 * @package Vlaswinkel\Lua
 */
class Lua {
    public static $luaKeywords = [
        'and',
        'break',
        'do',
        'else',
        'elseif',
        'end',
        'false',
        'for',
        'function',
        'if',
        'in',
        'local',
        'nil',
        'not',
        'or',
        'repeat',
        'return',
        'then',
        'true',
        'until',
        'while',
    ];

    public static function serialize($data) {
        return LuaSerializer::encode($data);
    }

    public static function deserialize($data) {
        $parser = new LuaParser(new LuaTokenStream(new LuaInputStream($data)));
        return LuaToPhpConverter::convertToPhpValue($parser->parse());
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
    }
}

1			<?php
2			/**
3			* Lua.php
4			*
5			* @author Koen Vlaswinkel <[email protected]>
6			* @since 20/12/2015 14:47
7			*/
8
9			namespace Vlaswinkel\Lua;
10
11			/**
12			* Class Lua
13			*
14			* @package Vlaswinkel\Lua
15			*/
16			class Lua {
17			public static $luaKeywords = [
18			'and',
19			'break',
20			'do',
21			'else',
22			'elseif',
23			'end',
24			'false',
25			'for',
26			'function',
27			'if',
28			'in',
29			'local',
30			'nil',
31			'not',
32			'or',
33			'repeat',
34			'return',
35			'then',
36			'true',
37			'until',
38			'while',
39			];
40
41			public static function serialize($data) {
42			return LuaSerializer::encode($data);
43			}
44
45			public static function deserialize($data) {
46			$parser = new LuaParser(new LuaTokenStream(new LuaInputStream($data)));
47			return LuaToPhpConverter::convertToPhpValue($parser->parse());
			1 ignored issue – show Bug introduced 2015-12-21 18:22 UTC by Report Bug Copy Issue Report It seems like `$parser->parse()` can be `null`; however, `convertToPhpValue()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
48			}
49			}

koesie10 / LuaSerializer

Push — master ( d251e3...0f10a6 )

Lua::deserialize() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like