koenhoeijmakers / laravel-translatable

src/Scopes/JoinTranslationScope.php

<?php

declare(strict_types=1);

namespace KoenHoeijmakers\LaravelTranslatable\Scopes;

use Illuminate\Database\Eloquent\Builder;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Scope;
use Illuminate\Database\Query\JoinClause;

class JoinTranslationScope implements Scope
{
    /**
     * Apply the scope to a given Eloquent query builder.
     *
     * @param  \Illuminate\Database\Eloquent\Builder                                                    $builder
     * @param  \Illuminate\Database\Eloquent\Model|\KoenHoeijmakers\LaravelTranslatable\HasTranslations $model
     * @return void
     */
    public function apply(Builder $builder, Model $model)
    {
        $builder->leftJoin($model->getTranslationTable(), function (JoinClause $join) use ($model) {
            $join->on(
                $model->getTable() . '.' . $model->getKeyName(),
                $model->getTranslationTable() . '.' . $model->getForeignKey()

Are you sure $model->getTranslationTable() of type Illuminate\Database\Eloquent\Builder|mixed can be used in concatenation?

            )->where($model->getLocaleKeyName(), $model->getLocale());

It seems like $model->getLocaleKeyName() can also be of type Illuminate\Database\Eloquent\Builder; however, parameter $column of Illuminate\Database\Query\Builder::where() does only seem to accept Closure|array|string, maybe add an additional type check?

        })->addSelect($model->getTable() . '.*', ...$model->formatTranslatableColumnsForSelect());
    }
}