KoenHoeijmakers\LaravelTranslatable\Scopes\JoinTranslationScope::apply()

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	1

Importance

Changes

0

<?php declare(strict_types=1);
    public function apply(Builder $builder, Model $model)
    {
        $builder->leftJoin($model->getTranslationTable(), function (JoinClause $join) use ($model) {
            $join->on(
                $model->getTable() . '.' . $model->getKeyName(),
                $model->getTranslationTable() . '.' . $model->getForeignKey()

Are you sure $model->getTranslationTable() of type Illuminate\Database\Eloquent\Builder|mixed can be used in concatenation?

            )->where($model->getLocaleKeyName(), $model->getLocale());

It seems like $model->getLocaleKeyName() can also be of type Illuminate\Database\Eloquent\Builder; however, parameter $column of Illuminate\Database\Query\Builder::where() does only seem to accept Closure|array|string, maybe add an additional type check?

        })->select($model->getTable() . '.*', ...$model->formatTranslatableColumnsForSelect());
    }