kodedphp / http

ValidatableTrait.php

<?php

/*
 * This file is part of the Koded package.
 *
 * (c) Mihail Binev <mihail@kodeart.com>
 *
 * Please view the LICENSE distributed with this source code
 * for the full copyright and license information.
 *
 */

namespace Koded\Http;

use Koded\Http\Interfaces\{HttpInputValidator, HttpStatus, Response};
use Koded\Stdlib\{Data, Immutable};

/**
 * @method Response|null getParsedBody
 */
trait ValidatableTrait
{
    public function validate(HttpInputValidator $validator, ?Data &$input = null): ?Response
    {
        $input ??= new Immutable($this->getParsedBody() ?? []);

It seems like $this->getParsedBody() ?? array() can also be of type Koded\Http\Interfaces\Response; however, parameter $data of Koded\Stdlib\Immutable::__construct() does only seem to accept array, maybe add an additional type check?

        if (0 === $input->count()) {

The method count() does not exist on Koded\Stdlib\Data. It seems like you code against a sub-type of said class. However, the method does not exist in Koded\Stdlib\Argument or Koded\Stdlib\Configuration. Are you sure you never get one of those?

            $errors = ['validate' => 'Nothing to validate', 'code' => HttpStatus::BAD_REQUEST];
            return new JsonResponse($errors, HttpStatus::BAD_REQUEST, [
                'Content-Type' => 'application/problem+json'
            ]);
        }
        if (empty($errors = $validator->validate($input))) {
            return null;
        }
        $errors['status'] = (int)($errors['status'] ?? HttpStatus::BAD_REQUEST);
        return new JsonResponse($errors, $errors['status'], [
            'Content-Type' => 'application/problem+json'
        ]);
    }
}