kodedphp / http

Tests/AssertionTestSupportTrait.php

<?php

namespace Tests\Koded\Http;

trait AssertionTestSupportTrait
{
    /**
     * @param object|string $objectOrString
     * @param string        $propertyName
     *
     * @return mixed
     * @throws \ReflectionException
     */
    private function getObjectProperty(
        object|string $objectOrString,
        string $propertyName): mixed
    {
        try {
            $proto    = new \ReflectionClass($objectOrString);
            $property = $proto->getProperty($propertyName);
            $property->setAccessible(true);
            return $property->getValue($objectOrString);

It seems like $objectOrString can also be of type string; however, parameter $object of ReflectionProperty::getValue() does only seem to accept null|object, maybe add an additional type check?

        } catch (\ReflectionException $e) {
            $this->markTestSkipped('[Reflection Error: ' . $e->getMessage());

It seems like markTestSkipped() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }
    }

    /**
     * @param object|string $objectOrString
     * @param array         $propertyNames List of property names, or empty for all properties
     *
     * @return array
     */
    private function getObjectProperties(
        object|string $objectOrString,
        array $propertyNames = []): array
    {
        try {
            $properties = (new \ReflectionClass($objectOrString))->getProperties();

            if (count($propertyNames) > 0) {
                $properties = array_filter($properties, function(\ReflectionProperty $property) use ($propertyNames) {
                    return in_array($property->getName(), $propertyNames);
                });
            }

            $propertyKeys = array_map(function(\ReflectionProperty $property) {
                return $property->getName();
            }, $properties);

            return array_combine($propertyKeys, array_map(function(\ReflectionProperty $property) use($objectOrString) {
                $property->setAccessible(true);
                return $property->getValue($objectOrString);

It seems like $objectOrString can also be of type string; however, parameter $object of ReflectionProperty::getValue() does only seem to accept null|object, maybe add an additional type check?

            }, $properties));

        } catch (\ReflectionException $e) {
            $this->markTestSkipped('[Reflection Error: ' . $e->getMessage());

In this branch, the function will implicitly return null which is incompatible with the type-hinted return array. Consider adding a return statement or allowing null as return value.

        }
    }
}