knasenn / vaderanax

src/jsonweather/JsonweatherController.php

<?php

namespace Anax\jsonweather;

use Anax\Commons\ContainerInjectableInterface;
use Anax\Commons\ContainerInjectableTrait;

// use Anax\Route\Exception\ForbiddenException;
// use Anax\Route\Exception\NotFoundException;
// use Anax\Route\Exception\InternalErrorException;

/**
 * A sample controller to show how a controller class can be implemented.
 * The controller will be injected with $di if implementing the interface
 * ContainerInjectableInterface, like this sample class does.
 * The controller is mounted on a particular route and can then handle all
 * requests for that mount point.
 *
 * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
class JsonWeatherController implements ContainerInjectableInterface
{
    use ContainerInjectableTrait;




    /**
     * This is the index method action, it handles:
     * ANY METHOD mountpoint
     * ANY METHOD mountpoint/
     * ANY METHOD mountpoint/index
     *
     * @return string
     */
    public function indexActionGet() : object
    {
        $page = $this->di->get("page");
        // $adress = $_SERVER["REMOTE_ADDR"] ?? "";
        $adress = $_SERVER["HTTP_X_FORWARDED_FOR"] ?? "";

        $data = [
            "test" => "testing",
            "adress" => $adress,
        ];

        $page->add("jsonweather/index", $data);

        return $page->render();
    }



    /**
     * This is the index method action, it handles:
     * ANY METHOD mountpoint
     * ANY METHOD mountpoint/
     * ANY METHOD mountpoint/index
     *
     * @return string
     */
    public function indexActionPost() : array
    {
        //gets pagestuff?
        $page = $this->di->get("page");

The assignment to $page is dead and can be removed.

        //get ip
        $ip = $this->di->request->getPOST("ip");

Accessing request on the interface Psr\Container\ContainerInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        //get dateChecked
        $dateChecked = $this->di->request->getPOST("dateChecked");

        //Creates validate-class object
        $validate = $this->di->get("validator");
        //Validates ip
        $resValidateIp = $validate->validateIp($ip);
        //Gets hostname
        $resDomain = $validate->getDomain($ip);

        $curl = new \Aiur\Curl\Curl();
        //Gets curl adress
        $resCurlAdress = $curl->getCurlAdress($ip, $resValidateIp);


        if (is_array($resCurlAdress)) {

The condition is_array($resCurlAdress) is always false.

            if (is_float($resCurlAdress[0])) {
                if ($dateChecked == "plusweek") {
                    $resCurlTempWeek = $curl->getCurlTemp($resCurlAdress[0], $resCurlAdress[1], $dateChecked);
                } elseif ($dateChecked == "minusmonth") {
                    $resCurlTempMonth = $curl->getCurlTemp($resCurlAdress[0], $resCurlAdress[1], $dateChecked);
                }
            } elseif (is_string($resCurlAdress[0])) {
                $notValid = "Search was not valid!";
            }
        } else {
            if ($dateChecked == "plusweek") {
                $resCurlTempWeek = $curl->getCurlTemp($resCurlAdress->latitude, $resCurlAdress->longitude, $dateChecked);

The property longitude does not seem to exist on Aiur\Curl\Curl.

The property latitude does not seem to exist on Aiur\Curl\Curl.

            } elseif ($dateChecked == "minusmonth") {
                $resCurlTempMonth = $curl->getCurlTemp($resCurlAdress->latitude, $resCurlAdress->longitude, $dateChecked);
            }
        }
        $data = [
            "ipval" => $resValidateIp,
            "host" => $resDomain,
            "latitude" => $resCurlAdress->latitude ?? "",
            "longitude" => $resCurlAdress->longitude ?? "",
            "country_name" => $resCurlAdress->country_name ?? "",

The property country_name does not seem to exist on Aiur\Curl\Curl.

            "region_name" => $resCurlAdress->region_name ?? "",

The property region_name does not seem to exist on Aiur\Curl\Curl.

            "resTempWeek" => $resCurlTempWeek->daily->data ?? "",

The variable $resCurlTempWeek does not seem to be defined for all execution paths leading up to this point.

            "resTempMonth" => $resCurlTempMonth ?? "",
            "notValid" => $notValid ?? ""
        ];

        // $page->add("jsonweather/weather", $data);


        return [$data];

The expression return array($data) returns the type array<integer,array<string,mixed|string>> which is incompatible with the documented return type string.

    }
}