Torrent - Code Metrics - Inspection of "Add comment field to Transmission\Model\Torrent" - kleiram/transmission-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#57)

unknown

created 2016-06-13 15:04 UTC

Torrent B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	505
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	7

Importance

Changes	39
Bugs	3	Features	21

Metric	Value
wmc	48
c	39
b	3
f	21
lcom	2
cbo	7
dl	0
loc	505
rs	8.4864

47 Methods

Rating	Name	Size	Complexity
A	setId()	4	1
A	getId()	4	1
A	setEta()	4	1
A	getEta()	4	1
A	setSize()	4	1
A	getSize()	4	1
A	setName()	4	1
A	getName()	4	1
A	setHash()	4	1
A	getHash()	4	1
A	setStatus()	4	1
A	getStatus()	4	1
A	setFinished()	4	1
A	isFinished()	4	2
A	setStartDate()	4	1
A	getStartDate()	4	1
A	setUploadRate()	4	1
A	getUploadRate()	4	1
A	setDownloadRate()	4	1
A	setPeersConnected()	4	1
A	getPeersConnected()	4	1
A	getDownloadRate()	4	1
A	setPercentDone()	4	1
A	getPercentDone()	4	1
A	setFiles()	6	1
A	getFiles()	4	1
A	setPeers()	6	1
A	getPeers()	4	1
A	setTrackerStats()	6	1
A	getTrackerStats()	4	1
A	setTrackers()	6	1
A	getTrackers()	4	1
A	setUploadRatio()	4	1
A	getUploadRatio()	4	1
A	isStopped()	4	1
A	isChecking()	4	1
A	isDownloading()	4	1
A	isSeeding()	4	1
A	getDownloadDir()	4	1
A	setDownloadDir()	4	1
A	getDownloadedEver()	3	1
A	setDownloadedEver()	3	1
A	getUploadedEver()	3	1
A	setUploadedEver()	3	1
A	getComment()	3	1
A	setComment()	3	1
B	getMapping()	26	1

How to fix Complexity

<?php
namespace Transmission\Model;

use Transmission\Util\PropertyMapper;

/**
 * @author Ramon Kleiss <[email protected]>
 */
class Torrent extends AbstractModel
{
    /**
     * @var integer
     */
    protected $id;

    /**
     * @var integer
     */
    protected $eta;

    /**
     * @var integer
     */
    protected $size;

    /**
     * @var string
     */
    protected $name;

    /**
     * @var string
     */
    protected $hash;

    /**
     * @var integer
     */
    protected $status;

    /**
     * @var boolean
     */
    protected $finished;

    /**
     * @var integer
     */
    protected $startDate;
    
    /**
     * @var integer
     */
    protected $uploadRate;

    /**
     * @var integer
     */
    protected $downloadRate;

    /**
     * @var integer
     */
    protected $peersConnected;

    /**
     * @var double
     */
    protected $percentDone;

    /**
     * @var array
     */
    protected $files = array();

    /**
     * @var array
     */
    protected $peers = array();

    /**
     * @var array
     */
    protected $trackers = array();

    /**
     * @var array
     */
    protected $trackerStats = array();

    /**
     * @var double
     */
    protected $uploadRatio;
    
    /**
     * @var string
     */
    protected $downloadDir;

    /**
     * @var integer
     */
    protected $downloadedEver;

    /**
     * @var integer
     */
    protected $uploadedEver;

    /**
     * @var string
     */
    protected $comment;

    /**
     * @param integer $id
     */
    public function setId($id)
    {
        $this->id = (integer) $id;
    }

    /**
     * @return integer
     */
    public function getId()
    {
        return $this->id;
    }

    /**
     * @param integer $eta
     */
    public function setEta($eta)
    {
        $this->eta = (integer) $eta;
    }

    /**
     * @return integer
     */
    public function getEta()
    {
        return $this->eta;
    }

    /**
     * @param integer $size
     */
    public function setSize($size)
    {
        $this->size = (integer) $size;
    }

    /**
     * @return integer
     */
    public function getSize()
    {
        return $this->size;
    }

    /**
     * @param string $name
     */
    public function setName($name)
    {
        $this->name = (string) $name;
    }

    /**
     * @return string
     */
    public function getName()
    {
        return $this->name;
    }

    /**
     * @param string $hash
     */
    public function setHash($hash)
    {
        $this->hash = (string) $hash;
    }

    /**
     * @return string
     */
    public function getHash()
    {
        return $this->hash;
    }

    /**
     * @param integer|Transmission\Model\Status $status
     */
    public function setStatus($status)
    {
        $this->status = new Status($status);

    }

    /**
     * @return integer
     */
    public function getStatus()
    {
        return $this->status->getValue();

    }

    /**
     * @param boolean $finished
     */
    public function setFinished($finished)
    {
        $this->finished = (boolean) $finished;
    }

    /**
     * @return boolean
     */
    public function isFinished()
    {
        return ($this->finished || (int) $this->getPercentDone() == 100);
    }

    /**
     * @var integer $startDate
     */
    public function setStartDate($startDate)
    {
        $this->startDate = (integer) $startDate;
    }

    /**
     * @return integer
     */
    public function getStartDate()
    {
        return $this->startDate;
    }
    /**
     * @var integer $rate
     */
    public function setUploadRate($rate)
    {
        $this->uploadRate = (integer) $rate;
    }

    /**
     * @return integer
     */
    public function getUploadRate()
    {
        return $this->uploadRate;
    }

    /**
     * @param integer $rate
     */
    public function setDownloadRate($rate)
    {
        $this->downloadRate = (integer) $rate;
    }

    /**
     * @param integer $peersConnected
     */
    public function setPeersConnected($peersConnected)
    {
        $this->peersConnected = (integer) $peersConnected;
    }

    /**
     * @return integer
     */
    public function getPeersConnected()
    {
        return $this->peersConnected;
    }

    /**
     * @return integer
     */
    public function getDownloadRate()
    {
        return $this->downloadRate;
    }

    /**
     * @param double $done
     */
    public function setPercentDone($done)
    {
        $this->percentDone = (double) $done;
    }

    /**
     * @return double
     */
    public function getPercentDone()
    {
        return $this->percentDone * 100.0;
    }

    /**
     * @param array $files
     */
    public function setFiles(array $files)
    {
        $this->files = array_map(function ($file) {
            return PropertyMapper::map(new File(), $file);
        }, $files);
    }

    /**
     * @return array
     */
    public function getFiles()
    {
        return $this->files;
    }

    /**
     * @param array $peers
     */
    public function setPeers(array $peers)
    {
        $this->peers = array_map(function ($peer) {
            return PropertyMapper::map(new Peer(), $peer);
        }, $peers);
    }

    /**
     * @return array
     */
    public function getPeers()
    {
        return $this->peers;
    }
    /**
     * @param array $trackerStats
     */
    public function setTrackerStats(array $trackerStats)
    {
        $this->trackerStats = array_map(function ($trackerStats) {
            return PropertyMapper::map(new TrackerStats(), $trackerStats);
        }, $trackerStats);
    }

    /**
     * @return array
     */
    public function getTrackerStats()
    {
        return $this->trackerStats;
    }

    /**
     * @param array $trackers
     */
    public function setTrackers(array $trackers)
    {
        $this->trackers = array_map(function ($tracker) {
            return PropertyMapper::map(new Tracker(), $tracker);
        }, $trackers);
    }

    /**
     * @return array
     */
    public function getTrackers()
    {
        return $this->trackers;
    }

    /**
     * @param double $ratio
     */
    public function setUploadRatio($ratio)
    {
        $this->uploadRatio = (double) $ratio;
    }

    /**
     * @return double
     */
    public function getUploadRatio()
    {
        return $this->uploadRatio;
    }

    /**
     * @return boolean
     */
    public function isStopped()
    {
        return $this->status->isStopped();

    }

    /**
     * @return boolean
     */
    public function isChecking()
    {
        return $this->status->isChecking();

    }

    /**
     * @return boolean
     */
    public function isDownloading()
    {
        return $this->status->isDownloading();

    }

    /**
     * @return boolean
     */
    public function isSeeding()
    {
        return $this->status->isSeeding();

    }
    
    /**
     * @return string
     */
    public function getDownloadDir()
    {
        return $this->downloadDir;
    }

    /**
     * @param string $downloadDir
     */
    public function setDownloadDir($downloadDir)
    {
        $this->downloadDir = $downloadDir;
    }

    /**
     * @return int
     */
    public function getDownloadedEver() {
        return $this->downloadedEver;
    }

    /**
     * @param int $downloadedEver
     */
    public function setDownloadedEver($downloadedEver) {
        $this->downloadedEver = $downloadedEver;
    }

    /**
     * @return int
     */
    public function getUploadedEver() {
        return $this->uploadedEver;
    }

    /**
     * @param int $uploadedEver
     */
    public function setUploadedEver($uploadedEver) {
        $this->uploadedEver = $uploadedEver;
    }

    /**
     * @return string
     */
    public function getComment() {
        return $this->comment;
    }

    /**
     * @param string $comment
     */
    public function setComment($comment) {
        $this->comment = $comment;
    }

    /**
     * {@inheritDoc}
     */
    public static function getMapping()
    {
        return array(
            'id' => 'id',
            'eta' => 'eta',
            'sizeWhenDone' => 'size',
            'name' => 'name',
            'status' => 'status',
            'isFinished' => 'finished',
            'rateUpload' => 'uploadRate',
            'rateDownload' => 'downloadRate',
            'percentDone' => 'percentDone',
            'files' => 'files',
            'peers' => 'peers',
            'peersConnected' => 'peersConnected',
            'trackers' => 'trackers',
            'trackerStats' => 'trackerStats',
            'startDate' => 'startDate',
            'uploadRatio' => 'uploadRatio',
            'hashString' => 'hash',
            'downloadDir' => 'downloadDir',
            'downloadedEver' => 'downloadedEver',
            'uploadedEver' => 'uploadedEver',
            'comment' => 'comment'
        );
    }
}


GitHub Access Token became invalid

Pull Request — master (#57)

Torrent B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

47 Methods

How to fix Complexity

Complex Class

1			<?php
2			namespace Transmission\Model;
3
4			use Transmission\Util\PropertyMapper;
5
6			/**
7			* @author Ramon Kleiss <[email protected]>
8			*/
9			class Torrent extends AbstractModel
10			{
11			/**
12			* @var integer
13			*/
14			protected $id;
15
16			/**
17			* @var integer
18			*/
19			protected $eta;
20
21			/**
22			* @var integer
23			*/
24			protected $size;
25
26			/**
27			* @var string
28			*/
29			protected $name;
30
31			/**
32			* @var string
33			*/
34			protected $hash;
35
36			/**
37			* @var integer
38			*/
39			protected $status;
40
41			/**
42			* @var boolean
43			*/
44			protected $finished;
45
46			/**
47			* @var integer
48			*/
49			protected $startDate;
50
51			/**
52			* @var integer
53			*/
54			protected $uploadRate;
55
56			/**
57			* @var integer
58			*/
59			protected $downloadRate;
60
61			/**
62			* @var integer
63			*/
64			protected $peersConnected;
65
66			/**
67			* @var double
68			*/
69			protected $percentDone;
70
71			/**
72			* @var array
73			*/
74			protected $files = array();
75
76			/**
77			* @var array
78			*/
79			protected $peers = array();
80
81			/**
82			* @var array
83			*/
84			protected $trackers = array();
85
86			/**
87			* @var array
88			*/
89			protected $trackerStats = array();
90
91			/**
92			* @var double
93			*/
94			protected $uploadRatio;
95
96			/**
97			* @var string
98			*/
99			protected $downloadDir;
100
101			/**
102			* @var integer
103			*/
104			protected $downloadedEver;
105
106			/**
107			* @var integer
108			*/
109			protected $uploadedEver;
110
111			/**
112			* @var string
113			*/
114			protected $comment;
115
116			/**
117			* @param integer $id
118			*/
119			public function setId($id)
120			{
121			$this->id = (integer) $id;
122			}
123
124			/**
125			* @return integer
126			*/
127			public function getId()
128			{
129			return $this->id;
130			}
131
132			/**
133			* @param integer $eta
134			*/
135			public function setEta($eta)
136			{
137			$this->eta = (integer) $eta;
138			}
139
140			/**
141			* @return integer
142			*/
143			public function getEta()
144			{
145			return $this->eta;
146			}
147
148			/**
149			* @param integer $size
150			*/
151			public function setSize($size)
152			{
153			$this->size = (integer) $size;
154			}
155
156			/**
157			* @return integer
158			*/
159			public function getSize()
160			{
161			return $this->size;
162			}
163
164			/**
165			* @param string $name
166			*/
167			public function setName($name)
168			{
169			$this->name = (string) $name;
170			}
171
172			/**
173			* @return string
174			*/
175			public function getName()
176			{
177			return $this->name;
178			}
179
180			/**
181			* @param string $hash
182			*/
183			public function setHash($hash)
184			{
185			$this->hash = (string) $hash;
186			}
187
188			/**
189			* @return string
190			*/
191			public function getHash()
192			{
193			return $this->hash;
194			}
195
196			/**
197			* @param integer\|Transmission\Model\Status $status
198			*/
199			public function setStatus($status)
200			{
201			$this->status = new Status($status);
			0 ignored issues – show Documentation Bug introduced 2016-01-07 20:59 UTC by Report Bug Copy Issue Report It seems like `new \Transmission\Model\Status($status)` of type `object<Transmission\Model\Status>` is incompatible with the declared type `integer` of property `$status`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
202			}
203
204			/**
205			* @return integer
206			*/
207			public function getStatus()
208			{
209			return $this->status->getValue();
			0 ignored issues – show Bug introduced 2016-01-07 20:59 UTC by Report Bug Copy Issue Report The method `getValue` cannot be called on `$this->status` (of type `integer`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
210			}
211
212			/**
213			* @param boolean $finished
214			*/
215			public function setFinished($finished)
216			{
217			$this->finished = (boolean) $finished;
218			}
219
220			/**
221			* @return boolean
222			*/
223			public function isFinished()
224			{
225			return ($this->finished \|\| (int) $this->getPercentDone() == 100);
226			}
227
228			/**
229			* @var integer $startDate
230			*/
231			public function setStartDate($startDate)
232			{
233			$this->startDate = (integer) $startDate;
234			}
235
236			/**
237			* @return integer
238			*/
239			public function getStartDate()
240			{
241			return $this->startDate;
242			}
243			/**
244			* @var integer $rate
245			*/
246			public function setUploadRate($rate)
247			{
248			$this->uploadRate = (integer) $rate;
249			}
250
251			/**
252			* @return integer
253			*/
254			public function getUploadRate()
255			{
256			return $this->uploadRate;
257			}
258
259			/**
260			* @param integer $rate
261			*/
262			public function setDownloadRate($rate)
263			{
264			$this->downloadRate = (integer) $rate;
265			}
266
267			/**
268			* @param integer $peersConnected
269			*/
270			public function setPeersConnected($peersConnected)
271			{
272			$this->peersConnected = (integer) $peersConnected;
273			}
274
275			/**
276			* @return integer
277			*/
278			public function getPeersConnected()
279			{
280			return $this->peersConnected;
281			}
282
283			/**
284			* @return integer
285			*/
286			public function getDownloadRate()
287			{
288			return $this->downloadRate;
289			}
290
291			/**
292			* @param double $done
293			*/
294			public function setPercentDone($done)
295			{
296			$this->percentDone = (double) $done;
297			}
298
299			/**
300			* @return double
301			*/
302			public function getPercentDone()
303			{
304			return $this->percentDone * 100.0;
305			}
306
307			/**
308			* @param array $files
309			*/
310			public function setFiles(array $files)
311			{
312			$this->files = array_map(function ($file) {
313			return PropertyMapper::map(new File(), $file);
314			}, $files);
315			}
316
317			/**
318			* @return array
319			*/
320			public function getFiles()
321			{
322			return $this->files;
323			}
324
325			/**
326			* @param array $peers
327			*/
328			public function setPeers(array $peers)
329			{
330			$this->peers = array_map(function ($peer) {
331			return PropertyMapper::map(new Peer(), $peer);
332			}, $peers);
333			}
334
335			/**
336			* @return array
337			*/
338			public function getPeers()
339			{
340			return $this->peers;
341			}
342			/**
343			* @param array $trackerStats
344			*/
345			public function setTrackerStats(array $trackerStats)
346			{
347			$this->trackerStats = array_map(function ($trackerStats) {
348			return PropertyMapper::map(new TrackerStats(), $trackerStats);
349			}, $trackerStats);
350			}
351
352			/**
353			* @return array
354			*/
355			public function getTrackerStats()
356			{
357			return $this->trackerStats;
358			}
359
360			/**
361			* @param array $trackers
362			*/
363			public function setTrackers(array $trackers)
364			{
365			$this->trackers = array_map(function ($tracker) {
366			return PropertyMapper::map(new Tracker(), $tracker);
367			}, $trackers);
368			}
369
370			/**
371			* @return array
372			*/
373			public function getTrackers()
374			{
375			return $this->trackers;
376			}
377
378			/**
379			* @param double $ratio
380			*/
381			public function setUploadRatio($ratio)
382			{
383			$this->uploadRatio = (double) $ratio;
384			}
385
386			/**
387			* @return double
388			*/
389			public function getUploadRatio()
390			{
391			return $this->uploadRatio;
392			}
393
394			/**
395			* @return boolean
396			*/
397			public function isStopped()
398			{
399			return $this->status->isStopped();
			0 ignored issues – show Bug introduced 2016-01-07 20:59 UTC by Report Bug Copy Issue Report The method `isStopped` cannot be called on `$this->status` (of type `integer`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
400			}
401
402			/**
403			* @return boolean
404			*/
405			public function isChecking()
406			{
407			return $this->status->isChecking();
			0 ignored issues – show Bug introduced 2016-01-07 20:59 UTC by Report Bug Copy Issue Report The method `isChecking` cannot be called on `$this->status` (of type `integer`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
408			}
409
410			/**
411			* @return boolean
412			*/
413			public function isDownloading()
414			{
415			return $this->status->isDownloading();
			0 ignored issues – show Bug introduced 2016-01-07 20:59 UTC by Report Bug Copy Issue Report The method `isDownloading` cannot be called on `$this->status` (of type `integer`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
416			}
417
418			/**
419			* @return boolean
420			*/
421			public function isSeeding()
422			{
423			return $this->status->isSeeding();
			0 ignored issues – show Bug introduced 2016-01-07 20:59 UTC by Report Bug Copy Issue Report The method `isSeeding` cannot be called on `$this->status` (of type `integer`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
424			}
425
426			/**
427			* @return string
428			*/
429			public function getDownloadDir()
430			{
431			return $this->downloadDir;
432			}
433
434			/**
435			* @param string $downloadDir
436			*/
437			public function setDownloadDir($downloadDir)
438			{
439			$this->downloadDir = $downloadDir;
440			}
441
442			/**
443			* @return int
444			*/
445			public function getDownloadedEver() {
446			return $this->downloadedEver;
447			}
448
449			/**
450			* @param int $downloadedEver
451			*/
452			public function setDownloadedEver($downloadedEver) {
453			$this->downloadedEver = $downloadedEver;
454			}
455
456			/**
457			* @return int
458			*/
459			public function getUploadedEver() {
460			return $this->uploadedEver;
461			}
462
463			/**
464			* @param int $uploadedEver
465			*/
466			public function setUploadedEver($uploadedEver) {
467			$this->uploadedEver = $uploadedEver;
468			}
469
470			/**
471			* @return string
472			*/
473			public function getComment() {
474			return $this->comment;
475			}
476
477			/**
478			* @param string $comment
479			*/
480			public function setComment($comment) {
481			$this->comment = $comment;
482			}
483
484			/**
485			* {@inheritDoc}
486			*/
487			public static function getMapping()
488			{
489			return array(
490			'id' => 'id',
491			'eta' => 'eta',
492			'sizeWhenDone' => 'size',
493			'name' => 'name',
494			'status' => 'status',
495			'isFinished' => 'finished',
496			'rateUpload' => 'uploadRate',
497			'rateDownload' => 'downloadRate',
498			'percentDone' => 'percentDone',
499			'files' => 'files',
500			'peers' => 'peers',
501			'peersConnected' => 'peersConnected',
502			'trackers' => 'trackers',
503			'trackerStats' => 'trackerStats',
504			'startDate' => 'startDate',
505			'uploadRatio' => 'uploadRatio',
506			'hashString' => 'hash',
507			'downloadDir' => 'downloadDir',
508			'downloadedEver' => 'downloadedEver',
509			'uploadedEver' => 'uploadedEver',
510			'comment' => 'comment'
511			);
512			}
513			}
514

kleiram / transmission-php

GitHub Access Token became invalid

Pull Request — master (#57)

Torrent B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

47 Methods

How to fix Complexity

Complex Class

Duplication Side-by-Side

Filter issues like