KleijnWeb\SwaggerBundle\Tests\Request\ContentDecoder\ContentDecoderJmsSerializerCompatibilityTest

Complexity

Total Complexity

5

Size/Duplication

Total Lines	116
Duplicated Lines	55.17 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes	4
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	8	1
A	willThrowMalformedContentExceptionWhenDecodingFails()	9	9	1
B	canDeserializeIntoObject()	30	30	1
B	willAlwaysDecodeJson()	25	25	1
A	contentTypeProvider()	0	7	1

<?php
/*
 * This file is part of the KleijnWeb\SwaggerBundle package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace KleijnWeb\SwaggerBundle\Tests\Request\ContentDecoder;

use JMS\Serializer\Serializer;
use KleijnWeb\SwaggerBundle\Document\OperationObject;
use KleijnWeb\SwaggerBundle\Request\ContentDecoder;
use KleijnWeb\SwaggerBundle\Serializer\JmsSerializerFactory;
use KleijnWeb\SwaggerBundle\Serializer\SerializationTypeResolver;
use KleijnWeb\SwaggerBundle\Serializer\SerializerAdapter;
use Symfony\Component\HttpFoundation\Request;

/**
 * @author John Kleijn <john@kleijnweb.nl>
 */
class ContentDecoderJmsSerializerCompatibilityTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @var ContentDecoder
     */
    private $contentDecoder;

    /**
     * @var Serializer
     */
    private $serializer;

    /**
     * Create serializer
     */
    protected function setUp()
    {
        $this->serializer = new SerializerAdapter(JmsSerializerFactory::factory());

It seems like new \KleijnWeb\SwaggerBundle\Serializer\SerializerAdapter(\KleijnWeb\SwaggerBundle\Serializer\JmsSerializerFactory::factory()) of type object<KleijnWeb\SwaggerBundle\Serializer\SerializerAdapter> is incompatible with the declared type object<JMS\Serializer\Serializer> of property $serializer.

        $this->contentDecoder = new ContentDecoder(
            $this->serializer,
            new SerializationTypeResolver('KleijnWeb\SwaggerBundle\Tests\Request\ContentDecoder')
        );
    }

    /**
     * @test
     */
    public function canDeserializeIntoObject()

This method seems to be duplicated in your project.

    {
        $content = [
            'foo' => 'bar'
        ];
        $request = new Request([], [], [], [], [], [], json_encode($content));
        $request->headers->set('Content-Type', 'application/json');


        $operationDefinition = (object)[
            'parameters' => [
                (object)[
                    "in"     => "body",
                    "name"   => "body",
                    "schema" => (object)[
                        '$ref' => "#/definitions/JmsAnnotatedResourceStub"
                    ]
                ]
            ]
        ];

        $operationObject = OperationObject::createFromOperationDefinition((object)$operationDefinition);

        $actual = $this->contentDecoder->decodeContent($request, $operationObject);

        $className = 'KleijnWeb\SwaggerBundle\Tests\Request\ContentDecoder\JmsAnnotatedResourceStub';
        $expected = (new $className)->setFoo('bar');

        $this->assertEquals($expected, $actual);
    }

    /**
     * @test
     *
     * @expectedException \KleijnWeb\SwaggerBundle\Exception\MalformedContentException
     */
    public function willThrowMalformedContentExceptionWhenDecodingFails()

This method seems to be duplicated in your project.

    {
        $content = 'lkjhlkj';
        $request = new Request([], [], [], [], [], [], $content);
        $request->headers->set('Content-Type', 'application/json');

        $operationObject = OperationObject::createFromOperationDefinition((object)[]);
        $this->contentDecoder->decodeContent($request, $operationObject);
    }

    /**
     * @test
     * @dataProvider contentTypeProvider
     *
     * @param string $contentType
     */
    public function willAlwaysDecodeJson($contentType)

This method seems to be duplicated in your project.

    {
        $content = '{ "foo": "bar" }';
        $request = new Request([], [], [], [], [], [], $content);
        $request->headers->set('Content-Type', $contentType);

        $operationDefinition = (object)[
            'parameters' => [
                (object)[
                    "in"     => "body",
                    "name"   => "body",
                    "schema" => (object)[
                        '$ref' => "#/definitions/JmsAnnotatedResourceStub"
                    ]
                ]
            ]
        ];

        $operationObject = OperationObject::createFromOperationDefinition((object)$operationDefinition);

        $actual = $this->contentDecoder->decodeContent($request, $operationObject);
        $className = 'KleijnWeb\SwaggerBundle\Tests\Request\ContentDecoder\JmsAnnotatedResourceStub';
        $expected = (new $className)->setFoo('bar');
        $this->assertEquals($expected, $actual);
    }

    /**
     * @return array
     */
    public static function contentTypeProvider()
    {
        return [
            ['application/json'],
            ['application/vnd.api+json']
        ];
    }
}