Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
20 | class SwaggerDocumentTest extends \PHPUnit_Framework_TestCase |
||
21 | { |
||
22 | /** |
||
23 | * @test |
||
24 | */ |
||
25 | View Code Duplication | public function canGetPathDefinitions() |
|
36 | |||
37 | /** |
||
38 | * @test |
||
39 | */ |
||
40 | View Code Duplication | public function getOperationDefinition() |
|
50 | |||
51 | /** |
||
52 | * @test |
||
53 | */ |
||
54 | public function getOperationDefinitionHttpMethodIsCaseInsensitive() |
||
58 | |||
59 | |||
60 | /** |
||
61 | * @expectedException \InvalidArgumentException |
||
62 | * @test |
||
63 | */ |
||
64 | public function getOperationDefinitionWillFailOnUnknownHttpMethod() |
||
68 | |||
69 | /** |
||
70 | * @expectedException \InvalidArgumentException |
||
71 | * @test |
||
72 | */ |
||
73 | public function getOperationDefinitionWillFailOnUnknownPath() |
||
77 | |||
78 | /** |
||
79 | * @return SwaggerDocument |
||
80 | */ |
||
81 | public static function getPetStoreDocument() |
||
87 | } |
||
88 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.