EncoderTest - Code Metrics - Inspection of "Merge pull request #8 from Zwartpet/feature/jwt-to..." - kleijnweb/jwt-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a2a7f2...f21cde )

by John

created 2016-05-04 07:38 UTC

EncoderTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	51
Duplicated Lines	41.18 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes	2
Bugs	0	Features	2

Metric	Value
wmc	3
c	2
b	0
f	2
lcom	0
cbo	2
dl	21
loc	51
rs	10

3 Methods

Rating	Name	Duplication	Size	Complexity
A	willDecodeTestCasesFromJwtDotIo()	0	5	1
A	willThrowExceptionWhenJsonDecodeFails()	0	5	1
A	testSetProvider()	21	21	1

How to fix Duplicated Code

<?php
/*
 * This file is part of the KleijnWeb\JwtBundle package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace KleijnWeb\JwtBundle\Tests\Authenticator;

use KleijnWeb\JwtBundle\Authenticator\Encoder;

/**
 * @author John Kleijn <[email protected]>
 */
class EncoderTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @param string $data
     * @param array  $source
     *
     * @test
     * @dataProvider testSetProvider
     */
    public function willDecodeTestCasesFromJwtDotIo($source, $data)
    {
        $encoder = new Encoder();
        $this->assertSame($data, $encoder->encode($source));
    }

    /**
     * @test
     * @expectedException \RuntimeException
     */
    public function willThrowExceptionWhenJsonDecodeFails()
    {
        $decoder = new Encoder();
        $decoder->jsonEncode("\xB1\x31");
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * @see          http://jwt.io/
     * @return array
     */
    public static function testSetProvider()

    {
        return [
            [
                [
                    'alg' => 'HS256',
                    'typ' => 'JWT',
                ],
                'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9'
            ],
            [
                [
                    'sub'   => '1234567890',
                    'name'  => 'John Doe',
                    'admin' => true,
                ]
                ,
                'eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiYWRtaW4iOnRydWV9'
            ]
        ];
    }
}


1		<?php
2		/*
3		* This file is part of the KleijnWeb\JwtBundle package.
4		*
5		* For the full copyright and license information, please view the LICENSE
6		* file that was distributed with this source code.
7		*/
8		namespace KleijnWeb\JwtBundle\Tests\Authenticator;
9
10		use KleijnWeb\JwtBundle\Authenticator\Encoder;
11
12		/**
13		* @author John Kleijn <[email protected]>
14		*/
15		class EncoderTest extends \PHPUnit_Framework_TestCase
16		{
17		/**
18		* @param string $data
19		* @param array $source
20		*
21		* @test
22		* @dataProvider testSetProvider
23		*/
24		public function willDecodeTestCasesFromJwtDotIo($source, $data)
25		{
26		$encoder = new Encoder();
27		$this->assertSame($data, $encoder->encode($source));
28		}
29
30		/**
31		* @test
32		* @expectedException \RuntimeException
33		*/
34		public function willThrowExceptionWhenJsonDecodeFails()
35		{
36		$decoder = new Encoder();
37		$decoder->jsonEncode("\xB1\x31");
		0 ignored issues – show Documentation introduced 2016-05-04 07:31 UTC by Report Bug Copy Issue Report `'±1'` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
38		}
39
40		/**
41		* @see http://jwt.io/
42		* @return array
43		*/
44	View Code Duplication	public static function testSetProvider()
		0 ignored issues – show Duplication introduced 2016-05-04 07:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
45		{
46		return [
47		[
48		[
49		'alg' => 'HS256',
50		'typ' => 'JWT',
51		],
52		'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9'
53		],
54		[
55		[
56		'sub' => '1234567890',
57		'name' => 'John Doe',
58		'admin' => true,
59		]
60		,
61		'eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiYWRtaW4iOnRydWV9'
62		]
63		];
64		}
65		}
66

kleijnweb / jwt-bundle

Push — master ( a2a7f2...f21cde )

EncoderTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like