Failed Conditions
Push — dev/store-tests ( 7e7716...b538ec )
by Kiyotaka
05:30
created

ComposerServiceFactory   A

Complexity

Total Complexity 2

Size/Duplication

Total Lines 12
Duplicated Lines 0 %

Coupling/Cohesion

Components 0
Dependencies 2

Importance

Changes 0
Metric Value
dl 0
loc 12
rs 10
c 0
b 0
f 0
wmc 2
lcom 0
cbo 2

1 Method

Rating   Name   Duplication   Size   Complexity  
A createService() 0 9 2
1
<?php
2
/*
3
 * This file is part of EC-CUBE
4
 *
5
 * Copyright(c) 2000-2018 LOCKON CO.,LTD. All Rights Reserved.
6
 *
7
 * http://www.lockon.co.jp/
8
 *
9
 * This program is free software; you can redistribute it and/or
10
 * modify it under the terms of the GNU General Public License
11
 * as published by the Free Software Foundation; either version 2
12
 * of the License, or (at your option) any later version.
13
 *
14
 * This program is distributed in the hope that it will be useful,
15
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
16
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
17
 * GNU General Public License for more details.
18
 *
19
 * You should have received a copy of the GNU General Public License
20
 * along with this program; if not, write to the Free Software
21
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
22
 */
23
24
namespace Eccube\Service\Composer;
25
26
27
use Eccube\Entity\BaseInfo;
28
use Eccube\Repository\BaseInfoRepository;
29
use Symfony\Component\DependencyInjection\ContainerInterface;
30
31
class ComposerServiceFactory
32
{
33
   public static function createService(ContainerInterface $container)
34
    {
35
        /** @var BaseInfo $BaseInfo */
36
        $BaseInfo = $container->get(BaseInfoRepository::class)->get();
37
        if ($BaseInfo->getPhpPath()) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $BaseInfo->getPhpPath() of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

In PHP, under loose comparison (like ==, or !=, or switch conditions), values of different types might be equal.

For string values, the empty string '' is a special case, in particular the following results might be unexpected:

''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
Loading history...
38
            return $container->get(ComposerProcessService::class);
39
        }
40
        return $container->get(ComposerApiService::class);
41
    }
42
}