LogController::index() - Code Metrics - Inspection of "ログインユーザ名カスタマイズのテストを追加" - kiy0taka/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/customize-username ( bb12d9...1746f4 )

by Kiyotaka

created 2020-10-21 04:19 UTC

LogController::index() B

↳ Parent: LogController

Complexity

Conditions	7
Paths	6

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	7
nc	6
nop	1
dl	0
loc	60
rs	7.9393
c	0
b	0
f	0

How to fix Long Method

<?php

/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) EC-CUBE CO.,LTD. All Rights Reserved.
 *
 * http://www.ec-cube.co.jp/
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Eccube\Controller\Admin\Setting\System;

use Eccube\Controller\AbstractController;
use Eccube\Event\EccubeEvents;
use Eccube\Event\EventArgs;
use Eccube\Form\Type\Admin\LogType;
use Symfony\Component\Routing\Annotation\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\StreamedResponse;

class LogController extends AbstractController
{
    /**
     * @Route("/%eccube_admin_route%/setting/system/log", name="admin_setting_system_log")
     * @Template("@admin/Setting/System/log.twig")
     *
     * @return array|Symfony\Component\HttpFoundation\StreamedResponse
     */
    public function index(Request $request)
    {
        $formData = [];
        // default
        $formData['files'] = 'site_'.date('Y-m-d').'.log';
        $formData['line_max'] = '50';

        $builder = $this->formFactory
            ->createBuilder(LogType::class);

        $event = new EventArgs(
            [
                'builder' => $builder,
                'data' => $formData,
            ],
            $request
        );
        $this->eventDispatcher->dispatch(EccubeEvents::ADMIN_SETTING_SYSTEM_LOG_INDEX_INITIALIZE, $event);
        $formData = $event->getArgument('data');

        $form = $builder->getForm();

        if ('POST' === $request->getMethod()) {
            $form->handleRequest($request);
            if ($form->isValid()) {
                $formData = $form->getData();
            }
            $event = new EventArgs(
                [
                    'form' => $form,
                ],
                $request
            );
            $this->eventDispatcher->dispatch(EccubeEvents::ADMIN_SETTING_SYSTEM_LOG_INDEX_COMPLETE, $event);
        }
        $logDir = $this->getParameter('kernel.logs_dir').DIRECTORY_SEPARATOR.$this->getParameter('kernel.environment');
        $logFile = $logDir.'/'.$formData['files'];

        if ($form->getClickedButton() && $form->getClickedButton()->getName() === 'download') {
            $bufferSize = 1024 * 50;
            $response = new StreamedResponse();
            $response->headers->set('Content-Length',filesize($logFile));
            $response->headers->set('Content-Disposition','attachment; filename=' . basename($logFile));
            $response->headers->set('Content-Type','application/octet-stream');
            $response->setCallback(function() use($logFile,$bufferSize) {
                if ($fh = fopen($logFile,'r')) {
                    while (!feof($fh)) {
                        echo fread($fh,$bufferSize);
                    }
                }
            });
            $response->send();
            return $response;
        } else {
            return [
                'form' => $form->createView(),
                'log' => $this->parseLogFile($logFile, $formData),
            ];
        }
    }

    /**
     * parse log file
     *
     * @param string $logFile
     * @param $formData
     *
     * @return array
     */
    private function parseLogFile($logFile, $formData)
    {
        $log = [];

        if (!file_exists($logFile)) {
            return $log;
        }

        foreach (array_reverse(file($logFile, FILE_IGNORE_NEW_LINES | FILE_SKIP_EMPTY_LINES)) as $line) {
            // 上限に達した場合、処理を抜ける
            if (count($log) >= $formData['line_max']) {
                break;
            }

            $log[] = $line;
        }

        return $log;
    }
}


1			<?php
2
3			/*
4			* This file is part of EC-CUBE
5			*
6			* Copyright(c) EC-CUBE CO.,LTD. All Rights Reserved.
7			*
8			* http://www.ec-cube.co.jp/
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace Eccube\Controller\Admin\Setting\System;
15
16			use Eccube\Controller\AbstractController;
17			use Eccube\Event\EccubeEvents;
18			use Eccube\Event\EventArgs;
19			use Eccube\Form\Type\Admin\LogType;
20			use Symfony\Component\Routing\Annotation\Route;
21			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
22			use Symfony\Component\HttpFoundation\Request;
23			use Symfony\Component\HttpFoundation\StreamedResponse;
24
25			class LogController extends AbstractController
26			{
27			/**
28			* @Route("/%eccube_admin_route%/setting/system/log", name="admin_setting_system_log")
29			* @Template("@admin/Setting/System/log.twig")
30			*
31			* @return array\|Symfony\Component\HttpFoundation\StreamedResponse
32			*/
33			public function index(Request $request)
34			{
35			$formData = [];
36			// default
37			$formData['files'] = 'site_'.date('Y-m-d').'.log';
38			$formData['line_max'] = '50';
39
40			$builder = $this->formFactory
41			->createBuilder(LogType::class);
42
43			$event = new EventArgs(
44			[
45			'builder' => $builder,
46			'data' => $formData,
47			],
48			$request
49			);
50			$this->eventDispatcher->dispatch(EccubeEvents::ADMIN_SETTING_SYSTEM_LOG_INDEX_INITIALIZE, $event);
51			$formData = $event->getArgument('data');
52
53			$form = $builder->getForm();
54
55			if ('POST' === $request->getMethod()) {
56			$form->handleRequest($request);
57			if ($form->isValid()) {
58			$formData = $form->getData();
59			}
60			$event = new EventArgs(
61			[
62			'form' => $form,
63			],
64			$request
65			);
66			$this->eventDispatcher->dispatch(EccubeEvents::ADMIN_SETTING_SYSTEM_LOG_INDEX_COMPLETE, $event);
67			}
68			$logDir = $this->getParameter('kernel.logs_dir').DIRECTORY_SEPARATOR.$this->getParameter('kernel.environment');
69			$logFile = $logDir.'/'.$formData['files'];
70
71			if ($form->getClickedButton() && $form->getClickedButton()->getName() === 'download') {
72			$bufferSize = 1024 * 50;
73			$response = new StreamedResponse();
74			$response->headers->set('Content-Length',filesize($logFile));
75			$response->headers->set('Content-Disposition','attachment; filename=' . basename($logFile));
76			$response->headers->set('Content-Type','application/octet-stream');
77			$response->setCallback(function() use($logFile,$bufferSize) {
78			if ($fh = fopen($logFile,'r')) {
79			while (!feof($fh)) {
80			echo fread($fh,$bufferSize);
81			}
82			}
83			});
84			$response->send();
85			return $response;
86			} else {
87			return [
88			'form' => $form->createView(),
89			'log' => $this->parseLogFile($logFile, $formData),
90			];
91			}
92			}
93
94			/**
95			* parse log file
96			*
97			* @param string $logFile
98			* @param $formData
99			*
100			* @return array
101			*/
102			private function parseLogFile($logFile, $formData)
103			{
104			$log = [];
105
106			if (!file_exists($logFile)) {
107			return $log;
108			}
109
110			foreach (array_reverse(file($logFile, FILE_IGNORE_NEW_LINES \| FILE_SKIP_EMPTY_LINES)) as $line) {
111			// 上限に達した場合、処理を抜ける
112			if (count($log) >= $formData['line_max']) {
113			break;
114			}
115
116			$log[] = $line;
117			}
118
119			return $log;
120			}
121			}
122

kiy0taka / ec-cube

Push — feature/customize-username ( bb12d9...1746f4 )

LogController::index() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like