PurchaseFlow::commit() - Code Metrics - Inspection of "scrutinizer対応" - kiy0taka/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — sf/last-boss ( 53d963...58156b )

by Kiyotaka

created 2018-08-31 04:23 UTC

PurchaseFlow::commit() A

↳ Parent: PurchaseFlow

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
nc	2
nop	2
dl	0
loc	8
rs	10
c	0
b	0
f	0

<?php

/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Eccube\Service\PurchaseFlow;

use Doctrine\Common\Collections\ArrayCollection;
use Eccube\Entity\ItemHolderInterface;
use Eccube\Entity\ItemInterface;
use Eccube\Entity\Order;
use Eccube\Entity\OrderItem;

class PurchaseFlow
{
    /**
     * @var string
     */
    protected $flowType;

    /**
     * @var ArrayCollection|ItemPreprocessor[]
     */
    protected $itemPreprocessors;

    /**
     * @var ArrayCollection|ItemHolderPreprocessor[]
     */
    protected $itemHolderPreprocessors;

    /**
     * @var ArrayCollection|ItemValidator[]
     */
    protected $itemValidators;

    /**
     * @var ArrayCollection|ItemHolderValidator[]
     */
    protected $itemHolderValidators;

    /**
     * @var ArrayCollection|ItemHolderPostValidator[]
     */
    protected $itemHolderPostValidators;

    /**
     * @var ArrayCollection|DiscountProcessor[]
     */
    protected $discountProcessors;

    /**
     * @var ArrayCollection|PurchaseProcessor[]
     */
    protected $purchaseProcessors;

    public function __construct()
    {
        $this->purchaseProcessors = new ArrayCollection();
        $this->itemValidators = new ArrayCollection();
        $this->itemHolderValidators = new ArrayCollection();
        $this->itemPreprocessors = new ArrayCollection();
        $this->itemHolderPreprocessors = new ArrayCollection();
        $this->itemHolderPostValidators = new ArrayCollection();
        $this->discountProcessors = new ArrayCollection();
    }

    public function setFlowType($flowType)
    {
        $this->flowType = $flowType;
    }

    public function setPurchaseProcessors(ArrayCollection $processors)
    {
        $this->purchaseProcessors = $processors;
    }

    public function setItemValidators(ArrayCollection $itemValidators)
    {
        $this->itemValidators = $itemValidators;
    }

    public function setItemHolderValidators(ArrayCollection $itemHolderValidators)
    {
        $this->itemHolderValidators = $itemHolderValidators;
    }

    public function setItemPreprocessors(ArrayCollection $itemPreprocessors)
    {
        $this->itemPreprocessors = $itemPreprocessors;
    }

    public function setItemHolderPreprocessors(ArrayCollection $itemHolderPreprocessors)
    {
        $this->itemHolderPreprocessors = $itemHolderPreprocessors;
    }

    public function setItemHolderPostValidators(ArrayCollection $itemHolderPostValidators)
    {
        $this->itemHolderPostValidators = $itemHolderPostValidators;
    }

    public function setDiscountProcessors(ArrayCollection $discountProcessors)
    {
        $this->discountProcessors = $discountProcessors;
    }

    public function validate(ItemHolderInterface $itemHolder, PurchaseContext $context)
    {
        $context->setFlowType($this->flowType);

        $this->calculateAll($itemHolder);

        $flowResult = new PurchaseFlowResult($itemHolder);

        foreach ($itemHolder->getItems() as $item) {
            foreach ($this->itemValidators as $itemValidator) {
                $result = $itemValidator->execute($item, $context);
                $flowResult->addProcessResult($result);
            }
        }

        $this->calculateAll($itemHolder);

        foreach ($this->itemHolderValidators as $itemHolderValidator) {
            $result = $itemHolderValidator->execute($itemHolder, $context);
            $flowResult->addProcessResult($result);
        }

        $this->calculateAll($itemHolder);

        foreach ($itemHolder->getItems() as $item) {
            foreach ($this->itemPreprocessors as $itemPreprocessor) {
                $itemPreprocessor->process($item, $context);
            }
        }

        $this->calculateAll($itemHolder);

        foreach ($this->itemHolderPreprocessors as $holderPreprocessor) {
            $result = $holderPreprocessor->process($itemHolder, $context);
            if ($result) {
                $flowResult->addProcessResult($result);
            }

            $this->calculateAll($itemHolder);
        }

        foreach ($this->discountProcessors as $discountProcessor) {
            $discountProcessor->removeDiscountItem($itemHolder, $context);
        }

        $this->calculateAll($itemHolder);

        foreach ($this->discountProcessors as $discountProcessor) {
            $result = $discountProcessor->addDiscountItem($itemHolder, $context);
            if ($result) {
                $flowResult->addProcessResult($result);
            }
            $this->calculateAll($itemHolder);
        }

        foreach ($this->itemHolderPostValidators as $itemHolderPostValidator) {
            $result = $itemHolderPostValidator->execute($itemHolder, $context);
            $flowResult->addProcessResult($result);

            $this->calculateAll($itemHolder);
        }

        return $flowResult;
    }

    /**
     * 購入フロー仮確定処理.
     *
     * @param ItemHolderInterface $target
     * @param PurchaseContext $context
     *
     * @throws PurchaseException
     */
    public function prepare(ItemHolderInterface $target, PurchaseContext $context)
    {
        $context->setFlowType($this->flowType);

        foreach ($this->purchaseProcessors as $processor) {
            $processor->prepare($target, $context);
        }
    }

    /**
     * 購入フロー確定処理.
     *
     * @param ItemHolderInterface $target
     * @param PurchaseContext $context
     *
     * @throws PurchaseException
     */
    public function commit(ItemHolderInterface $target, PurchaseContext $context)
    {
        $context->setFlowType($this->flowType);

        foreach ($this->purchaseProcessors as $processor) {
            $processor->commit($target, $context);
        }
    }

    /**
     * 購入フロー仮確定取り消し処理.
     *
     * @param ItemHolderInterface $target
     * @param PurchaseContext $context
     */
    public function rollback(ItemHolderInterface $target, PurchaseContext $context)
    {
        $context->setFlowType($this->flowType);

        foreach ($this->purchaseProcessors as $processor) {
            $processor->rollback($target, $context);
        }
    }

    public function addPurchaseProcessor(PurchaseProcessor $processor)
    {
        $this->purchaseProcessors[] = $processor;
    }

    public function addItemHolderPreprocessor(ItemHolderPreprocessor $holderPreprocessor)
    {
        $this->itemHolderPreprocessors[] = $holderPreprocessor;
    }

    public function addItemPreprocessor(ItemPreprocessor $itemPreprocessor)
    {
        $this->itemPreprocessors[] = $itemPreprocessor;
    }

    public function addItemValidator(ItemValidator $itemValidator)
    {
        $this->itemValidators[] = $itemValidator;
    }

    public function addItemHolderValidator(ItemHolderValidator $itemHolderValidator)
    {
        $this->itemHolderValidators[] = $itemHolderValidator;
    }

    public function addItemHolderPostValidator(ItemHolderPostValidator $itemHolderValidator)
    {
        $this->itemHolderPostValidators[] = $itemHolderValidator;
    }

    public function addDiscountProcessor(DiscountProcessor $discountProcessor)
    {
        $this->discountProcessors[] = $discountProcessor;
    }

    /**
     * @param ItemHolderInterface $itemHolder
     */
    protected function calculateTotal(ItemHolderInterface $itemHolder)

    {
        $total = array_reduce($itemHolder->getItems()->toArray(), function ($sum, ItemInterface $item) {

            $sum += $item->getPriceIncTax() * $item->getQuantity();


            return $sum;
        }, 0);
        $itemHolder->setTotal($total);
        // TODO
        if ($itemHolder instanceof Order) {
            // Order には PaymentTotal もセットする
            $itemHolder->setPaymentTotal($total);
        }
    }

    protected function calculateSubTotal(ItemHolderInterface $itemHolder)

    {
        $total = $itemHolder->getItems()

            ->getProductClasses()
            ->reduce(function ($sum, ItemInterface $item) {
                $sum += $item->getPriceIncTax() * $item->getQuantity();


                return $sum;
            }, 0);
        // TODO
        if ($itemHolder instanceof Order) {
            // Order の場合は SubTotal をセットする
            $itemHolder->setSubTotal($total);
        }
    }

    /**
     * @param ItemHolderInterface $itemHolder
     */
    protected function calculateDeliveryFeeTotal(ItemHolderInterface $itemHolder)

    {
        $total = $itemHolder->getItems()

            ->getDeliveryFees()
            ->reduce(function ($sum, ItemInterface $item) {
                $sum += $item->getPriceIncTax() * $item->getQuantity();


                return $sum;
            }, 0);
        $itemHolder->setDeliveryFeeTotal($total);
    }

    /**
     * @param ItemHolderInterface $itemHolder
     */
    protected function calculateDiscount(ItemHolderInterface $itemHolder)

    {
        $total = $itemHolder->getItems()

            ->getDiscounts()
            ->reduce(function ($sum, ItemInterface $item) {
                $sum += $item->getPriceIncTax() * $item->getQuantity();


                return $sum;
            }, 0);
        // TODO 後方互換のため discount には正の整数を代入する
        $itemHolder->setDiscount($total * -1);
    }

    /**
     * @param ItemHolderInterface $itemHolder
     */
    protected function calculateCharge(ItemHolderInterface $itemHolder)

    {
        $total = $itemHolder->getItems()

            ->getCharges()
            ->reduce(function ($sum, ItemInterface $item) {
                $sum += $item->getPriceIncTax() * $item->getQuantity();


                return $sum;
            }, 0);
        $itemHolder->setCharge($total);
    }

    /**
     * @param ItemHolderInterface $itemHolder
     */
    protected function calculateTax(ItemHolderInterface $itemHolder)
    {
        $total = $itemHolder->getItems()

            ->reduce(function ($sum, ItemInterface $item) {
                if ($item instanceof OrderItem) {
                    $sum += $item->getTax() * $item->getQuantity();
                } else {
                    $sum += ($item->getPriceIncTax() - $item->getPrice()) * $item->getQuantity();

                }

                return $sum;
            }, 0);
        $itemHolder->setTax($total);
    }

    /**
     * @param ItemHolderInterface $itemHolder
     */
    protected function calculateAll(ItemHolderInterface $itemHolder)
    {
        $this->calculateDeliveryFeeTotal($itemHolder);
        $this->calculateCharge($itemHolder);
        $this->calculateDiscount($itemHolder);
        $this->calculateSubTotal($itemHolder); // Order の場合のみ
        $this->calculateTax($itemHolder);
        $this->calculateTotal($itemHolder);
    }
}


1		<?php
2
3		/*
4		* This file is part of EC-CUBE
5		*
6		* Copyright(c) LOCKON CO.,LTD. All Rights Reserved.
7		*
8		* http://www.lockon.co.jp/
9		*
10		* For the full copyright and license information, please view the LICENSE
11		* file that was distributed with this source code.
12		*/
13
14		namespace Eccube\Service\PurchaseFlow;
15
16		use Doctrine\Common\Collections\ArrayCollection;
17		use Eccube\Entity\ItemHolderInterface;
18		use Eccube\Entity\ItemInterface;
19		use Eccube\Entity\Order;
20		use Eccube\Entity\OrderItem;
21
22		class PurchaseFlow
23		{
24		/**
25		* @var string
26		*/
27		protected $flowType;
28
29		/**
30		* @var ArrayCollection\|ItemPreprocessor[]
31		*/
32		protected $itemPreprocessors;
33
34		/**
35		* @var ArrayCollection\|ItemHolderPreprocessor[]
36		*/
37		protected $itemHolderPreprocessors;
38
39		/**
40		* @var ArrayCollection\|ItemValidator[]
41		*/
42		protected $itemValidators;
43
44		/**
45		* @var ArrayCollection\|ItemHolderValidator[]
46		*/
47		protected $itemHolderValidators;
48
49		/**
50		* @var ArrayCollection\|ItemHolderPostValidator[]
51		*/
52		protected $itemHolderPostValidators;
53
54		/**
55		* @var ArrayCollection\|DiscountProcessor[]
56		*/
57		protected $discountProcessors;
58
59		/**
60		* @var ArrayCollection\|PurchaseProcessor[]
61		*/
62		protected $purchaseProcessors;
63
64		public function __construct()
65		{
66		$this->purchaseProcessors = new ArrayCollection();
67		$this->itemValidators = new ArrayCollection();
68		$this->itemHolderValidators = new ArrayCollection();
69		$this->itemPreprocessors = new ArrayCollection();
70		$this->itemHolderPreprocessors = new ArrayCollection();
71		$this->itemHolderPostValidators = new ArrayCollection();
72		$this->discountProcessors = new ArrayCollection();
73		}
74
75		public function setFlowType($flowType)
76		{
77		$this->flowType = $flowType;
78		}
79
80		public function setPurchaseProcessors(ArrayCollection $processors)
81		{
82		$this->purchaseProcessors = $processors;
83		}
84
85		public function setItemValidators(ArrayCollection $itemValidators)
86		{
87		$this->itemValidators = $itemValidators;
88		}
89
90		public function setItemHolderValidators(ArrayCollection $itemHolderValidators)
91		{
92		$this->itemHolderValidators = $itemHolderValidators;
93		}
94
95		public function setItemPreprocessors(ArrayCollection $itemPreprocessors)
96		{
97		$this->itemPreprocessors = $itemPreprocessors;
98		}
99
100		public function setItemHolderPreprocessors(ArrayCollection $itemHolderPreprocessors)
101		{
102		$this->itemHolderPreprocessors = $itemHolderPreprocessors;
103		}
104
105		public function setItemHolderPostValidators(ArrayCollection $itemHolderPostValidators)
106		{
107		$this->itemHolderPostValidators = $itemHolderPostValidators;
108		}
109
110		public function setDiscountProcessors(ArrayCollection $discountProcessors)
111		{
112		$this->discountProcessors = $discountProcessors;
113		}
114
115		public function validate(ItemHolderInterface $itemHolder, PurchaseContext $context)
116		{
117		$context->setFlowType($this->flowType);
118
119		$this->calculateAll($itemHolder);
120
121		$flowResult = new PurchaseFlowResult($itemHolder);
122
123		foreach ($itemHolder->getItems() as $item) {
124		foreach ($this->itemValidators as $itemValidator) {
125		$result = $itemValidator->execute($item, $context);
126		$flowResult->addProcessResult($result);
127		}
128		}
129
130		$this->calculateAll($itemHolder);
131
132		foreach ($this->itemHolderValidators as $itemHolderValidator) {
133		$result = $itemHolderValidator->execute($itemHolder, $context);
134		$flowResult->addProcessResult($result);
135		}
136
137		$this->calculateAll($itemHolder);
138
139		foreach ($itemHolder->getItems() as $item) {
140		foreach ($this->itemPreprocessors as $itemPreprocessor) {
141		$itemPreprocessor->process($item, $context);
142		}
143		}
144
145		$this->calculateAll($itemHolder);
146
147		foreach ($this->itemHolderPreprocessors as $holderPreprocessor) {
148		$result = $holderPreprocessor->process($itemHolder, $context);
149		if ($result) {
150		$flowResult->addProcessResult($result);
151		}
152
153		$this->calculateAll($itemHolder);
154		}
155
156		foreach ($this->discountProcessors as $discountProcessor) {
157		$discountProcessor->removeDiscountItem($itemHolder, $context);
158		}
159
160		$this->calculateAll($itemHolder);
161
162		foreach ($this->discountProcessors as $discountProcessor) {
163		$result = $discountProcessor->addDiscountItem($itemHolder, $context);
164		if ($result) {
165		$flowResult->addProcessResult($result);
166		}
167		$this->calculateAll($itemHolder);
168		}
169
170		foreach ($this->itemHolderPostValidators as $itemHolderPostValidator) {
171		$result = $itemHolderPostValidator->execute($itemHolder, $context);
172		$flowResult->addProcessResult($result);
173
174		$this->calculateAll($itemHolder);
175		}
176
177		return $flowResult;
178		}
179
180		/**
181		* 購入フロー仮確定処理.
182		*
183		* @param ItemHolderInterface $target
184		* @param PurchaseContext $context
185		*
186		* @throws PurchaseException
187		*/
188		public function prepare(ItemHolderInterface $target, PurchaseContext $context)
189		{
190		$context->setFlowType($this->flowType);
191
192		foreach ($this->purchaseProcessors as $processor) {
193		$processor->prepare($target, $context);
194		}
195		}
196
197		/**
198		* 購入フロー確定処理.
199		*
200		* @param ItemHolderInterface $target
201		* @param PurchaseContext $context
202		*
203		* @throws PurchaseException
204		*/
205		public function commit(ItemHolderInterface $target, PurchaseContext $context)
206		{
207		$context->setFlowType($this->flowType);
208
209		foreach ($this->purchaseProcessors as $processor) {
210		$processor->commit($target, $context);
211		}
212		}
213
214		/**
215		* 購入フロー仮確定取り消し処理.
216		*
217		* @param ItemHolderInterface $target
218		* @param PurchaseContext $context
219		*/
220		public function rollback(ItemHolderInterface $target, PurchaseContext $context)
221		{
222		$context->setFlowType($this->flowType);
223
224		foreach ($this->purchaseProcessors as $processor) {
225		$processor->rollback($target, $context);
226		}
227		}
228
229		public function addPurchaseProcessor(PurchaseProcessor $processor)
230		{
231		$this->purchaseProcessors[] = $processor;
232		}
233
234		public function addItemHolderPreprocessor(ItemHolderPreprocessor $holderPreprocessor)
235		{
236		$this->itemHolderPreprocessors[] = $holderPreprocessor;
237		}
238
239		public function addItemPreprocessor(ItemPreprocessor $itemPreprocessor)
240		{
241		$this->itemPreprocessors[] = $itemPreprocessor;
242		}
243
244		public function addItemValidator(ItemValidator $itemValidator)
245		{
246		$this->itemValidators[] = $itemValidator;
247		}
248
249		public function addItemHolderValidator(ItemHolderValidator $itemHolderValidator)
250		{
251		$this->itemHolderValidators[] = $itemHolderValidator;
252		}
253
254		public function addItemHolderPostValidator(ItemHolderPostValidator $itemHolderValidator)
255		{
256		$this->itemHolderPostValidators[] = $itemHolderValidator;
257		}
258
259		public function addDiscountProcessor(DiscountProcessor $discountProcessor)
260		{
261		$this->discountProcessors[] = $discountProcessor;
262		}
263
264		/**
265		* @param ItemHolderInterface $itemHolder
266		*/
267	View Code Duplication	protected function calculateTotal(ItemHolderInterface $itemHolder)
		0 ignored issues – show Duplication introduced 2018-08-02 03:20 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
268		{
269		$total = array_reduce($itemHolder->getItems()->toArray(), function ($sum, ItemInterface $item) {
		0 ignored issues – show Bug introduced 2018-08-31 04:27 UTC by Report Bug Copy Issue Report The method `toArray` cannot be called on `$itemHolder->getItems()` (of type `array<integer,object<Ecc...\Entity\ItemInterface>>`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
270		$sum += $item->getPriceIncTax() * $item->getQuantity();
		0 ignored issues – show Bug introduced 2018-08-02 03:20 UTC by Report Bug Copy Issue Report The method `getPriceIncTax()` does not exist on `Eccube\Entity\ItemInterface`. Did you maybe mean `getPrice()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
271
272		return $sum;
273		}, 0);
274		$itemHolder->setTotal($total);
275		// TODO
276		if ($itemHolder instanceof Order) {
277		// Order には PaymentTotal もセットする
278		$itemHolder->setPaymentTotal($total);
279		}
280		}
281
282	View Code Duplication	protected function calculateSubTotal(ItemHolderInterface $itemHolder)
		0 ignored issues – show Duplication introduced 2018-08-02 03:20 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
283		{
284		$total = $itemHolder->getItems()
		0 ignored issues – show Bug introduced 2018-08-02 03:20 UTC by Report Bug Copy Issue Report The method `getProductClasses` cannot be called on `$itemHolder->getItems()` (of type `array<integer,object<Ecc...\Entity\ItemInterface>>`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
285		->getProductClasses()
286		->reduce(function ($sum, ItemInterface $item) {
287		$sum += $item->getPriceIncTax() * $item->getQuantity();
		0 ignored issues – show Bug introduced 2018-08-02 03:20 UTC by Report Bug Copy Issue Report The method `getPriceIncTax()` does not exist on `Eccube\Entity\ItemInterface`. Did you maybe mean `getPrice()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
288
289		return $sum;
290		}, 0);
291		// TODO
292		if ($itemHolder instanceof Order) {
293		// Order の場合は SubTotal をセットする
294		$itemHolder->setSubTotal($total);
295		}
296		}
297
298		/**
299		* @param ItemHolderInterface $itemHolder
300		*/
301	View Code Duplication	protected function calculateDeliveryFeeTotal(ItemHolderInterface $itemHolder)
		0 ignored issues – show Duplication introduced 2018-08-02 03:20 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
302		{
303		$total = $itemHolder->getItems()
		0 ignored issues – show Bug introduced 2018-08-02 03:20 UTC by Report Bug Copy Issue Report The method `getDeliveryFees` cannot be called on `$itemHolder->getItems()` (of type `array<integer,object<Ecc...\Entity\ItemInterface>>`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
304		->getDeliveryFees()
305		->reduce(function ($sum, ItemInterface $item) {
306		$sum += $item->getPriceIncTax() * $item->getQuantity();
		0 ignored issues – show Bug introduced 2018-08-02 03:20 UTC by Report Bug Copy Issue Report The method `getPriceIncTax()` does not exist on `Eccube\Entity\ItemInterface`. Did you maybe mean `getPrice()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
307
308		return $sum;
309		}, 0);
310		$itemHolder->setDeliveryFeeTotal($total);
311		}
312
313		/**
314		* @param ItemHolderInterface $itemHolder
315		*/
316	View Code Duplication	protected function calculateDiscount(ItemHolderInterface $itemHolder)
		0 ignored issues – show Duplication introduced 2018-08-31 04:27 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
317		{
318		$total = $itemHolder->getItems()
		0 ignored issues – show Bug introduced 2018-08-02 03:20 UTC by Report Bug Copy Issue Report The method `getDiscounts` cannot be called on `$itemHolder->getItems()` (of type `array<integer,object<Ecc...\Entity\ItemInterface>>`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
319		->getDiscounts()
320		->reduce(function ($sum, ItemInterface $item) {
321		$sum += $item->getPriceIncTax() * $item->getQuantity();
		0 ignored issues – show Bug introduced 2018-08-02 03:20 UTC by Report Bug Copy Issue Report The method `getPriceIncTax()` does not exist on `Eccube\Entity\ItemInterface`. Did you maybe mean `getPrice()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
322
323		return $sum;
324		}, 0);
325		// TODO 後方互換のため discount には正の整数を代入する
326		$itemHolder->setDiscount($total * -1);
327		}
328
329		/**
330		* @param ItemHolderInterface $itemHolder
331		*/
332	View Code Duplication	protected function calculateCharge(ItemHolderInterface $itemHolder)
		0 ignored issues – show Duplication introduced 2018-08-02 03:20 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
333		{
334		$total = $itemHolder->getItems()
		0 ignored issues – show Bug introduced 2018-08-02 03:20 UTC by Report Bug Copy Issue Report The method `getCharges` cannot be called on `$itemHolder->getItems()` (of type `array<integer,object<Ecc...\Entity\ItemInterface>>`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
335		->getCharges()
336		->reduce(function ($sum, ItemInterface $item) {
337		$sum += $item->getPriceIncTax() * $item->getQuantity();
		0 ignored issues – show Bug introduced 2018-08-02 03:20 UTC by Report Bug Copy Issue Report The method `getPriceIncTax()` does not exist on `Eccube\Entity\ItemInterface`. Did you maybe mean `getPrice()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
338
339		return $sum;
340		}, 0);
341		$itemHolder->setCharge($total);
342		}
343
344		/**
345		* @param ItemHolderInterface $itemHolder
346		*/
347		protected function calculateTax(ItemHolderInterface $itemHolder)
348		{
349		$total = $itemHolder->getItems()
		0 ignored issues – show Bug introduced 2018-08-02 03:20 UTC by Report Bug Copy Issue Report The method `reduce` cannot be called on `$itemHolder->getItems()` (of type `array<integer,object<Ecc...\Entity\ItemInterface>>`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
350		->reduce(function ($sum, ItemInterface $item) {
351		if ($item instanceof OrderItem) {
352		$sum += $item->getTax() * $item->getQuantity();
353		} else {
354		$sum += ($item->getPriceIncTax() - $item->getPrice()) * $item->getQuantity();
		0 ignored issues – show Bug introduced 2018-08-02 03:20 UTC by Report Bug Copy Issue Report The method `getPriceIncTax()` does not exist on `Eccube\Entity\ItemInterface`. Did you maybe mean `getPrice()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
355		}
356
357		return $sum;
358		}, 0);
359		$itemHolder->setTax($total);
360		}
361
362		/**
363		* @param ItemHolderInterface $itemHolder
364		*/
365		protected function calculateAll(ItemHolderInterface $itemHolder)
366		{
367		$this->calculateDeliveryFeeTotal($itemHolder);
368		$this->calculateCharge($itemHolder);
369		$this->calculateDiscount($itemHolder);
370		$this->calculateSubTotal($itemHolder); // Order の場合のみ
371		$this->calculateTax($itemHolder);
372		$this->calculateTotal($itemHolder);
373		}
374		}
375

kiy0taka / ec-cube

Push — sf/last-boss ( 53d963...58156b )

PurchaseFlow::commit() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like