Eccube\Service\PurchaseFlow\Processor\EmptyItemsValidator

Complexity

Total Complexity

14

Size/Duplication

Total Lines	68
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
C	validate()	0	44	13

<?php

/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Eccube\Service\PurchaseFlow\Processor;

use Doctrine\ORM\EntityManagerInterface;
use Eccube\Entity\ItemHolderInterface;
use Eccube\Entity\Order;
use Eccube\Service\PurchaseFlow\InvalidItemException;
use Eccube\Service\PurchaseFlow\ItemHolderValidator;
use Eccube\Service\PurchaseFlow\PurchaseContext;

class EmptyItemsValidator extends ItemHolderValidator
{
    /**
     * @var EntityManagerInterface
     */
    protected $entityManager;

    /**
     * EmptyItemsProcessor constructor.
     *
     * @param EntityManagerInterface $entityManager
     */
    public function __construct(EntityManagerInterface $entityManager)
    {
        $this->entityManager = $entityManager;
    }

    /**
     * @param ItemHolderInterface $itemHolder
     * @param PurchaseContext $context
     *
     * @throws InvalidItemException
     */
    protected function validate(ItemHolderInterface $itemHolder, PurchaseContext $context)
    {
        foreach ($itemHolder->getItems() as $item) {
            if ($item->isProduct() && $item->getQuantity() == 0) {
                if ($itemHolder instanceof Order) {
                    foreach ($itemHolder->getShippings() as $Shipping) {
                        $Shipping->removeOrderItem($item);
                    }
                    $itemHolder->removeOrderItem($item);

$item of type object<Eccube\Entity\ItemInterface> is not a sub-type of object<Eccube\Entity\OrderItem>. It seems like you assume a concrete implementation of the interface Eccube\Entity\ItemInterface to be always present.

                } else {
                    $itemHolder->removeItem($item);

It seems like you code against a concrete implementation and not the interface Eccube\Entity\ItemHolderInterface as the method removeItem() does only exist in the following implementations of said interface: Eccube\Entity\Cart.

                }
                $this->entityManager->remove($item);
            }
        }

        if (!$itemHolder instanceof Order) {
            return;
        }

        // 受注の場合は, Shippingに紐づく商品明細がない場合はShippingも削除する.
        foreach ($itemHolder->getShippings() as $Shipping) {
            $hasProductItem = false;
            foreach ($Shipping->getOrderItems() as $item) {
                if ($item->isProduct()) {
                    $hasProductItem = true;
                    break;
                }
            }

            if (!$hasProductItem) {
                foreach ($Shipping->getOrderItems() as $item) {
                    $this->entityManager->remove($item);
                }
                $itemHolder->removeShipping($Shipping);
                $this->entityManager->remove($Shipping);
            }
        }

        // Shippingがなくなれば購入エラー.
        if (count($itemHolder->getShippings()) < 1) {
            $this->throwInvalidItemException('front.shopping.empty_items_error');
        }
    }
}