kiy0taka / ec-cube

tests/Eccube/Tests/Web/Admin/Content/NewsControllerTest.php

Doc Comments +3 added lines

@@ -73,6 +73,9 @@
         $this->assertTrue($this->client->getResponse()->isRedirect($redirectUrl));
     }
 
+    /**
+     * @param \Eccube\Entity\Member $TestCreator
+     */
     private function createNews($TestCreator, $sortNo = 1)
     {
         $TestNews = new \Eccube\Entity\News();

tests/Eccube/Tests/Web/Admin/Order/CsvImportControllerTest.php

Doc Comments +3 added lines

@@ -197,6 +197,9 @@
         self::assertEquals($this->parseDate('2018-03-22'), $Shipping3->getShippingDate());
     }
 
+    /**
+     * @param string $value
+     */
     private function parseDate($value)
     {
         $result = \DateTime::createFromFormat('Y-m-d', $value);

tests/Eccube/Tests/Web/Admin/Product/ClassCategoryContorllerTest.php

Doc Comments +7 added lines

@@ -243,6 +243,9 @@ 
         $this->assertContains($this->expected, $this->actual);
     }
 
+    /**
+     * @param \Eccube\Entity\Member $TestCreator
+     */
     private function newTestClassName($TestCreator)
     {
         $TestClassName = new \Eccube\Entity\ClassName();
@@ -253,6 +256,10 @@ 
         return $TestClassName;
     }
 
+    /**
+     * @param \Eccube\Entity\Member $TestCreator
+     * @param \Eccube\Entity\ClassName $TestClassName
+     */
     private function newTestClassCategory($TestCreator, $TestClassName)
     {
         $TestClassCategory = new \Eccube\Entity\ClassCategory();

tests/Eccube/Tests/Web/Admin/Setting/System/AuthorityControllerTest.php

Doc Comments +2 added lines, -2 removed lines

@@ -198,9 +198,9 @@
     }
 
     /**
-     * @param null $AuthorityRole
+     * @param \Eccube\Entity\AuthorityRole $AuthorityRole
      *
-     * @return array
+     * @return string
      */
     protected function createFormData($AuthorityRole = null)
     {

tests/Eccube/Tests/Web/Admin/Setting/System/MasterdataControllerTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -423,7 +423,7 @@
     /**
      * @param string $entity
      *
-     * @return array
+     * @return string
      */
     protected function createFormDataEdit($entity = 'Eccube-Entity-Master-Sex')
     {

tests/Eccube/Tests/Web/CartValidationTest.php

Doc Comments +5 added lines, -5 removed lines

@@ -2575,7 +2575,7 @@ 
      * @param ProductClass $ProductClass
      * @param int $num
      *
-     * @return mixed
+     * @return \Symfony\Component\DomCrawler\Crawler|null
      */
     protected function scenarioCartIn(Customer $Customer, ProductClass $ProductClass, $num = 1)
     {
@@ -2596,7 +2596,7 @@ 
     /**
      * @param $client
      *
-     * @return mixed
+     * @return \Symfony\Component\DomCrawler\Crawler|null
      */
     protected function scenarioConfirm(Customer $Customer, ProductClass $ProductClass)
     {
@@ -2612,7 +2612,7 @@ 
      * @param string $confirmUrl
      * @param array $arrShopping
      *
-     * @return mixed
+     * @return \Symfony\Component\DomCrawler\Crawler|null
      */
     protected function scenarioComplete(Customer $Customer, $confirmUrl = '', $arrShopping = [])
     {
@@ -2648,7 +2648,7 @@ 
      * @param $client
      * @param $productClassId
      *
-     * @return mixed
+     * @return \Symfony\Component\DomCrawler\Crawler|null
      */
     protected function scenarioCartUp(Customer $Customer, ProductClass $ProductClass)
     {
@@ -2733,7 +2733,7 @@ 
     }
 
     /**
-     * @param null $productName
+     * @param string $productName
      * @param int  $productClassNum
      * @param int  $stock
      *

src/Eccube/Doctrine/Query/WhereClause.php

Doc Comments +30 added lines, -28 removed lines

@@ -59,8 +59,8 @@ 
      *      WhereClause::eq('name', ':Name', 'hoge')
      *      WhereClause::eq('name', ':Name', ['Name' => 'hoge'])
      *
-     * @param $x
-     * @param $y
+     * @param string $x
+     * @param string $y
      * @param $param
      *
      * @return WhereClause
@@ -77,9 +77,9 @@ 
      *      WhereClause::neq('name', ':Name', 'hoge')
      *      WhereClause::neq('name', ':Name', ['Name' => 'hoge'])
      *
-     * @param $x
-     * @param $y
-     * @param $param
+     * @param string $x
+     * @param string $y
+     * @param string $param
      *
      * @return WhereClause
      */
@@ -94,7 +94,7 @@ 
      * Example:
      *      WhereClause::isNull('name')
      *
-     * @param $x
+     * @param string $x
      *
      * @return WhereClause
      */
@@ -109,7 +109,7 @@ 
      * Example:
      *      WhereClause::isNotNull('name')
      *
-     * @param $x
+     * @param string $x
      *
      * @return WhereClause
      */
@@ -125,9 +125,9 @@ 
      *      WhereClause::like('name', ':Name', '%hoge')
      *      WhereClause::like('name', ':Name', ['Name' => '%hoge'])
      *
-     * @param $x
-     * @param $y
-     * @param $param
+     * @param string $x
+     * @param string $y
+     * @param string $param
      *
      * @return WhereClause
      */
@@ -143,9 +143,9 @@ 
      *      WhereClause::notLike('name', ':Name', '%hoge')
      *      WhereClause::notLike('name', ':Name', ['Name' => '%hoge'])
      *
-     * @param $x
-     * @param $y
-     * @param $param
+     * @param string $x
+     * @param string $y
+     * @param string $param
      *
      * @return WhereClause
      */
@@ -161,8 +161,8 @@ 
      *      WhereClause::in('name', ':Names', ['foo', 'bar'])
      *      WhereClause::in('name', ':Names', ['Names' => ['foo', 'bar']])
      *
-     * @param $x
-     * @param $y
+     * @param string $x
+     * @param string $y
      * @param $param
      *
      * @return WhereClause
@@ -184,8 +184,8 @@ 
      *      WhereClause::notIn('name', ':Names', ['foo', 'bar'])
      *      WhereClause::notIn('name', ':Names', ['Names' => ['foo', 'bar']])
      *
-     * @param $x
-     * @param $y
+     * @param string $x
+     * @param string $y
      * @param $param
      *
      * @return WhereClause
@@ -202,9 +202,9 @@ 
      *      WhereClause::between('price', ':PriceMin', ':PriceMax', [1000, 2000])
      *      WhereClause::between('price', ':PriceMin', ':PriceMax', ['PriceMin' => 1000, 'PriceMax' => 2000])
      *
-     * @param $var
-     * @param $x
-     * @param $y
+     * @param string $var
+     * @param string $x
+     * @param string $y
      * @param $params
      *
      * @return WhereClause
@@ -221,8 +221,8 @@ 
      *      WhereClause::gt('price', ':Price', 1000)
      *      WhereClause::gt('price', ':Price', ['Price' => 1000])
      *
-     * @param $x
-     * @param $y
+     * @param string $x
+     * @param string $y
      * @param $param
      *
      * @return WhereClause
@@ -239,8 +239,8 @@ 
      *      WhereClause::gte('price', ':Price', 1000)
      *      WhereClause::gte('price', ':Price', ['Price' => 1000])
      *
-     * @param $x
-     * @param $y
+     * @param string $x
+     * @param string $y
      * @param $param
      *
      * @return WhereClause
@@ -257,8 +257,8 @@ 
      *      WhereClause::lt('price', ':Price', 1000)
      *      WhereClause::lt('price', ':Price', ['Price' => 1000])
      *
-     * @param $x
-     * @param $y
+     * @param string $x
+     * @param string $y
      * @param $param
      *
      * @return WhereClause
@@ -275,8 +275,8 @@ 
      *      WhereClause::lte('price', ':Price', 1000)
      *      WhereClause::lte('price', ':Price', ['Price' => 1000])
      *
-     * @param $x
-     * @param $y
+     * @param string $x
+     * @param string $y
      * @param $param
      *
      * @return WhereClause
@@ -294,6 +294,7 @@ 
      *          WhereClause::eq('price', ':price', 1000),
      *      )
      * @param WhereClause ...$list
+     * @param WhereClause[] $list
      * @return WhereClause
      */
     public static function and(WhereClause ...$list)
@@ -317,6 +318,7 @@ 
      *          WhereClause::eq('status', ':status2', '2'),
      *      )
      * @param WhereClause ...$list
+     * @param WhereClause[] $list
      * @return WhereClause
      */
     public static function or(WhereClause ...$list)

tests/Eccube/Tests/EccubeTestCase.php

Doc Comments +5 added lines, -2 removed lines

@@ -228,6 +228,9 @@ 
     /**
      * LoginHistory オブジェクトを生成して返す
      *
+     * @param string $user_name
+     * @param string $client_ip
+     * @param \Eccube\Entity\Member $Member
      * @return \Eccube\Entity\LoginHistory
      */
     public function createLoginHistory($user_name, $client_ip = null, $status = 0, $Member = null)
@@ -241,7 +244,7 @@ 
      * このメソッドは、参照制約の関係で、 Doctrine ORM ではデータ削除できない場合に使用する.
      * 通常は、 EntityManager::remove() を使用して削除すること.
      *
-     * @param array $tables 削除対象のテーブル名の配列
+     * @param string[] $tables 削除対象のテーブル名の配列
      */
     public function deleteAllRows(array $tables)
     {
@@ -426,7 +429,7 @@ 
      *
      * @param string $csrfTokenId The token ID (e.g. `authenticate`, `<FormTypeBlockPrefix>`)
      *
-     * @return CsrfToken The CSRF token
+     * @return Customer The CSRF token
      *
      * @see \Symfony\Component\Security\Csrf\CsrfTokenManagerInterface
      * @see https://stackoverflow.com/a/38661340/4956633