Conditions | 41 |
Paths | > 20000 |
Total Lines | 151 |
Lines | 54 |
Ratio | 35.76 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
97 | public function getQueryBuilderBySearchData($searchData) |
||
98 | { |
||
99 | $qb = $this->createQueryBuilder('c') |
||
100 | ->select('c'); |
||
101 | |||
102 | if (isset($searchData['multi']) && StringUtil::isNotBlank($searchData['multi'])) { |
||
103 | //スペース除去 |
||
104 | $clean_key_multi = preg_replace('/\s+|[ ]+/u', '', $searchData['multi']); |
||
105 | $id = preg_match('/^\d{0,10}$/', $clean_key_multi) ? $clean_key_multi : null; |
||
106 | $qb |
||
107 | ->andWhere('c.id = :customer_id OR CONCAT(c.name01, c.name02) LIKE :name OR CONCAT(c.kana01, c.kana02) LIKE :kana OR c.email LIKE :email') |
||
108 | ->setParameter('customer_id', $id) |
||
109 | ->setParameter('name', '%'.$clean_key_multi.'%') |
||
110 | ->setParameter('kana', '%'.$clean_key_multi.'%') |
||
111 | ->setParameter('email', '%'.$clean_key_multi.'%'); |
||
112 | } |
||
113 | |||
114 | // Pref |
||
115 | if (!empty($searchData['pref']) && $searchData['pref']) { |
||
116 | $qb |
||
117 | ->andWhere('c.Pref = :pref') |
||
118 | ->setParameter('pref', $searchData['pref']->getId()); |
||
119 | } |
||
120 | |||
121 | // sex |
||
122 | if (!empty($searchData['sex']) && count($searchData['sex']) > 0) { |
||
123 | $sexs = []; |
||
124 | foreach ($searchData['sex'] as $sex) { |
||
125 | $sexs[] = $sex->getId(); |
||
126 | } |
||
127 | |||
128 | $qb |
||
129 | ->andWhere($qb->expr()->in('c.Sex', ':sexs')) |
||
130 | ->setParameter('sexs', $sexs); |
||
131 | } |
||
132 | |||
133 | if (!empty($searchData['birth_month']) && $searchData['birth_month']) { |
||
134 | $qb |
||
135 | ->andWhere('EXTRACT(MONTH FROM c.birth) = :birth_month') |
||
136 | ->setParameter('birth_month', $searchData['birth_month']); |
||
137 | } |
||
138 | |||
139 | // birth |
||
140 | if (!empty($searchData['birth_start']) && $searchData['birth_start']) { |
||
141 | $qb |
||
142 | ->andWhere('c.birth >= :birth_start') |
||
143 | ->setParameter('birth_start', $searchData['birth_start']); |
||
144 | } |
||
145 | View Code Duplication | if (!empty($searchData['birth_end']) && $searchData['birth_end']) { |
|
146 | $date = clone $searchData['birth_end']; |
||
147 | $date->modify('+1 days'); |
||
148 | $qb |
||
149 | ->andWhere('c.birth < :birth_end') |
||
150 | ->setParameter('birth_end', $date); |
||
151 | } |
||
152 | |||
153 | // tel |
||
154 | View Code Duplication | if (isset($searchData['phone_number']) && StringUtil::isNotBlank($searchData['phone_number'])) { |
|
155 | $tel = preg_replace('/[^0-9]/ ', '', $searchData['phone_number']); |
||
156 | $qb |
||
157 | ->andWhere('c.phone_number LIKE :phone_number') |
||
158 | ->setParameter('phone_number', '%'.$tel.'%'); |
||
159 | } |
||
160 | |||
161 | // buy_total |
||
162 | View Code Duplication | if (isset($searchData['buy_total_start']) && StringUtil::isNotBlank($searchData['buy_total_start'])) { |
|
163 | $qb |
||
164 | ->andWhere('c.buy_total >= :buy_total_start') |
||
165 | ->setParameter('buy_total_start', $searchData['buy_total_start']); |
||
166 | } |
||
167 | View Code Duplication | if (isset($searchData['buy_total_end']) && StringUtil::isNotBlank($searchData['buy_total_end'])) { |
|
168 | $qb |
||
169 | ->andWhere('c.buy_total <= :buy_total_end') |
||
170 | ->setParameter('buy_total_end', $searchData['buy_total_end']); |
||
171 | } |
||
172 | |||
173 | // buy_times |
||
174 | View Code Duplication | if (isset($searchData['buy_times_start']) && StringUtil::isNotBlank($searchData['buy_times_start'])) { |
|
175 | $qb |
||
176 | ->andWhere('c.buy_times >= :buy_times_start') |
||
177 | ->setParameter('buy_times_start', $searchData['buy_times_start']); |
||
178 | } |
||
179 | View Code Duplication | if (isset($searchData['buy_times_end']) && StringUtil::isNotBlank($searchData['buy_times_end'])) { |
|
180 | $qb |
||
181 | ->andWhere('c.buy_times <= :buy_times_end') |
||
182 | ->setParameter('buy_times_end', $searchData['buy_times_end']); |
||
183 | } |
||
184 | |||
185 | // create_date |
||
186 | if (!empty($searchData['create_date_start']) && $searchData['create_date_start']) { |
||
187 | $qb |
||
188 | ->andWhere('c.create_date >= :create_date_start') |
||
189 | ->setParameter('create_date_start', $searchData['create_date_start']); |
||
190 | } |
||
191 | View Code Duplication | if (!empty($searchData['create_date_end']) && $searchData['create_date_end']) { |
|
192 | $date = clone $searchData['create_date_end']; |
||
193 | $date->modify('+1 days'); |
||
194 | $qb |
||
195 | ->andWhere('c.create_date < :create_date_end') |
||
196 | ->setParameter('create_date_end', $date); |
||
197 | } |
||
198 | |||
199 | // update_date |
||
200 | if (!empty($searchData['update_date_start']) && $searchData['update_date_start']) { |
||
201 | $qb |
||
202 | ->andWhere('c.update_date >= :update_date_start') |
||
203 | ->setParameter('update_date_start', $searchData['update_date_start']); |
||
204 | } |
||
205 | View Code Duplication | if (!empty($searchData['update_date_end']) && $searchData['update_date_end']) { |
|
206 | $date = clone $searchData['update_date_end']; |
||
207 | $date->modify('+1 days'); |
||
208 | $qb |
||
209 | ->andWhere('c.update_date < :update_date_end') |
||
210 | ->setParameter('update_date_end', $date); |
||
211 | } |
||
212 | |||
213 | // last_buy |
||
214 | if (!empty($searchData['last_buy_start']) && $searchData['last_buy_start']) { |
||
215 | $qb |
||
216 | ->andWhere('c.last_buy_date >= :last_buy_start') |
||
217 | ->setParameter('last_buy_start', $searchData['last_buy_start']); |
||
218 | } |
||
219 | View Code Duplication | if (!empty($searchData['last_buy_end']) && $searchData['last_buy_end']) { |
|
220 | $date = clone $searchData['last_buy_end']; |
||
221 | $date->modify('+1 days'); |
||
222 | $qb |
||
223 | ->andWhere('c.last_buy_date < :last_buy_end') |
||
224 | ->setParameter('last_buy_end', $date); |
||
225 | } |
||
226 | |||
227 | // status |
||
228 | if (!empty($searchData['customer_status']) && count($searchData['customer_status']) > 0) { |
||
229 | $qb |
||
230 | ->andWhere($qb->expr()->in('c.Status', ':statuses')) |
||
231 | ->setParameter('statuses', $searchData['customer_status']); |
||
232 | } |
||
233 | |||
234 | // buy_product_name |
||
235 | if (isset($searchData['buy_product_name']) && StringUtil::isNotBlank($searchData['buy_product_name'])) { |
||
236 | $qb |
||
237 | ->leftJoin('c.Orders', 'o') |
||
238 | ->leftJoin('o.OrderItems', 'oi') |
||
239 | ->andWhere('oi.product_name LIKE :buy_product_name') |
||
240 | ->setParameter('buy_product_name', '%'.$searchData['buy_product_name'].'%'); |
||
241 | } |
||
242 | |||
243 | // Order By |
||
244 | $qb->addOrderBy('c.update_date', 'DESC'); |
||
245 | |||
246 | return $this->queries->customize(QueryKey::CUSTOMER_SEARCH, $qb, $searchData); |
||
247 | } |
||
248 | |||
364 |
If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check:
If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue.