kiy0taka / ec-cube

src/Eccube/Session/Storage/Handler/SameSiteNoneCompatSessionHandler.php

Indentation +8 added lines, -8 removed lines

@@ -126,14 +126,14 @@
                     setcookie($this->sessionName, '', 0, ini_get('session.cookie_path'), ini_get('session.cookie_domain'), filter_var(ini_get('session.cookie_secure'), FILTER_VALIDATE_BOOLEAN), filter_var(ini_get('session.cookie_httponly'), FILTER_VALIDATE_BOOLEAN));
                 } else {
                     setcookie($this->sessionName, '',
-                              [
-                                  'expires' => 0,
-                                  'path' => $this->getCookiePath(),
-                                  'domain' => ini_get('session.cookie_domain'),
-                                  'secure' => filter_var(ini_get('session.cookie_secure'), FILTER_VALIDATE_BOOLEAN),
-                                  'httponly' => filter_var(ini_get('session.cookie_httponly'), FILTER_VALIDATE_BOOLEAN),
-                                  'samesite' => $this->getCookieSameSite(),
-                              ]
+                                [
+                                    'expires' => 0,
+                                    'path' => $this->getCookiePath(),
+                                    'domain' => ini_get('session.cookie_domain'),
+                                    'secure' => filter_var(ini_get('session.cookie_secure'), FILTER_VALIDATE_BOOLEAN),
+                                    'httponly' => filter_var(ini_get('session.cookie_httponly'), FILTER_VALIDATE_BOOLEAN),
+                                    'samesite' => $this->getCookieSameSite(),
+                                ]
                     );
                 }
             }

src/Eccube/Form/Type/Admin/ProductType.php

Doc Comments +1 added lines, -1 removed lines

@@ -194,7 +194,7 @@
     /**
      * 指定された複数ディレクトリのうち、いずれかのディレクトリ以下にファイルが存在するかを確認。
      *
-     * @param $form FormInterface
+     * @param FormInterface $form FormInterface
      * @param $dirs array
      */
     private function validateFilePath($form, $dirs)

src/Eccube/Service/Composer/ComposerApiService.php

Doc Comments +3 added lines

@@ -386,6 +386,9 @@
         $this->init($BaseInfo);
     }
 
+    /**
+     * @param string $packageNames
+     */
     private function dropTableToExtra($packageNames)
     {
         foreach (explode(' ', trim($packageNames)) as $packageName) {

src/Eccube/Service/SchemaService.php

Doc Comments -1 removed lines

@@ -54,7 +54,6 @@
      * @param callable $callback Metadata を生成した後に実行されるコールバック関数
      * @param array $generatedFiles Proxy ファイルパスの配列
      * @param string $proxiesDirectory Proxy ファイルを格納したディレクトリ
-     * @param bool $saveMode UpdateSchema を即時実行する場合 true
      * @param string $outputDir Metadata の出力先ディレクトリ
      */
     public function executeCallback(callable $callback, $generatedFiles, $proxiesDirectory, $outputDir = null)

src/Eccube/Repository/ProductRepository.php

Spacing +1 added lines, -1 removed lines

@@ -226,7 +226,7 @@
 
         // id
         if (isset($searchData['id']) && StringUtil::isNotBlank($searchData['id'])) {
-            $id = preg_match('/^\d{0,10}$/', $searchData['id'])  ? $searchData['id'] : null;
+            $id = preg_match('/^\d{0,10}$/', $searchData['id']) ? $searchData['id'] : null;
             if ($id && $id > '2147483647' && $this->isPostgreSQL()) {
                 $id = null;
             }

src/Eccube/Controller/Admin/AdminController.php

Doc Comments +6 added lines, -7 removed lines

@@ -412,7 +412,6 @@ 
     }
 
     /**
-     * @param \Doctrine\ORM\EntityManagerInterface $em
      * @param array $excludes
      *
      * @return null|Request
@@ -447,7 +446,7 @@ 
     /**
      * @param \DateTime $dateTime
      *
-     * @return array|mixed
+     * @return null|Request
      *
      * @throws \Doctrine\ORM\NonUniqueResultException
      */
@@ -484,7 +483,7 @@ 
     /**
      * @param \DateTime $dateTime
      *
-     * @return array|mixed
+     * @return null|Request
      *
      * @throws \Doctrine\ORM\NonUniqueResultException
      */
@@ -523,7 +522,7 @@ 
     /**
      * 在庫切れ商品数を取得
      *
-     * @return mixed
+     * @return null|Request
      *
      * @throws \Doctrine\ORM\NonUniqueResultException
      */
@@ -543,7 +542,7 @@ 
     /**
      * 商品数を取得
      *
-     * @return mixed
+     * @return null|Request
      *
      * @throws \Doctrine\ORM\NonUniqueResultException
      */
@@ -560,7 +559,7 @@ 
     /**
      * 本会員数を取得
      *
-     * @return mixed
+     * @return null|Request
      *
      * @throws \Doctrine\ORM\NonUniqueResultException
      */
@@ -579,7 +578,7 @@ 
      *
      * @param Carbon $fromDate
      * @param Carbon $toDate
-     * @param $format
+     * @param string $format
      *
      * @return array
      */

src/Eccube/Controller/Admin/Setting/System/LogController.php

Spacing +6 added lines, -6 removed lines

@@ -71,13 +71,13 @@
         if ($form->getClickedButton() && $form->getClickedButton()->getName() === 'download') {
             $bufferSize = 1024 * 50;
             $response = new StreamedResponse();
-            $response->headers->set('Content-Length',filesize($logFile));
-            $response->headers->set('Content-Disposition','attachment; filename=' . basename($logFile));
-            $response->headers->set('Content-Type','application/octet-stream');
-            $response->setCallback(function() use($logFile,$bufferSize) {
-                if ($fh = fopen($logFile,'r')) {
+            $response->headers->set('Content-Length', filesize($logFile));
+            $response->headers->set('Content-Disposition', 'attachment; filename='.basename($logFile));
+            $response->headers->set('Content-Type', 'application/octet-stream');
+            $response->setCallback(function () use($logFile, $bufferSize) {
+                if ($fh = fopen($logFile, 'r')) {
                     while (!feof($fh)) {
-                        echo fread($fh,$bufferSize);
+                        echo fread($fh, $bufferSize);
                     }
                 }
             });

codeception/acceptance/EA11CustomizeCest.php

Doc Comments +3 added lines

@@ -62,6 +62,9 @@
         $I->see('ログインできませんでした。', 'p.ec-errorMessage');
     }
 
+    /**
+     * @param string $email
+     */
     private function newCustomer($email)
     {
         $Customer = new Customer();