kiy0taka /
ec-cube
| Conditions | 15 |
| Paths | 36 |
| Total Lines | 75 |
| Lines | 11 |
| Ratio | 14.67 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 133 | public function getQueryBuilderBySearchData($searchData) |
||
| 134 | { |
||
| 135 | $qb = $this->createQueryBuilder('p') |
||
| 136 | ->andWhere('p.Status = 1'); |
||
| 137 | |||
| 138 | // category |
||
| 139 | $categoryJoin = false; |
||
| 140 | View Code Duplication | if (!empty($searchData['category_id']) && $searchData['category_id']) { |
|
|
|
|||
| 141 | $Categories = $searchData['category_id']->getSelfAndDescendants(); |
||
| 142 | if ($Categories) { |
||
| 143 | $qb |
||
| 144 | ->innerJoin('p.ProductCategories', 'pct') |
||
| 145 | ->innerJoin('pct.Category', 'c') |
||
| 146 | ->andWhere($qb->expr()->in('pct.Category', ':Categories')) |
||
| 147 | ->setParameter('Categories', $Categories); |
||
| 148 | $categoryJoin = true; |
||
| 149 | } |
||
| 150 | } |
||
| 151 | |||
| 152 | // name |
||
| 153 | if (isset($searchData['name']) && StringUtil::isNotBlank($searchData['name'])) { |
||
| 154 | $keywords = preg_split('/[\s ]+/u', str_replace(['%', '_'], ['\\%', '\\_'], $searchData['name']), -1, PREG_SPLIT_NO_EMPTY); |
||
| 155 | |||
| 156 | foreach ($keywords as $index => $keyword) { |
||
| 157 | $key = sprintf('keyword%s', $index); |
||
| 158 | $qb |
||
| 159 | ->andWhere(sprintf('NORMALIZE(p.name) LIKE NORMALIZE(:%s) OR |
||
| 160 | NORMALIZE(p.search_word) LIKE NORMALIZE(:%s) OR |
||
| 161 | EXISTS (SELECT wpc%d FROM \Eccube\Entity\ProductClass wpc%d WHERE p = wpc%d.Product AND NORMALIZE(wpc%d.code) LIKE NORMALIZE(:%s))', |
||
| 162 | $key, $key, $index, $index, $index, $index, $key)) |
||
| 163 | ->setParameter($key, '%'.$keyword.'%'); |
||
| 164 | } |
||
| 165 | } |
||
| 166 | |||
| 167 | // Order By |
||
| 168 | // 価格低い順 |
||
| 169 | $config = $this->eccubeConfig; |
||
| 170 | if (!empty($searchData['orderby']) && $searchData['orderby']->getId() == $config['eccube_product_order_price_lower']) { |
||
| 171 | //@see http://doctrine-orm.readthedocs.org/en/latest/reference/dql-doctrine-query-language.html |
||
| 172 | $qb->addSelect('MIN(pc.price02) as HIDDEN price02_min'); |
||
| 173 | $qb->innerJoin('p.ProductClasses', 'pc'); |
||
| 174 | $qb->andWhere('pc.visible = true'); |
||
| 175 | $qb->groupBy('p.id'); |
||
| 176 | $qb->orderBy('price02_min', 'ASC'); |
||
| 177 | $qb->addOrderBy('p.id', 'DESC'); |
||
| 178 | // 価格高い順 |
||
| 179 | } elseif (!empty($searchData['orderby']) && $searchData['orderby']->getId() == $config['eccube_product_order_price_higher']) { |
||
| 180 | $qb->addSelect('MAX(pc.price02) as HIDDEN price02_max'); |
||
| 181 | $qb->innerJoin('p.ProductClasses', 'pc'); |
||
| 182 | $qb->andWhere('pc.visible = true'); |
||
| 183 | $qb->groupBy('p.id'); |
||
| 184 | $qb->orderBy('price02_max', 'DESC'); |
||
| 185 | $qb->addOrderBy('p.id', 'DESC'); |
||
| 186 | // 新着順 |
||
| 187 | } elseif (!empty($searchData['orderby']) && $searchData['orderby']->getId() == $config['eccube_product_order_newer']) { |
||
| 188 | // 在庫切れ商品非表示の設定が有効時対応 |
||
| 189 | // @see https://github.com/EC-CUBE/ec-cube/issues/1998 |
||
| 190 | if ($this->getEntityManager()->getFilters()->isEnabled('option_nostock_hidden') == true) { |
||
| 191 | $qb->innerJoin('p.ProductClasses', 'pc'); |
||
| 192 | $qb->andWhere('pc.visible = true'); |
||
| 193 | } |
||
| 194 | $qb->orderBy('p.create_date', 'DESC'); |
||
| 195 | $qb->addOrderBy('p.id', 'DESC'); |
||
| 196 | } else { |
||
| 197 | if ($categoryJoin === false) { |
||
| 198 | $qb |
||
| 199 | ->leftJoin('p.ProductCategories', 'pct') |
||
| 200 | ->leftJoin('pct.Category', 'c'); |
||
| 201 | } |
||
| 202 | $qb |
||
| 203 | ->addOrderBy('p.id', 'DESC'); |
||
| 204 | } |
||
| 205 | |||
| 206 | return $this->queries->customize(QueryKey::PRODUCT_SEARCH, $qb, $searchData); |
||
| 207 | } |
||
| 208 | |||
| 341 |
Loading history...
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.