kiy0taka /
ec-cube
| Conditions | 15 |
| Paths | 164 |
| Total Lines | 84 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 97 | protected function loadCsv(CsvImportService $csv, &$errors) |
||
| 98 | { |
||
| 99 | $columnConfig = $this->getColumnConfig(); |
||
| 100 | |||
| 101 | if ($csv === false) { |
||
| 102 | $errors[] = trans('admin.common.csv_invalid_format'); |
||
| 103 | } |
||
| 104 | |||
| 105 | // 必須カラムの確認 |
||
| 106 | $requiredColumns = array_map(function ($value) { |
||
| 107 | return $value['name']; |
||
| 108 | }, array_filter($columnConfig, function ($value) { |
||
| 109 | return $value['required']; |
||
| 110 | })); |
||
| 111 | $csvColumns = $csv->getColumnHeaders(); |
||
| 112 | if (count(array_diff($requiredColumns, $csvColumns)) > 0) { |
||
| 113 | $errors[] = trans('admin.common.csv_invalid_format'); |
||
| 114 | |||
| 115 | return; |
||
| 116 | } |
||
| 117 | |||
| 118 | // 行数の確認 |
||
| 119 | $size = count($csv); |
||
| 120 | if ($size < 1) { |
||
| 121 | $errors[] = trans('admin.common.csv_invalid_format'); |
||
| 122 | |||
| 123 | return; |
||
| 124 | } |
||
| 125 | |||
| 126 | $columnNames = array_combine(array_keys($columnConfig), array_column($columnConfig, 'name')); |
||
| 127 | |||
| 128 | foreach ($csv as $line => $row) { |
||
| 129 | // 出荷IDがなければエラー |
||
| 130 | if (!isset($row[$columnNames['id']])) { |
||
| 131 | $errors[] = trans('admin.common.csv_invalid_required', ['%line%' => $line, '%name%' => $columnNames['id']]); |
||
| 132 | continue; |
||
| 133 | } |
||
| 134 | |||
| 135 | /* @var Shipping $Shipping */ |
||
| 136 | $Shipping = is_numeric($row[$columnNames['id']]) ? $this->shippingRepository->find($row[$columnNames['id']]) : null; |
||
| 137 | |||
| 138 | // 存在しない出荷IDはエラー |
||
| 139 | if (is_null($Shipping)) { |
||
| 140 | $errors[] = trans('admin.common.csv_invalid_not_found', ['%line%' => $line, '%name%' => $columnNames['id']]); |
||
| 141 | continue; |
||
| 142 | } |
||
| 143 | |||
| 144 | if (isset($row[$columnNames['tracking_number']])) { |
||
| 145 | $Shipping->setTrackingNumber($row[$columnNames['tracking_number']]); |
||
| 146 | } |
||
| 147 | |||
| 148 | if (isset($row[$columnNames['shipping_date']])) { |
||
| 149 | // 日付フォーマットが異なる場合はエラー |
||
| 150 | $shippingDate = \DateTime::createFromFormat('Y-m-d', $row[$columnNames['shipping_date']]); |
||
| 151 | if ($shippingDate === false) { |
||
| 152 | $errors[] = trans('admin.common.csv_invalid_date_format', ['%line%' => $line, '%name%' => $columnNames['id']]); |
||
| 153 | continue; |
||
| 154 | } |
||
| 155 | |||
| 156 | $shippingDate->setTime(0, 0, 0); |
||
| 157 | $Shipping->setShippingDate($shippingDate); |
||
| 158 | } |
||
| 159 | |||
| 160 | $Order = $Shipping->getOrder(); |
||
| 161 | $RelateShippings = $Order->getShippings(); |
||
| 162 | $allShipped = true; |
||
| 163 | foreach ($RelateShippings as $RelateShipping) { |
||
| 164 | if (!$RelateShipping->getShippingDate()) { |
||
| 165 | $allShipped = false; |
||
| 166 | break; |
||
| 167 | } |
||
| 168 | } |
||
| 169 | $OrderStatus = $this->entityManager->find(OrderStatus::class, OrderStatus::DELIVERED); |
||
| 170 | if ($allShipped) { |
||
| 171 | if ($this->orderStateMachine->can($Order, $OrderStatus)) { |
||
| 172 | $this->orderStateMachine->apply($Order, $OrderStatus); |
||
| 173 | } else { |
||
| 174 | $from = $Order->getOrderStatus()->getName(); |
||
| 175 | $to = $OrderStatus->getName(); |
||
| 176 | $errors[] = sprintf('%s: %s から %s へステータス変更できませんでした', $Shipping->getId(), $from, $to); |
||
| 177 | } |
||
| 178 | } |
||
| 179 | } |
||
| 180 | } |
||
| 181 | |||
| 215 |
This check looks for type mismatches where the missing type is
false. This is usually indicative of an error condtion.Consider the follow example
This function either returns a new
DateTimeobject or false, if there was an error. This is a typical pattern in PHP programming to show that an error has occurred without raising an exception. The calling code should check for this returnedfalsebefore passing on the value to another function or method that may not be able to handle afalse.