kitodo / kitodo-publication

Classes/Services/ElasticSearch.php

<?php
namespace EWW\Dpf\Services;

/*
 * This file is part of the TYPO3 CMS project.
 *
 * It is free software; you can redistribute it and/or modify it under
 * the terms of the GNU General Public License, either version 2
 * of the License, or any later version.
 *
 * For the full copyright and license information, please read the
 * LICENSE.txt file that was distributed with this source code.
 *
 * The TYPO3 project - inspiring people to share!
 */

use Elasticsearch\Client as Client;
use EWW\Dpf\Exceptions\RepositoryConnectionErrorException;
use TYPO3\CMS\Extbase\Object\ObjectManager;
use EWW\Dpf\Configuration\ClientConfigurationManager;

/**
 * Class ElasticSearch
 * @package EWW\Dpf\Services
 * @deprecated since version 4.0
 */
class ElasticSearch
{
    protected $es;

    protected $server = ''; //127.0.0.1';

    protected $port = '9200';

    protected $index = 'fedora';

    protected $type = 'object';

    protected $hits;

    protected $resultList;

    /**
     * elasticsearch client constructor
     */
    public function __construct()
    {
        $objectManager = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(ObjectManager::class);
        $clientConfigurationManager = $objectManager->get(ClientConfigurationManager::class);

        $this->server = $clientConfigurationManager->getElasticSearchHost();
        $this->port   = $clientConfigurationManager->getElasticSearchPort();

        // initialize elasticsearch lib
        $extensionPath = \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::extPath('dpf');

The assignment to $extensionPath is dead and can be removed.

        $params['hosts'] = array(

$params was never initialized. Although not strictly required by PHP, it is generally a good practice to add $params = array(); before regardless.

            $this->server . ':' . $this->port,
        );

        // $client = ClientBuilder::create()->build();
        $this->es = new Client($params);

The call to Elasticsearch\Client::__construct() has too few arguments starting with endpoint.

    }

    /**
     * performs the
     * @param  array $query search query
     * @return array        result list
     */
    public function search($query, $type)
    {
        try {
            // define type and index
            if (empty($query['index'])) {
                $query['index'] = $this->index;
            }
            if (!empty($type)) {
                $query['type'] = $type;
                // $query['type'] = $this->type;
            }

            // Search request
            $results = $this->es->search($query);

            $this->hits = $results['hits']['total'];

            $this->resultList = $results['hits'];

            return $this->resultList;
        } catch ( \Elasticsearch\Common\Exceptions\Curl\CouldNotConnectToHost $exception) {
            throw new \EWW\Dpf\Exceptions\ElasticSearchConnectionErrorException("Could not connect to repository server.");
        } catch (\Elasticsearch\Common\Exceptions\Curl\CouldNotResolveHostException $exception) {
            throw new \EWW\Dpf\Exceptions\ElasticSearchConnectionErrorException("Could not connect to repository server.");
        }
    }

    /**
     * returns the result list
     * @return [type] [description]

The doc comment [type] at position 0 could not be parsed: Unknown type name '[' at position 0 in [type].

     */
    public function getResults()
    {
        // return results from the last search request
        return $this->resultList;
    }
}