kitodo / kitodo-publication

Classes/Helper/UploadFileUrl.php

<?php
namespace EWW\Dpf\Helper;

/*
 * This file is part of the TYPO3 CMS project.
 *
 * It is free software; you can redistribute it and/or modify it under
 * the terms of the GNU General Public License, either version 2
 * of the License, or any later version.
 *
 * For the full copyright and license information, please read the
 * LICENSE.txt file that was distributed with this source code.
 *
 * The TYPO3 project - inspiring people to share!
 */

use EWW\Dpf\Configuration\ClientConfigurationManager;
use TYPO3\CMS\Extbase\Object\ObjectManager;

class UploadFileUrl
{

    /**
     * clientConfigurationManager
     *
     * @var \EWW\Dpf\Configuration\ClientConfigurationManager
     */
    protected $clientConfigurationManager;

    public function __construct() {
        $objectManager = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(ObjectManager::class);
        $this->clientConfigurationManager = $objectManager->get(ClientConfigurationManager::class);
    }


    public function getBaseUrl()
    {
        $uploadDomain = $this->clientConfigurationManager->getUploadDomain();

        $baseUrl = trim($uploadDomain, "/ ");

It seems like $uploadDomain can also be of type null; however, parameter $string of trim() does only seem to accept string, maybe add an additional type check?

        if (empty($baseUrl)) {
            $protocol = stripos($_SERVER['SERVER_PROTOCOL'], 'https') === false ? 'http://' : 'https://';
            $baseUrl  = $protocol . $_SERVER['HTTP_HOST'];
        }

        return $baseUrl;
    }

    public function getDirectory()
    {
        $uploadDirectory = $this->clientConfigurationManager->getUploadDirectory();

        $uploadDirectory = trim($uploadDirectory, "/ ");

It seems like $uploadDirectory can also be of type null; however, parameter $string of trim() does only seem to accept string, maybe add an additional type check?

        $uploadDir = empty($uploadDirectory) ? "uploads/tx_dpf" : $uploadDirectory;

        return $uploadDir;
    }

    public function getUploadUrl()
    {
        return $this->getBaseUrl() . "/" . $this->getDirectory();
    }

}