kitodo / kitodo-publication

Classes/Helper/InternalFormat.php

Upper-Lower-Casing +6 added lines, -6 removed lines

@@ -197,9 +197,9 @@ 
 
         $urnNodes = $xpath->query(self::rootNode . $primaryUrnXpath);
         if ($urnNodes->length > 0) {
-            return true;
+            return TRUE;
         } else {
-            return false;
+            return FALSE;
         }
     }
 
@@ -212,7 +212,7 @@ 
         if ($urnNodes->length > 0) {
             return $urnNodes->item(0)->nodeValue;
         } else {
-            return false;
+            return FALSE;
         }
     }
 
@@ -421,7 +421,7 @@ 
 
         $parserGenerator = new ParserGenerator($this->clientPid);
         $parserGenerator->setXml($this->xml->saveXML());
-        $parserGenerator->customXPath($notesXpath,true, $noteContent);
+        $parserGenerator->customXPath($notesXpath,TRUE, $noteContent);
         $this->xml = new \DOMDocument();
         $this->xml->loadXML($parserGenerator->getXMLData());
     }
@@ -532,7 +532,7 @@ 
     {
         $validationXpath =  $this->clientConfigurationManager->getValidationXpath();
         $validation = $this->getValue($validationXpath);
-        return (strtolower($validation) === 'true')? true : false;
+        return (strtolower($validation) === 'true')? TRUE : FALSE;
     }
 
     /**
@@ -580,7 +580,7 @@ 
         } elseif(!empty($value)) {
             $parserGenerator = new ParserGenerator($this->clientPid);
             $parserGenerator->setXml($this->xml->saveXML());
-            $parserGenerator->customXPath($xpathString,true, $value);
+            $parserGenerator->customXPath($xpathString,TRUE, $value);
             $this->xml = new \DOMDocument();
             $this->xml->loadXML($parserGenerator->getXMLData());
         }

Classes/Helper/DocumentMapper.php

Upper-Lower-Casing +14 added lines, -14 removed lines

@@ -44,7 +44,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\MetadataGroupRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $metadataGroupRepository = null;
+    protected $metadataGroupRepository = NULL;
 
     /**
      * metadataObjectRepository
@@ -52,7 +52,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\MetadataObjectRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $metadataObjectRepository = null;
+    protected $metadataObjectRepository = NULL;
 
     /**
      * documentTypeRepository
@@ -60,7 +60,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\DocumentTypeRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $documentTypeRepository = null;
+    protected $documentTypeRepository = NULL;
 
     /**
      * documentRepository
@@ -68,7 +68,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\DocumentRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $documentRepository = null;
+    protected $documentRepository = NULL;
 
     /**
      * fileRepository
@@ -76,7 +76,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\FileRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $fileRepository = null;
+    protected $fileRepository = NULL;
 
     /**
      * depositLicenseRepository
@@ -84,7 +84,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\DepositLicenseRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $depositLicenseRepository = null;
+    protected $depositLicenseRepository = NULL;
 
     /**
      * clientPid
@@ -96,7 +96,7 @@ 
     /**
      * @var bool
      */
-    protected $customClientPid = false;
+    protected $customClientPid = FALSE;
 
     /**
      * Get typoscript settings
@@ -118,7 +118,7 @@ 
      * @param bool $generateEmptyFields
      * @return \EWW\Dpf\Domain\Model\DocumentForm
      */
-    public function getDocumentForm(Document $document, $generateEmptyFields = true)
+    public function getDocumentForm(Document $document, $generateEmptyFields = TRUE)
     {
         $documentForm = new \EWW\Dpf\Domain\Model\DocumentForm();
         $documentForm->generateCsrfToken();
@@ -132,7 +132,7 @@ 
                 (
                     $this->getSettings()['deactivatePrimaryFileMandatoryCheck'] ||
                     $document->getDocumentType()->getVirtualType()
-                )? false : true
+                )? FALSE : TRUE
             )
         );
 
@@ -195,7 +195,7 @@ 
                 // build mapping path, previous fixed attributes which are differ from
                 // the own fixed attributes are excluded
                 $queryGroupMapping = $metadataGroup->getAbsoluteMapping();
-                if (strpos($queryGroupMapping, "@displayLabel") === false && is_array($excludeGroupAttributes[$groupMappingName])) {
+                if (strpos($queryGroupMapping, "@displayLabel") === FALSE && is_array($excludeGroupAttributes[$groupMappingName])) {
                     foreach ($excludeGroupAttributes[$groupMappingName] as $excludeAttr => $excludeAttrValue) {
                         if (!in_array($excludeAttr, $fixedGroupAttributes)) {
                             $queryGroupMapping .= $excludeAttrValue;
@@ -253,7 +253,7 @@ 
 
                                 // ensure that e.g. <mods:detail> and <mods:detail type="volume">
                                 // are not recognized as the same node
-                                if ((strpos($value, "@") === false) && ($value != '.')) {
+                                if ((strpos($value, "@") === FALSE) && ($value != '.')) {
                                     $objectMappingPath[$key] .= "[not(@*)]";
                                 }
                             }
@@ -310,7 +310,7 @@ 
                     }
                 } else {
 
-                    $documentFormGroup->setEmptyGroup(true);
+                    $documentFormGroup->setEmptyGroup(TRUE);
 
                     foreach ($metadataGroup->getMetadataObject() as $metadataObject) {
                         $documentFormField = new \EWW\Dpf\Domain\Model\DocumentFormField();
@@ -362,7 +362,7 @@ 
 
         if ($documentForm->getDocumentUid()) {
             if ($this->isCustomClientPid()) {
-                $this->documentRepository->crossClient(true);
+                $this->documentRepository->crossClient(TRUE);
             }
             $document = $this->documentRepository->findByUid($documentForm->getDocumentUid());
             $tempInternalFormat = new \EWW\Dpf\Helper\InternalFormat($document->getXmlData(), $this->clientPid);
@@ -528,7 +528,7 @@ 
      */
     public function setClientPid(int $clientPid): void
     {
-        $this->customClientPid = true;
+        $this->customClientPid = TRUE;
         $this->clientPid = $clientPid;
     }
 

Classes/Domain/Repository/BookmarkRepository.php

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -105,10 +105,10 @@
             $bookmark->setDocumentIdentifier($identifier);
             $bookmark->setFeUserUid($feUserUid);
             $this->add($bookmark);
-            return true;
+            return TRUE;
         }
 
-        return false;
+        return FALSE;
     }
 
     /**

Classes/Domain/Repository/AbstractRepository.php

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -28,13 +28,13 @@
     public function crossClientFindAll($returnRawQueryResult = TRUE) {
         /** @var $querySettings \TYPO3\CMS\Extbase\Persistence\Generic\Typo3QuerySettings */
         $querySettings = $this->objectManager->get('TYPO3\\CMS\\Extbase\\Persistence\\Generic\\Typo3QuerySettings');
-        $querySettings->setRespectStoragePage(false);
+        $querySettings->setRespectStoragePage(FALSE);
         $this->setDefaultQuerySettings($querySettings);
         $query = $this->createQuery();
         return $query->execute($returnRawQueryResult);
     }
 
-    public function crossClient($active = false)
+    public function crossClient($active = FALSE)
     {
         /** @var $querySettings \TYPO3\CMS\Extbase\Persistence\Generic\Typo3QuerySettings */
         $querySettings = $this->objectManager->get('TYPO3\\CMS\\Extbase\\Persistence\\Generic\\Typo3QuerySettings');

Classes/Domain/Repository/FrontendUserRepository.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -15,7 +15,7 @@
     {
         /** @var $querySettings \TYPO3\CMS\Extbase\Persistence\Generic\Typo3QuerySettings */
         $querySettings = $this->objectManager->get('TYPO3\\CMS\\Extbase\\Persistence\\Generic\\Typo3QuerySettings');
-        $querySettings->setRespectStoragePage(false);
+        $querySettings->setRespectStoragePage(FALSE);
         $this->setDefaultQuerySettings($querySettings);
         $query = $this->createQuery();
 

Classes/Services/ElasticSearch/ElasticSearch.php

Upper-Lower-Casing +11 added lines, -11 removed lines

@@ -61,7 +61,7 @@ 
      * @param int|null $clientPid
      * @throws ElasticSearchMissingIndexNameException
      */
-    public function __construct($clientPid = null)
+    public function __construct($clientPid = NULL)
     {
         $objectManager = GeneralUtility::makeInstance(ObjectManager::class);
 
@@ -152,7 +152,7 @@ 
                 ],
                 'mappings' => [
                     '_source' => [
-                        'enabled' => true
+                        'enabled' => TRUE
                     ],
                     //'dynamic' => 'strict',
                     'properties' => [
@@ -215,11 +215,11 @@ 
                                 ],
                                 'fobId' => [
                                     //'type' => 'keyword'
-                                    'enabled' => false
+                                    'enabled' => FALSE
                                 ],
                                 'index' => [
                                     //'type' => 'integer'
-                                    'enabled' => false
+                                    'enabled' => FALSE
                                 ]
                             ]
                         ],
@@ -281,7 +281,7 @@ 
             if ($document->getCreator()) {
                 $data->creator = $document->getCreator();
             } else {
-                $data->creator = null;
+                $data->creator = NULL;
             }
 
             if ($document->getCreator()) {
@@ -315,9 +315,9 @@ 
 
             $files = $document->getFile();
             if ($files->count() > 0) {
-                $data->hasFiles = true;
+                $data->hasFiles = TRUE;
             } else {
-                $data->hasFiles = false;
+                $data->hasFiles = FALSE;
             }
 
             $internalFormat = new \EWW\Dpf\Helper\InternalFormat($document->getXmlData(), $this->clientPid);
@@ -353,11 +353,11 @@ 
 
             $data->source = $document->getSourceDetails();
 
-            $data->universityCollection = false;
+            $data->universityCollection = FALSE;
             if ($data->collections && is_array($data->collections)) {
                 foreach ($data->collections as $collection) {
                     if ($collection == $this->clientConfigurationManager->getUniversityCollection()) {
-                        $data->universityCollection = true;
+                        $data->universityCollection = TRUE;
                         break;
                     }
                 }
@@ -367,7 +367,7 @@ 
             if ($embargoDate instanceof \DateTime) {
                 $data->embargoDate = $embargoDate->format("Y-m-d");
             } else {
-                $data->embargoDate = null;
+                $data->embargoDate = NULL;
             }
 
             $data->originalSourceTitle = $internalFormat->getOriginalSourceTitle();
@@ -434,7 +434,7 @@ 
      * @param  array $query search query
      * @return array        result list
      */
-    public function search($query, $type = null)
+    public function search($query, $type = NULL)
     {
         try {
             // define type and index

Classes/Services/ElasticSearch/QueryBuilder.php

Upper-Lower-Casing +4 added lines, -4 removed lines

@@ -34,7 +34,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\DocumentTypeRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $documentTypeRepository = null;
+    protected $documentTypeRepository = NULL;
 
     /**
      * security
@@ -42,7 +42,7 @@ 
      * @var \EWW\Dpf\Security\Security
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $security = null;
+    protected $security = NULL;
 
     /**
      * Builds the document list query.
@@ -61,7 +61,7 @@ 
      */
     public function buildQuery(
         $itemsPerPage, $workspaceFilter, $from = 0, $bookmarkIdentifiers = [], $filters = [],
-        $excludeFilters = [], $sortField = null, $sortOrder = null, $queryString = null
+        $excludeFilters = [], $sortField = NULL, $sortOrder = NULL, $queryString = NULL
     )
     {
 
@@ -238,7 +238,7 @@ 
 
             foreach ($filters as $key => $filterValues) {
                 $queryFilterPart = [];
-                if (in_array($key, $validKeys, true)) {
+                if (in_array($key, $validKeys, TRUE)) {
                     if ($key == 'universityCollection') {
                         if ($filterValues && is_array($filterValues)) {
                             if (in_array("true", $filterValues)) {

Classes/Domain/Repository/DocumentRepository.php

Upper-Lower-Casing +22 added lines, -22 removed lines

@@ -39,7 +39,7 @@ 
 
             case Security::ROLE_LIBRARIAN:
                 $query->matching(
-                    $query->equals('suggestion', true)
+                    $query->equals('suggestion', TRUE)
                 );
                 break;
 
@@ -47,7 +47,7 @@ 
                 $query->matching(
                     $query->logicalAnd(
                         array(
-                            $query->equals('suggestion', true),
+                            $query->equals('suggestion', TRUE),
                             $query->equals('creator', $creatorUid)
                         )
                     )
@@ -61,21 +61,21 @@ 
      * @param boolean $temporary
      * @return array
      */
-    public function getObjectIdentifiers($temporary = false)
+    public function getObjectIdentifiers($temporary = FALSE)
     {
         $query = $this->createQuery();
 
         $constraints = array(
             $query->logicalNot($query->equals('object_identifier', '')),
-            $query->logicalNot($query->equals('object_identifier', null))
+            $query->logicalNot($query->equals('object_identifier', NULL))
         );
 
         if (count($constraints)) {
             $constraints[] = $query->logicalAnd(
                 $query->logicalNot(
                     $query->logicalOr(
-                        $query->equals('temporary', true),
-                        $query->equals('suggestion', true)
+                        $query->equals('temporary', TRUE),
+                        $query->equals('suggestion', TRUE)
                     )
                 )
             );
@@ -102,16 +102,16 @@ 
     public function findDocumentsWithoutProcessNumber()
     {
         $query = $this->createQuery();
-        $query->getQuerySettings()->setRespectStoragePage(false);
+        $query->getQuerySettings()->setRespectStoragePage(FALSE);
 
         $constraints = array();
         $constraints[] = $query->equals('process_number', '');
-        $constraints[] = $query->equals('process_number', null);
+        $constraints[] = $query->equals('process_number', NULL);
 
         if (count($constraints)) {
             $query->matching(
                 $query->logicalAnd(
-                    $query->equals('temporary', false),
+                    $query->equals('temporary', FALSE),
                     $query->logicalOr($constraints)
                 )
             );
@@ -138,7 +138,7 @@ 
 
         $query->matching(
             $query->logicalAnd(
-                $query->equals('temporary', true),
+                $query->equals('temporary', TRUE),
                 $query->logicalOr($constraints)
             )
         );
@@ -183,8 +183,8 @@ 
 
         $constraints = array(
             $query->equals('object_identifier', $objectIdentifier),
-            $query->logicalNot($query->equals('temporary', true)),
-            $query->logicalNot($query->equals('suggestion', true))
+            $query->logicalNot($query->equals('temporary', TRUE)),
+            $query->logicalNot($query->equals('suggestion', TRUE))
         );
 
         $query->matching($query->logicalAnd($constraints));
@@ -208,18 +208,18 @@ 
             $constraints = [
                 $query->logicalAnd(
                     $query->equals('object_identifier', $identifier),
-                    $query->equals('suggestion', false)
+                    $query->equals('suggestion', FALSE)
                 )
             ];
         } elseif (Identifier::isProcessNumber($identifier)) {
             $constraints = [
                 $query->logicalAnd(
                     $query->equals('process_number', $identifier),
-                    $query->equals('suggestion', false)
+                    $query->equals('suggestion', FALSE)
                 )
             ];
         } else {
-            return null;
+            return NULL;
         }
 
         $query->setOrderings(array("tstamp" => \TYPO3\CMS\Extbase\Persistence\QueryInterface::ORDER_DESCENDING));
@@ -234,7 +234,7 @@ 
      * @param bool $includeSuggestion
      * @return Document
      */
-    public function findWorkingCopy($identifier, $includeTemporary = false, $includeSuggestion = false)
+    public function findWorkingCopy($identifier, $includeTemporary = FALSE, $includeSuggestion = FALSE)
     {
         $query = $this->createQuery();
 
@@ -269,8 +269,8 @@ 
         if (trim($document->getObjectIdentifier()) && !$document->isTemporary() && !$document->isSuggestion()) {
             $query = $this->createQuery();
             $constraints[] = $query->equals('object_identifier', trim($document->getObjectIdentifier()));
-            $constraints[] = $query->equals('temporary', false);
-            $constraints[] = $query->equals('suggestion', false);
+            $constraints[] = $query->equals('temporary', FALSE);
+            $constraints[] = $query->equals('suggestion', FALSE);
             $query->matching($query->logicalAnd($constraints));
 
             /** @var Document $workingCopy */
@@ -304,7 +304,7 @@ 
     {
         /** @var $querySettings \TYPO3\CMS\Extbase\Persistence\Generic\Typo3QuerySettings */
         $querySettings = $this->objectManager->get('TYPO3\\CMS\\Extbase\\Persistence\\Generic\\Typo3QuerySettings');
-        $querySettings->setRespectStoragePage(false);
+        $querySettings->setRespectStoragePage(FALSE);
         $this->setDefaultQuerySettings($querySettings);
         $query = $this->createQuery();
         $query->matching(
@@ -332,19 +332,19 @@ 
             $constraints[] =
                 $query->logicalAnd(
                     $query->like('uid', $identifier),
-                    $query->equals('suggestion', false)
+                    $query->equals('suggestion', FALSE)
                 );
 
             $constraints[] =
                 $query->logicalAnd(
                     $query->like('object_identifier', $identifier),
-                    $query->equals('suggestion', false)
+                    $query->equals('suggestion', FALSE)
                 );
 
             $constraints[] =
                 $query->logicalAnd(
                     $query->like('process_number', $identifier),
-                    $query->equals('suggestion', false)
+                    $query->equals('suggestion', FALSE)
                 );
 
         $query->setOrderings(array("tstamp" => \TYPO3\CMS\Extbase\Persistence\QueryInterface::ORDER_DESCENDING));

Classes/Controller/BackendAdminController.php

Upper-Lower-Casing +16 added lines, -16 removed lines

@@ -40,7 +40,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\DocumentRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $documentRepository = null;
+    protected $documentRepository = NULL;
 
     /**
      * fileRepository
@@ -48,7 +48,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\FileRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $fileRepository = null;
+    protected $fileRepository = NULL;
 
     /**
      * documentTypeRepository
@@ -56,7 +56,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\DocumentTypeRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $documentTypeRepository = null;
+    protected $documentTypeRepository = NULL;
 
     /**
      * bookmarkRepository
@@ -64,7 +64,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\BookmarkRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $bookmarkRepository = null;
+    protected $bookmarkRepository = NULL;
 
     /**
      * frontendUserRepository
@@ -72,7 +72,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\FrontendUserRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $frontendUserRepository = null;
+    protected $frontendUserRepository = NULL;
 
     /**
      * clientRepository
@@ -80,7 +80,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\ClientRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $clientRepository = null;
+    protected $clientRepository = NULL;
 
     /**
     * Backend Template Container
@@ -121,7 +121,7 @@ 
 
         if ($identifier) {
 
-            $this->documentRepository->crossClient(true);
+            $this->documentRepository->crossClient(TRUE);
 
             $documents = $this->documentRepository->searchForIdentifier($identifier);
 
@@ -160,7 +160,7 @@ 
                 /** @var Client $currentClient */
                 $currentClient = $this->clientRepository->findAllByPid($document->getPid())->current();
 
-                $allClients = $this->clientRepository->crossClientFindAll(false);
+                $allClients = $this->clientRepository->crossClientFindAll(FALSE);
 
                 $documentTypes = [];
                 $clients = [];
@@ -169,7 +169,7 @@ 
                 foreach ($allClients as $client) {
                     if ($client->getUid() != $currentClient->getUid()) {
                         $clients[] = $client;
-                        $this->documentTypeRepository->crossClient(true);
+                        $this->documentTypeRepository->crossClient(TRUE);
                         $documentTypes[$client->getPid()] = $this->documentTypeRepository->findByPid($client->getPid());
                     }
                 }
@@ -191,8 +191,8 @@ 
 
                 $this->forward(
                     'searchDocument',
-                    null,
-                    null,
+                    NULL,
+                    NULL,
                     [
                         'identifier' => $identifier
                     ]
@@ -207,7 +207,7 @@ 
      * @param string $identifier
      * @param DocumentType $documentType
      */
-    public function changeClientAction(Document $document, Client $client, string $identifier, DocumentType $documentType = null)
+    public function changeClientAction(Document $document, Client $client, string $identifier, DocumentType $documentType = NULL)
     {
         if ($documentType instanceof DocumentType) {
             if ($document->isClientChangeable()) {
@@ -248,7 +248,7 @@ 
 
                 // If there are bookmarks, they have to be adjusted, depending on the existence of the related user
                 // inside the target client, and either deleted or moved to the target client.
-                $this->bookmarkRepository->crossClient(true);
+                $this->bookmarkRepository->crossClient(TRUE);
                 $bookmarks = $this->bookmarkRepository->findDocumentBookmarks($document);
                 /** @var Bookmark $bookmark */
                 foreach ($bookmarks as $bookmark) {
@@ -296,8 +296,8 @@ 
 
             $this->forward(
               'chooseNewClient',
-              null,
-              null,
+              NULL,
+              NULL,
               [
                   'document' => $document,
                   'identifier' => $identifier
@@ -322,7 +322,7 @@ 
         int $severity = AbstractMessage::INFO,
         array $headerArguments,
         array $bodyArguments,
-        bool $storeInSession = false
+        bool $storeInSession = FALSE
     )
     {
         $messageHeader = LocalizationUtility::translate(