EWW\Dpf\Controller\GndController

Complexity

Total Complexity

5

Size/Duplication

Total Lines	55
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	searchAction()	0	27	4
A	gndAction()	0	7	1

<?php
namespace EWW\Dpf\Controller;

/*
 * This file is part of the TYPO3 CMS project.
 *
 * It is free software; you can redistribute it and/or modify it under
 * the terms of the GNU General Public License, either version 2
 * of the License, or any later version.
 *
 * For the full copyright and license information, please read the
 * LICENSE.txt file that was distributed with this source code.
 *
 * The TYPO3 project - inspiring people to share!
 */


use TYPO3\CMS\Core\Utility\GeneralUtility;

The type TYPO3\CMS\Core\Utility\GeneralUtility was not found. Maybe you did not declare it correctly or list all dependencies?

/**
 * GndController
 */
class GndController extends \EWW\Dpf\Controller\AbstractController
{
    // TODO: Make gndHost and Urls configurable
    protected $gndHost = 'https://xgnd.bsz-bw.de/';

    protected $searchUrl = 'Anfrage?suchfeld=pica.swr&suchfilter=000000&suchoptionen=pica.tbs%3D%22s%22&suchwort=';

    protected $gndResolverUrl = 'Anfrage?suchfeld=pica.ppn&suchoptionen=pica.tbs%3D"s"+and+&suchwort=';

    protected $baseGndValueUri = 'http://d-nb.info/gnd/';

    /**
     * @param string $search
     * @return array
     */
    public function searchAction($search) {

        $url = $this->gndHost . $this->searchUrl . $search;
        $content = file_get_contents($url);
        $json = json_decode($content);

        $listArray = array();
        $i = 0;
        foreach ($json as $value) {
            $listArray[$i]['value'] = $value->Ansetzung;
            $listArray[$i]['ppn'] = $value->PPN;
            $listArray[$i]['typ'] = $value->Typ;
            if ($value->GNDNr) {
                $listArray[$i]['gnd'] = $this->baseGndValueUri.$value->GNDNr;
            } else {
                $listArray[$i]['gnd'] = $this->baseGndValueUri.$this->gndAction($value->PPN);
            }
            $i++;
        }

        if (empty($listArray)) {
            echo json_encode(null);
        } else {
            echo json_encode($listArray);
        }

        return '';

The expression return '' returns the type string which is incompatible with the documented return type array.

    }

    /**
     * @param string $PPN
     * @return mixed
     */
    public function gndAction($PPN) {

        $url = $this->gndHost . $this->gndResolverUrl . $PPN;
        $content = file_get_contents($url);
        $json = json_decode($content);

        return $json[0]->GNDNr;
    }
}