DocumentFormController::__construct() - Code Metrics - Inspection of "Avoid resending form" - kitodo/kitodo-publication - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#92)

by Ralf

created 2018-06-12 07:00 UTC

DocumentFormController::__construct() A

↳ Parent: DocumentFormController

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php
namespace EWW\Dpf\Controller;

/*
 * This file is part of the TYPO3 CMS project.
 *
 * It is free software; you can redistribute it and/or modify it under
 * the terms of the GNU General Public License, either version 2
 * of the License, or any later version.
 *
 * For the full copyright and license information, please read the
 * LICENSE.txt file that was distributed with this source code.
 *
 * The TYPO3 project - inspiring people to share!
 */

class DocumentFormController extends AbstractDocumentFormController
{

    protected function redirectToList($message = null)
    {
        $this->redirect('list', 'DocumentForm', null, array('message' => $message));
    }

    /**
     * action create
     *
     * @param \EWW\Dpf\Domain\Model\DocumentForm $newDocumentForm
     * @return void
     */
    public function createAction(\EWW\Dpf\Domain\Model\DocumentForm $newDocumentForm)
    {
        foreach ($newDocumentForm->getNewFiles() as $newFile) {
            $uid = $newFile->getUID();
            if (empty($uid)) {
                $newFile->setDownload(true);
            }
            $files[] = $newFile;
        }

        $newDocumentForm->setNewFiles($files);


        parent::createAction($newDocumentForm);
    }
}


1			<?php
2			namespace EWW\Dpf\Controller;
3
4			/*
5			* This file is part of the TYPO3 CMS project.
6			*
7			* It is free software; you can redistribute it and/or modify it under
8			* the terms of the GNU General Public License, either version 2
9			* of the License, or any later version.
10			*
11			* For the full copyright and license information, please read the
12			* LICENSE.txt file that was distributed with this source code.
13			*
14			* The TYPO3 project - inspiring people to share!
15			*/
16
17			class DocumentFormController extends AbstractDocumentFormController
18			{
19
20			protected function redirectToList($message = null)
21			{
22			$this->redirect('list', 'DocumentForm', null, array('message' => $message));
23			}
24
25			/**
26			* action create
27			*
28			* @param \EWW\Dpf\Domain\Model\DocumentForm $newDocumentForm
29			* @return void
30			*/
31			public function createAction(\EWW\Dpf\Domain\Model\DocumentForm $newDocumentForm)
32			{
33			foreach ($newDocumentForm->getNewFiles() as $newFile) {
34			$uid = $newFile->getUID();
35			if (empty($uid)) {
36			$newFile->setDownload(true);
37			}
38			$files[] = $newFile;
39			}
40
41			$newDocumentForm->setNewFiles($files);
			0 ignored issues – show Comprehensibility Best Practice introduced 2017-12-20 21:05 UTC by Report Bug Copy Issue Report The variable `$files` seems to be defined by a `foreach` iteration on line `33`. Are you sure the iterator is never empty, otherwise this variable is not defined? Loading history...
42
43			parent::createAction($newDocumentForm);
44			}
45			}
46

kitodo / kitodo-publication

Pull Request — master (#92)

DocumentFormController::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like