kitodo / kitodo-publication

Classes/ViewHelpers/ShowStatusViewHelper.php

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
         }
 
         return \TYPO3\CMS\Extbase\Utility\LocalizationUtility::translate(
-            "manager.documentList.state.".$aliasState,
+            "manager.documentList.state." . $aliasState,
             'dpf',
             $arguments = null
         );

Classes/Controller/DocumentController.php

Spacing +8 added lines, -8 removed lines

@@ -402,7 +402,7 @@ 
                             // check if new document form has more field items as the existing form
                             if ($valueFieldCounter < $fieldCounter && !$checkFieldsForAdding) {
                                 // field added
-                                for ($i = count($valueField); $i < $fieldCounter;$i++) {
+                                for ($i = count($valueField); $i < $fieldCounter; $i++) {
                                     $returnArray['added'][] = $docForm2->getItems()[$keyPage][$keyRepeatPage]->getItems()[$keyGroup][$keyRepeatGroup]->getItems()[$keyField][$i];
 
                                 }
@@ -414,7 +414,7 @@ 
                     if ($valueGroupCounter < count($docForm2->getItems()[$keyPage][$keyRepeatPage]->getItems()[$keyGroup])) {
                         // group added
                         $counter = count($docForm2->getItems()[$keyPage][$keyRepeatPage]->getItems()[$keyGroup]);
-                        for ($i = $valueGroupCounter; $i < $counter;$i++) {
+                        for ($i = $valueGroupCounter; $i < $counter; $i++) {
                             $returnArray['added'][] = $docForm2->getItems()[$keyPage][$keyRepeatPage]->getItems()[$keyGroup][$i];
                         }
                     }
@@ -663,7 +663,7 @@ 
 
         $newDocument->setState(DocumentWorkflow::STATE_NEW_NONE);
 
-        $copyTitle = LocalizationUtility::translate("manager.workspace.title.copy", "dpf").$document->getTitle();
+        $copyTitle = LocalizationUtility::translate("manager.workspace.title.copy", "dpf") . $document->getTitle();
 
         $newDocument->setTitle($copyTitle);
 
@@ -804,7 +804,7 @@ 
         }
 
         $this->editingLockService->lock(
-            ($document->getObjectIdentifier()? $document->getObjectIdentifier() : $document->getUid()),
+            ($document->getObjectIdentifier() ? $document->getObjectIdentifier() : $document->getUid()),
             $this->security->getUser()->getUid()
         );
 
@@ -871,7 +871,7 @@ 
         $documentForm = $documentMapper->getDocumentForm($document);
 
         $this->view->assign('suggestMod', true);
-        $this->forward('edit','DocumentFormBackoffice',NULL, ['documentForm' => $documentForm, 'suggestMod' => true]);
+        $this->forward('edit', 'DocumentFormBackoffice', NULL, ['documentForm' => $documentForm, 'suggestMod' => true]);
     }
 
 
@@ -1008,7 +1008,7 @@ 
 
             if ($this->documentManager->update($document, $workflowTransition)) {
 
-                $key = 'LLL:EXT:dpf/Resources/Private/Language/locallang.xlf:'.$messageKeyPart.'.success';
+                $key = 'LLL:EXT:dpf/Resources/Private/Language/locallang.xlf:' . $messageKeyPart . '.success';
                 $this->flashMessage($document, $key, AbstractMessage::OK);
 
                 if ($this->security->getUserRole() === Security::ROLE_LIBRARIAN) {
@@ -1037,7 +1037,7 @@ 
 
                 $this->redirectToDocumentList();
             } else {
-                $key = 'LLL:EXT:dpf/Resources/Private/Language/locallang.xlf:'.$messageKeyPart.'.failure';
+                $key = 'LLL:EXT:dpf/Resources/Private/Language/locallang.xlf:' . $messageKeyPart . '.failure';
                 $this->flashMessage($document, $key, AbstractMessage::ERROR);
                 $this->redirect('showDetails', 'Document', NULL, ['document' => $document]);
             }
@@ -1048,7 +1048,7 @@ 
             if ($exception instanceof DPFExceptionInterface) {
                 $key = $exception->messageLanguageKey();
             } else {
-                $key = 'LLL:EXT:dpf/Resources/Private/Language/locallang.xlf:'.$messageKeyPart.'.failure';
+                $key = 'LLL:EXT:dpf/Resources/Private/Language/locallang.xlf:' . $messageKeyPart . '.failure';
             }
             $this->flashMessage($document, $key, AbstractMessage::ERROR);
             $this->redirectToDocumentList();

Classes/Controller/DocumentFormBackofficeController.php

Spacing +11 added lines, -11 removed lines

@@ -92,7 +92,7 @@ 
     }
 
     public function arrayRecursiveDiff($aArray1, $aArray2) {
-        $aReturn = array();
+        $aReturn = array ();
 
         foreach ($aArray1 as $mKey => $mValue) {
             if (array_key_exists($mKey, $aArray2)) {
@@ -146,13 +146,13 @@ 
                 $message = LocalizationUtility::translate(
                     'LLL:EXT:dpf/Resources/Private/Language/locallang.xlf:document_edit.accessDenied',
                     'dpf',
-                    array($document->getTitle())
+                    array ($document->getTitle())
                 );
             } else {
                 $message = LocalizationUtility::translate(
                     'LLL:EXT:dpf/Resources/Private/Language/locallang.xlf:document_edit.failureBlocked',
                     'dpf',
-                    array($document->getTitle())
+                    array ($document->getTitle())
                 );
             }
 
@@ -165,7 +165,7 @@ 
         $this->view->assign('suggestMod', $suggestMod);
 
         $this->editingLockService->lock(
-            ($document->getObjectIdentifier()? $document->getObjectIdentifier() : $document->getUid()),
+            ($document->getObjectIdentifier() ? $document->getObjectIdentifier() : $document->getUid()),
             $this->security->getUser()->getUid()
         );
 
@@ -286,7 +286,7 @@ 
 
         } catch (\Throwable $t) {
             $severity = \TYPO3\CMS\Core\Messaging\AbstractMessage::ERROR;
-            $this->addFlashMessage("Failed", '', $severity,false);
+            $this->addFlashMessage("Failed", '', $severity, false);
         }
 
         $this->redirectToDocumentList();
@@ -348,7 +348,7 @@ 
                 $message = LocalizationUtility::translate(
                     'LLL:EXT:dpf/Resources/Private/Language/locallang.xlf:document_update.accessDenied',
                     'dpf',
-                    array($document->getTitle())
+                    array ($document->getTitle())
                 );
                 $this->addFlashMessage($message, '', AbstractMessage::ERROR);
 
@@ -376,7 +376,7 @@ 
             $workflowTransition = null;
 
             // Convert the temporary copy into a local working copy if needed.
-            if ( $updateDocument->isTemporaryCopy() && $saveMode == 'saveWorkingCopy') {
+            if ($updateDocument->isTemporaryCopy() && $saveMode == 'saveWorkingCopy') {
                 $saveWorkingCopy = true;
                 $updateDocument->setTemporary(false);
                 $workflowTransition = DocumentWorkflow::TRANSITION_IN_PROGRESS;
@@ -428,7 +428,7 @@ 
                 $message = LocalizationUtility::translate(
                     'LLL:EXT:dpf/Resources/Private/Language/locallang.xlf:document_update.success',
                     'dpf',
-                    array($updateDocument->getTitle())
+                    array ($updateDocument->getTitle())
                 );
                 $this->addFlashMessage($message, '', AbstractMessage::OK);
 
@@ -482,7 +482,7 @@ 
                 $message = LocalizationUtility::translate(
                     'LLL:EXT:dpf/Resources/Private/Language/locallang.xlf:document_update.failure',
                     'dpf',
-                    array($updateDocument->getTitle())
+                    array ($updateDocument->getTitle())
                 );
                 $this->addFlashMessage($message, '', AbstractMessage::ERROR);
             }
@@ -516,7 +516,7 @@ 
             $exceptionMsg[] = LocalizationUtility::translate(
                 'LLL:EXT:dpf/Resources/Private/Language/locallang.xlf:document_update.failure',
                 'dpf',
-                array($updateDocument->getTitle())
+                array ($updateDocument->getTitle())
             );
 
             $exceptionMsg[] = LocalizationUtility::translate($key, 'dpf');
@@ -645,7 +645,7 @@ 
         if ($redirectUri) {
             $this->redirectToUri($redirectUri);
         } else {
-            $this->redirect($action, $controller, null, array('message' => $message));
+            $this->redirect($action, $controller, null, array ('message' => $message));
         }
     }
 }

Classes/Controller/UserController.php

Spacing +2 added lines, -2 removed lines

@@ -51,7 +51,7 @@ 
                 $this->addFlashMessage(
                     LocalizationUtility::translate("manager.locallang.user.settings.message.invalidFisId", "dpf"),
                     '',
-                    $severity,false
+                    $severity, false
                 );
             }
         }
@@ -61,7 +61,7 @@ 
         $this->addFlashMessage(
             LocalizationUtility::translate("manager.locallang.user.settings.message.successfullySaved", "dpf"),
             '',
-            $severity,false
+            $severity, false
         );
 
         $this->forward('settings');

Classes/Controller/ApiController.php

Spacing +7 added lines, -7 removed lines

@@ -259,7 +259,7 @@ 
             }
 
             if ($this->documentManager->update($doc, null, [], [], true)) {
-                return '{"success": "Document '.$document.' added '.$id.'"}';
+                return '{"success": "Document ' . $document . ' added ' . $id . '"}';
             } else {
                 return '{"failed": Could not update the Document"}';
             }
@@ -298,7 +298,7 @@ 
                     return '{"error": "Invalid data in parameter json."}';
                 }
             } else {
-                if (empty($json) || json_decode($json,true) === []) {
+                if (empty($json) || json_decode($json, true) === []) {
                     return '{"error": "Parameter json can not be empty."}';
                 }
                 if (is_null(json_decode($json))) {
@@ -310,7 +310,7 @@ 
             $doc = $this->documentManager->read($document);
 
             if (!$doc) {
-                return '{"failed": "Document does not exist: '.$document.'"}';
+                return '{"failed": "Document does not exist: ' . $document . '"}';
             }
 
             if ($doc->getState() === DocumentWorkflow::STATE_NEW_NONE) {
@@ -323,7 +323,7 @@ 
             }
 
             if ($linkedDocument) {
-                return '{"failed": "There is already a suggestion for the document: '.$linkedDocument->getUid().'"}';
+                return '{"failed": "There is already a suggestion for the document: ' . $linkedDocument->getUid() . '"}';
             }
 
             $mapper = $this->objectManager->get(\EWW\Dpf\Services\Api\JsonToDocumentMapper::class);
@@ -681,7 +681,7 @@ 
         $missingArguments = [];
         foreach ($parameterNames as $parameterName) {
             if (!$this->request->hasArgument($parameterName)) {
-                $missingArguments[] =  $parameterName;
+                $missingArguments[] = $parameterName;
             }
         }
 
@@ -689,7 +689,7 @@ 
             $this->throwStatus(
                 400,
                 null,
-                '{"error": "Missing parameters: '.implode(", ", $missingArguments).'"}'
+                '{"error": "Missing parameters: ' . implode(", ", $missingArguments) . '"}'
             );
         }
 
@@ -719,7 +719,7 @@ 
             $this->throwStatus(
                 400,
                 null,
-            '{"error": "An invalid action hes been called: '.$actionName.'"}'
+            '{"error": "An invalid action hes been called: ' . $actionName . '"}'
             );
         }
 

Classes/Controller/AbstractDocumentFormController.php

Spacing +2 added lines, -2 removed lines

@@ -183,7 +183,7 @@ 
                 $this->request->setArguments($requestArguments);
             } else {
                 $t = $docForm->getNewFileNames();
-                $this->redirect('list', 'DocumentForm', null, array('message' => 'UPLOAD_MAX_FILESIZE_ERROR', 'errorFiles' => $t));
+                $this->redirect('list', 'DocumentForm', null, array ('message' => 'UPLOAD_MAX_FILESIZE_ERROR', 'errorFiles' => $t));
             }
         } else {
             $this->redirectToList("UPLOAD_POST_SIZE_ERROR");
@@ -338,7 +338,7 @@ 
                 $this->request->setArguments($requestArguments);
             } else {
                 $t = $docForm->getNewFileNames();
-                $this->redirect('list', 'Document', null, array('message' => 'UPLOAD_MAX_FILESIZE_ERROR', 'errorFiles' => $t));
+                $this->redirect('list', 'Document', null, array ('message' => 'UPLOAD_MAX_FILESIZE_ERROR', 'errorFiles' => $t));
             }
         } else {
             $this->redirectToList("UPLOAD_POST_SIZE_ERROR");

Classes/Controller/AjaxBackofficeController.php

Spacing +10 added lines, -10 removed lines

@@ -250,7 +250,7 @@ 
      */
     public function searchFisAction($searchTerm, $type = 'person') {
         $fisUserDataService = new FisDataService();
-        $methodName = 'search'.ucfirst($type).'Request';
+        $methodName = 'search' . ucfirst($type) . 'Request';
         $result = $fisUserDataService->{$methodName}($searchTerm);
 
         return json_encode($result);
@@ -267,10 +267,10 @@ 
      */
     public function getFisDataAction($dataId, $groupId, $groupIndex, $fieldIndex, $pageId, $type = 'person') {
         $fisDataService = new FisDataService();
-        $methodName = 'get'.ucfirst($type).'Data';
+        $methodName = 'get' . ucfirst($type) . 'Data';
         $fisData = $fisDataService->{$methodName}($dataId);
 
-        $result = $this->getApiMappingArray($groupId, $fisData, $groupIndex, $fieldIndex, $pageId, 'getFis'.ucfirst($type).'Mapping');
+        $result = $this->getApiMappingArray($groupId, $fisData, $groupIndex, $fieldIndex, $pageId, 'getFis' . ucfirst($type) . 'Mapping');
 
         return json_encode($result);
     }
@@ -282,7 +282,7 @@ 
      */
     public function searchGndAction($searchTerm, $type = 'person') {
         $gndUserDataService = new GndDataService();
-        $methodName = 'search'.ucfirst($type).'Request';
+        $methodName = 'search' . ucfirst($type) . 'Request';
         $result = $gndUserDataService->{$methodName}($searchTerm);
 
         return json_encode($result);
@@ -298,10 +298,10 @@ 
      */
     public function getGndDataAction($dataId, $groupId, $groupIndex, $fieldIndex, $pageId, $type = 'person') {
         $gndUserDataService = new GndDataService();
-        $methodName = 'get'.ucfirst($type).'Data';
+        $methodName = 'get' . ucfirst($type) . 'Data';
         $gndData = $gndUserDataService->{$methodName}($dataId);
 
-        $result = $this->getApiMappingArray($groupId, $gndData, $groupIndex, $fieldIndex, $pageId, 'getGnd'.ucfirst($type).'Mapping');
+        $result = $this->getApiMappingArray($groupId, $gndData, $groupIndex, $fieldIndex, $pageId, 'getGnd' . ucfirst($type) . 'Mapping');
 
         return json_encode($result);
     }
@@ -396,7 +396,7 @@ 
      */
     public function searchOrcidAction($searchTerm, $type = 'person') {
         $orcidUserDataService = new OrcidDataService();
-        $methodName = 'search'.ucfirst($type).'Request';
+        $methodName = 'search' . ucfirst($type) . 'Request';
         $result = $orcidUserDataService->{$methodName}($searchTerm);
 
         return json_encode($result);
@@ -413,10 +413,10 @@ 
      */
     public function getOrcidDataAction($dataId, $groupId, $groupIndex, $fieldIndex, $pageId, $type = 'person') {
         $orcidDataService = new OrcidDataService();
-        $methodName = 'get'.ucfirst($type).'Data';
+        $methodName = 'get' . ucfirst($type) . 'Data';
         $orcidData = $orcidDataService->{$methodName}($dataId);
 
-        $result = $this->getApiMappingArray($groupId, $orcidData, $groupIndex, $fieldIndex, $pageId, 'getOrcid'.ucfirst($type).'Mapping');
+        $result = $this->getApiMappingArray($groupId, $orcidData, $groupIndex, $fieldIndex, $pageId, 'getOrcid' . ucfirst($type) . 'Mapping');
 
         return json_encode($result);
     }
@@ -552,7 +552,7 @@ 
     public function generateApiTokenAction($feUser) {
         $currentUser = $this->security->getUser();
         if ($currentUser->getUid() === $feUser) {
-            $string = md5(substr(md5(time()), 0, 14)).date("Y-m-dH:i:s");
+            $string = md5(substr(md5(time()), 0, 14)) . date("Y-m-dH:i:s");
             $hash = hash('sha256', $string);
 
             $currentUser->setApiToken($hash);

Classes/Domain/Model/Document.php

Spacing +10 added lines, -10 removed lines

@@ -354,7 +354,7 @@ 
     public function setObjectIdentifier($objectIdentifier)
     {
         // Due to uniqe key uc_object_identifier, which should ignore empty object identifiers.
-        $this->objectIdentifier = empty($objectIdentifier)? null : $objectIdentifier;
+        $this->objectIdentifier = empty($objectIdentifier) ? null : $objectIdentifier;
     }
 
     /**
@@ -536,14 +536,14 @@ 
 
         $fileId = new \EWW\Dpf\Services\Transfer\FileId($this);
 
-        $files = array();
+        $files = array ();
 
         if (is_a($this->getFile(), '\TYPO3\CMS\Extbase\Persistence\ObjectStorage')) {
             foreach ($this->getFile() as $file) {
 
                 if (!$file->isFileGroupDeleted()) {
 
-                    $tmpFile = array(
+                    $tmpFile = array (
                         'path' => $file->getUrl(),
                         'type' => $file->getContentType(),
                         'title' => (($file->getLabel()) ? $file->getLabel() : $file->getTitle()),
@@ -587,12 +587,12 @@ 
 
         $fileId = new \EWW\Dpf\Services\Transfer\FileId($this);
 
-        $files = array();
+        $files = array ();
 
         if (is_a($this->getFile(), '\TYPO3\CMS\Extbase\Persistence\ObjectStorage')) {
             foreach ($this->getFile() as $file) {
 
-                $tmpFile = array(
+                $tmpFile = array (
                     'path' => $file->getUrl(),
                     'type' => $file->getContentType(),
                     'title' => (($file->getLabel()) ? $file->getLabel() : $file->getTitle()),
@@ -745,7 +745,7 @@ 
      */
     public function getCreator()
     {
-        return $this->creator? $this->creator : 0;
+        return $this->creator ? $this->creator : 0;
     }
 
     /**
@@ -900,7 +900,7 @@ 
 
         foreach ($availableProperties as $propertyName) {
             if (\TYPO3\CMS\Extbase\Reflection\ObjectAccess::isPropertySettable($newDocument, $propertyName)
-                && !in_array($propertyName, array('uid','pid', 'file', 'comment', 'linkedUid', 'suggestion', 'creator'))) {
+                && !in_array($propertyName, array ('uid', 'pid', 'file', 'comment', 'linkedUid', 'suggestion', 'creator'))) {
 
                 $propertyValue = \TYPO3\CMS\Extbase\Reflection\ObjectAccess::getProperty($documentToCopy, $propertyName);
                 \TYPO3\CMS\Extbase\Reflection\ObjectAccess::setProperty($newDocument, $propertyName, $propertyValue);
@@ -922,7 +922,7 @@ 
      */
     public function getDocumentIdentifier()
     {
-        return $this->getObjectIdentifier()? $this->getObjectIdentifier() : $this->getUid();
+        return $this->getObjectIdentifier() ? $this->getObjectIdentifier() : $this->getUid();
     }
 
     /**
@@ -955,8 +955,8 @@ 
     public function getPublicationYear()
     {
         $internalFormat = new \EWW\Dpf\Helper\InternalFormat($this->getXmlData());
-        $year =  $internalFormat->getPublishingYear();
-        return $year? $year : "";
+        $year = $internalFormat->getPublishingYear();
+        return $year ? $year : "";
     }
 
     /*

Classes/Domain/Model/DataCiteMetadata.php

Spacing +1 added lines, -1 removed lines

@@ -47,7 +47,7 @@
                 $name['family'] = $family->item(0)->nodeValue;
             }
 
-            $given =  $xpath->query('givenName', $person);
+            $given = $xpath->query('givenName', $person);
             if ($given->length > 0) {
                 $name['given'] = $given->item(0)->nodeValue;
             }