RisWosFileImporter::loadFile() - Code Metrics - Inspection of "Ap5 ap6 ap1 internal format" - kitodo/kitodo-publication - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#195)

unknown

created 2021-02-10 10:32 UTC

RisWosFileImporter::loadFile() B

↳ Parent: RisWosFileImporter

Complexity

Conditions	10
Paths	76

Size

Total Lines	66
Code Lines	40

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
cc	10
eloc	40
nc	76
nop	3
dl	0
loc	66
rs	7.6666
c	4
b	0
f	0

How to fix Long Method Complexity

<?php

namespace EWW\Dpf\Services\ImportExternalMetadata;

use EWW\Dpf\Domain\Model\RisWosMetadata;
use EWW\Dpf\Domain\Model\ExternalMetadata;

class RisWosFileImporter extends AbstractImporter implements FileImporter
{

    /**
     * @var array
     */
    protected $mandatoryErrors = [];

    /**
     * Returns the list of all publication types
     *
     * @return array
     */
    public static function types()
    {
        return [
            'J' => 'Journal',
            'B' => 'Book',
            'S' => 'Series',
            'P' => 'Patent'
        ];
    }

    /**
     * @param string $filePath
     * @param string $mandatoryFieldSettings
     * @param bool $contentOnly Determines if $file is a path or content as a string
     * @return array
     */
    public function loadFile($filePath, $mandatoryFieldSettings, $contentOnly = false)
    {
        $results = [];
        $mandatoryErrors = [];
        $mandatoryFieldErrors = [];


        $mandatoryFields = array_map(
            'trim',
            explode(',', $mandatoryFieldSettings)
        );

        foreach ($mandatoryFields as $key => $value) {
            $orFields = array_map(
                'trim',
                explode('|', $value)
            );
            $mandatoryFields[$key] = $orFields;
        }

        $risWosReader = new RisReader();

        if ($contentOnly) {
            $risWosEntries = $risWosReader->parseFile($filePath, $contentOnly);
        } else {
            $risWosEntries = $risWosReader->parseFile($filePath);
        }

        foreach ($risWosEntries as $index => $risWosItem) {

            $mandatoryFieldErrors = [];
            foreach ($mandatoryFields as $combinedMandatoryField) {

                $mandatoryOk = false;
                foreach ($combinedMandatoryField as $key => $value) {
                    $mandatoryOk = $mandatoryOk || (
                        array_key_exists($value, $risWosItem)
                        && $risWosItem[$value]
                    );
                }

                if (!$mandatoryOk) {
                    $mandatoryFieldErrors[implode('|', $combinedMandatoryField)] = implode(
                        '|',
                        $combinedMandatoryField
                    );
                    $mandatoryErrors[$index] = [
                        'index' => $index + 1,
                        'title' => $risWosItem['TI'],
                        'fields' => $mandatoryFieldErrors
                    ];
                }
            }

            if (!$mandatoryErrors[$index]) {
                /** @var RisWosMetadata $risWosMetadata */
                $risWosMetadata = $this->objectManager->get(RisWosMetadata::class);
                $risWosMetadata->setSource(get_class($this));
                $risWosMetadata->setFeUser($this->security->getUser()->getUid());
                $risWosMetadata->setData($risWosReader->risRecordToXML($risWosItem));
                $results[] = $risWosMetadata;
            }

        }
        $this->mandatoryErrors = $mandatoryErrors;

        return $results;
    }

    /**
     * @return array
     */
    public function getMandatoryErrors()
    {
        return $this->mandatoryErrors;
    }

    /**
     * @return bool
     */
    public function hasMandatoryErrors()
    {
        return !empty($this->mandatoryErrors);
    }

    /**
     * @return \EWW\Dpf\Domain\Model\TransformationFile|void
     */
    protected function getDefaultXsltTransformation()
    {
        /** @var \EWW\Dpf\Domain\Model\Client $client */
        $client = $this->clientRepository->findAll()->current();

        /** @var \EWW\Dpf\Domain\Model\TransformationFile $xsltTransformationFile */
        return $client->getRisWosTransformation()->current();
    }

    /**
     * @return string|void
     */
    protected function getDefaultXsltFilePath()
    {
        return \TYPO3\CMS\Core\Utility\GeneralUtility::getFileAbsFileName(
            'EXT:dpf/Resources/Private/Xslt/riswos-default.xsl'
        );
    }

    /**
     * @return string|void
     */
    protected function getImporterName()
    {
        return 'riswos';
    }

}

1			<?php
2
3			namespace EWW\Dpf\Services\ImportExternalMetadata;
4
5			use EWW\Dpf\Domain\Model\RisWosMetadata;
6			use EWW\Dpf\Domain\Model\ExternalMetadata;
7
8			class RisWosFileImporter extends AbstractImporter implements FileImporter
9			{
10
11			/**
12			* @var array
13			*/
14			protected $mandatoryErrors = [];
15
16			/**
17			* Returns the list of all publication types
18			*
19			* @return array
20			*/
21			public static function types()
22			{
23			return [
24			'J' => 'Journal',
25			'B' => 'Book',
26			'S' => 'Series',
27			'P' => 'Patent'
28			];
29			}
30
31			/**
32			* @param string $filePath
33			* @param string $mandatoryFieldSettings
34			* @param bool $contentOnly Determines if $file is a path or content as a string
35			* @return array
36			*/
37			public function loadFile($filePath, $mandatoryFieldSettings, $contentOnly = false)
38			{
39			$results = [];
40			$mandatoryErrors = [];
41			$mandatoryFieldErrors = [];
			0 ignored issues – show Unused Code introduced 2021-02-08 09:32 UTC by Report Bug Copy Issue Report The assignment to `$mandatoryFieldErrors` is dead and can be removed. Loading history...
42
43			$mandatoryFields = array_map(
44			'trim',
45			explode(',', $mandatoryFieldSettings)
46			);
47
48			foreach ($mandatoryFields as $key => $value) {
49			$orFields = array_map(
50			'trim',
51			explode('\|', $value)
52			);
53			$mandatoryFields[$key] = $orFields;
54			}
55
56			$risWosReader = new RisReader();
57
58			if ($contentOnly) {
59			$risWosEntries = $risWosReader->parseFile($filePath, $contentOnly);
60			} else {
61			$risWosEntries = $risWosReader->parseFile($filePath);
62			}
63
64			foreach ($risWosEntries as $index => $risWosItem) {
65
66			$mandatoryFieldErrors = [];
67			foreach ($mandatoryFields as $combinedMandatoryField) {
68
69			$mandatoryOk = false;
70			foreach ($combinedMandatoryField as $key => $value) {
71			$mandatoryOk = $mandatoryOk \|\| (
72			array_key_exists($value, $risWosItem)
73			&& $risWosItem[$value]
74			);
75			}
76
77			if (!$mandatoryOk) {
78			$mandatoryFieldErrors[implode('\|', $combinedMandatoryField)] = implode(
79			'\|',
80			$combinedMandatoryField
81			);
82			$mandatoryErrors[$index] = [
83			'index' => $index + 1,
84			'title' => $risWosItem['TI'],
85			'fields' => $mandatoryFieldErrors
86			];
87			}
88			}
89
90			if (!$mandatoryErrors[$index]) {
91			/** @var RisWosMetadata $risWosMetadata */
92			$risWosMetadata = $this->objectManager->get(RisWosMetadata::class);
93			$risWosMetadata->setSource(get_class($this));
94			$risWosMetadata->setFeUser($this->security->getUser()->getUid());
95			$risWosMetadata->setData($risWosReader->risRecordToXML($risWosItem));
96			$results[] = $risWosMetadata;
97			}
98
99			}
100			$this->mandatoryErrors = $mandatoryErrors;
101
102			return $results;
103			}
104
105			/**
106			* @return array
107			*/
108			public function getMandatoryErrors()
109			{
110			return $this->mandatoryErrors;
111			}
112
113			/**
114			* @return bool
115			*/
116			public function hasMandatoryErrors()
117			{
118			return !empty($this->mandatoryErrors);
119			}
120
121			/**
122			* @return \EWW\Dpf\Domain\Model\TransformationFile\|void
123			*/
124			protected function getDefaultXsltTransformation()
125			{
126			/** @var \EWW\Dpf\Domain\Model\Client $client */
127			$client = $this->clientRepository->findAll()->current();
128
129			/** @var \EWW\Dpf\Domain\Model\TransformationFile $xsltTransformationFile */
130			return $client->getRisWosTransformation()->current();
131			}
132
133			/**
134			* @return string\|void
135			*/
136			protected function getDefaultXsltFilePath()
137			{
138			return \TYPO3\CMS\Core\Utility\GeneralUtility::getFileAbsFileName(
139			'EXT:dpf/Resources/Private/Xslt/riswos-default.xsl'
140			);
141			}
142
143			/**
144			* @return string\|void
145			*/
146			protected function getImporterName()
147			{
148			return 'riswos';
149			}
150
151			}

kitodo / kitodo-publication

Pull Request — master (#195)

RisWosFileImporter::loadFile() B

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like