View GitHub Repository kitodo-publication

Schedule Inspection
Subscribe
Passed
Push — master ( e51dd6...1991ec )
by Ralf
12:21
created
Status
Category
Toggle Patches
Classes/Helper/DocumentMapper.php 1 patch
Upper-Lower-Casing   +11 added lines, -11 removed lines patch added patch discarded remove patch 
@@ -44,7 +44,7 @@  discard block
 
 block discarded – undo
44 44 
      * @var \EWW\Dpf\Domain\Repository\MetadataGroupRepository
45 45 
      * @TYPO3\CMS\Extbase\Annotation\Inject
46 46 
      */
47 
-    protected $metadataGroupRepository = null;
47 
+    protected $metadataGroupRepository = NULL;
48 48
49 49 
     /**
50 50 
      * metadataObjectRepository
 
@@ -52,7 +52,7 @@  discard block
 
 block discarded – undo
52 52 
      * @var \EWW\Dpf\Domain\Repository\MetadataObjectRepository
53 53 
      * @TYPO3\CMS\Extbase\Annotation\Inject
54 54 
      */
55 
-    protected $metadataObjectRepository = null;
55 
+    protected $metadataObjectRepository = NULL;
56 56
57 57 
     /**
58 58 
      * documentTypeRepository
 
@@ -60,7 +60,7 @@  discard block
 
 block discarded – undo
60 60 
      * @var \EWW\Dpf\Domain\Repository\DocumentTypeRepository
61 61 
      * @TYPO3\CMS\Extbase\Annotation\Inject
62 62 
      */
63 
-    protected $documentTypeRepository = null;
63 
+    protected $documentTypeRepository = NULL;
64 64
65 65 
     /**
66 66 
      * documentRepository
 
@@ -68,7 +68,7 @@  discard block
 
 block discarded – undo
68 68 
      * @var \EWW\Dpf\Domain\Repository\DocumentRepository
69 69 
      * @TYPO3\CMS\Extbase\Annotation\Inject
70 70 
      */
71 
-    protected $documentRepository = null;
71 
+    protected $documentRepository = NULL;
72 72
73 73 
     /**
74 74 
      * fileRepository
 
@@ -76,7 +76,7 @@  discard block
 
 block discarded – undo
76 76 
      * @var \EWW\Dpf\Domain\Repository\FileRepository
77 77 
      * @TYPO3\CMS\Extbase\Annotation\Inject
78 78 
      */
79 
-    protected $fileRepository = null;
79 
+    protected $fileRepository = NULL;
80 80
81 81 
     /**
82 82 
      * depositLicenseRepository
 
@@ -84,7 +84,7 @@  discard block
 
 block discarded – undo
84 84 
      * @var \EWW\Dpf\Domain\Repository\DepositLicenseRepository
85 85 
      * @TYPO3\CMS\Extbase\Annotation\Inject
86 86 
      */
87 
-    protected $depositLicenseRepository = null;
87 
+    protected $depositLicenseRepository = NULL;
88 88
89 89 
     /**
90 90 
      * Get typoscript settings
 
@@ -106,7 +106,7 @@  discard block
 
 block discarded – undo
106 106 
      * @param bool $generateEmptyFields
107 107 
      * @return \EWW\Dpf\Domain\Model\DocumentForm
108 108 
      */
109 
-    public function getDocumentForm(Document $document, $generateEmptyFields = true)
109 
+    public function getDocumentForm(Document $document, $generateEmptyFields = TRUE)
110 110 
     {
111 111 
         $documentForm = new \EWW\Dpf\Domain\Model\DocumentForm();
112 112 
         $documentForm->generateCsrfToken();
 
@@ -120,7 +120,7 @@  discard block
 
 block discarded – undo
120 120 
                 (
121 121 
                     $this->getSettings()['deactivatePrimaryFileMandatoryCheck'] ||
122 122 
                     $document->getDocumentType()->getVirtualType()
123 
-                )? false : true
123 
+                )? FALSE : TRUE
124 124 
             )
125 125 
         );
126 126 
 
@@ -183,7 +183,7 @@  discard block
 
 block discarded – undo
183 183 
                 // build mapping path, previous fixed attributes which are differ from
184 184 
                 // the own fixed attributes are excluded
185 185 
                 $queryGroupMapping = $metadataGroup->getAbsoluteMapping();
186 
-                if (strpos($queryGroupMapping, "@displayLabel") === false && is_array($excludeGroupAttributes[$groupMappingName])) {
186 
+                if (strpos($queryGroupMapping, "@displayLabel") === FALSE && is_array($excludeGroupAttributes[$groupMappingName])) {
187 187 
                     foreach ($excludeGroupAttributes[$groupMappingName] as $excludeAttr => $excludeAttrValue) {
188 188 
                         if (!in_array($excludeAttr, $fixedGroupAttributes)) {
189 189 
                             $queryGroupMapping .= $excludeAttrValue;
 
@@ -241,7 +241,7 @@  discard block
 
 block discarded – undo
241 241
242 242 
                                 // ensure that e.g. <mods:detail> and <mods:detail type="volume">
243 243 
                                 // are not recognized as the same node
244 
-                                if ((strpos($value, "@") === false) && ($value != '.')) {
244 
+                                if ((strpos($value, "@") === FALSE) && ($value != '.')) {
245 245 
                                     $objectMappingPath[$key] .= "[not(@*)]";
246 246 
                                 }
247 247 
                             }
 
@@ -298,7 +298,7 @@  discard block
 
 block discarded – undo
298 298 
                     }
299 299 
                 } else {
300 300
301 
-                    $documentFormGroup->setEmptyGroup(true);
301 
+                    $documentFormGroup->setEmptyGroup(TRUE);
302 302
303 303 
                     foreach ($metadataGroup->getMetadataObject() as $metadataObject) {
304 304 
                         $documentFormField = new \EWW\Dpf\Domain\Model\DocumentFormField();
Please login to merge, or discard this patch.