kitodo / kitodo-publication

Classes/Domain/Repository/BookmarkRepository.php

Braces +4 added lines, -8 removed lines

@@ -22,15 +22,13 @@ 
 /**
  * The repository for Bookmarks
  */
-class BookmarkRepository extends \EWW\Dpf\Domain\Repository\AbstractRepository
-{
+class BookmarkRepository extends \EWW\Dpf\Domain\Repository\AbstractRepository {
     /**
      * @param int $feUserUid
      * @param string $identifier
      * @return object
      */
-    public function findBookmark($feUserUid, $identifier)
-    {
+    public function findBookmark($feUserUid, $identifier) {
         $query = $this->createQuery();
 
         $query->matching(
@@ -49,8 +47,7 @@ 
      * @return bool
      * @throws \TYPO3\CMS\Extbase\Persistence\Exception\IllegalObjectTypeException
      */
-    public function removeBookmark($document, $feUserUid)
-    {
+    public function removeBookmark($document, $feUserUid) {
         $query = $this->createQuery();
 
         if ($document instanceof Document) {
@@ -82,8 +79,7 @@ 
      * @return bool
      * @throws \TYPO3\CMS\Extbase\Persistence\Exception\IllegalObjectTypeException
      */
-    public function addBookmark($feUserUid, Document $document)
-    {
+    public function addBookmark($feUserUid, Document $document) {
         $identifier = $document->getDocumentIdentifier();
 
         $bookmark = $this->findBookmark($feUserUid, $identifier);

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -92,10 +92,10 @@
             $bookmark->setDocumentIdentifier($identifier);
             $bookmark->setFeUserUid($feUserUid);
             $this->add($bookmark);
-            return true;
+            return TRUE;
         }
 
-        return false;
+        return FALSE;
     }
 
 }

Classes/Domain/Repository/DocumentRepository.php

Spacing +14 added lines, -14 removed lines

@@ -44,7 +44,7 @@ 
             case Security::ROLE_RESEARCHER:
                 $query->matching(
                     $query->logicalAnd(
-                        array(
+                        array (
                             $query->equals('suggestion', true),
                             $query->equals('creator', $creatorUid)
                         )
@@ -63,7 +63,7 @@ 
     {
         $query = $this->createQuery();
 
-        $constraints = array(
+        $constraints = array (
             $query->logicalNot($query->equals('object_identifier', '')),
             $query->logicalNot($query->equals('object_identifier', NULL)));
 
@@ -81,7 +81,7 @@ 
 
         $result = $query->execute();
 
-        $objectIdentifiers = array();
+        $objectIdentifiers = array ();
 
         foreach ($result as $document) {
             $objectIdentifiers[$document->getObjectIdentifier()] = $document->getObjectIdentifier();
@@ -101,9 +101,9 @@ 
         $query = $this->createQuery();
         $query->getQuerySettings()->setRespectStoragePage(FALSE);
 
-        $constraints = array();
-        $constraints[] =  $query->equals('process_number', '');
-        $constraints[] =  $query->equals('process_number', NULL);
+        $constraints = array ();
+        $constraints[] = $query->equals('process_number', '');
+        $constraints[] = $query->equals('process_number', NULL);
 
         if (count($constraints)) {
             $query->matching(
@@ -127,10 +127,10 @@ 
     {
         $query = $this->createQuery();
 
-        $dateTimeObj= new \DateTime();
-        $dateTimeObj->sub(new \DateInterval("PT".$timeout."S"));
+        $dateTimeObj = new \DateTime();
+        $dateTimeObj->sub(new \DateInterval("PT" . $timeout . "S"));
 
-        $constraints = array();
+        $constraints = array ();
         $constraints[] = $query->lessThan('tstamp', $dateTimeObj->getTimestamp());
 
         $query->matching(
@@ -153,10 +153,10 @@ 
     {
         $query = $this->createQuery();
 
-        $dateTimeObj= new \DateTime();
-        $dateTimeObj->sub(new \DateInterval("PT".$timeout."S"));
+        $dateTimeObj = new \DateTime();
+        $dateTimeObj->sub(new \DateInterval("PT" . $timeout . "S"));
 
-        $constraints = array();
+        $constraints = array ();
         $constraints[] = $query->lessThan('tstamp', $dateTimeObj->getTimestamp());
 
         $query->matching(
@@ -178,7 +178,7 @@ 
     {
         $query = $this->createQuery();
 
-        $constraints = array(
+        $constraints = array (
             $query->equals('object_identifier', $objectIdentifier),
             $query->logicalNot($query->equals('temporary', TRUE)),
             $query->logicalNot($query->equals('suggestion', TRUE))
@@ -276,7 +276,7 @@ 
     {
 
         $query = $this->createQuery();
-        $query->statement( "update tx_dpf_domain_model_document set creator = owner");
+        $query->statement("update tx_dpf_domain_model_document set creator = owner");
         $query->execute();
 
     }

Braces +10 added lines, -20 removed lines

@@ -21,8 +21,7 @@ 
 /**
  * The repository for Documents
  */
-class DocumentRepository extends \EWW\Dpf\Domain\Repository\AbstractRepository
-{
+class DocumentRepository extends \EWW\Dpf\Domain\Repository\AbstractRepository {
     /**
      * Finds all suggestion documents of the given user role filtered by creator feuser uid
      *
@@ -59,8 +58,7 @@ 
      * @param boolean $temporary
      * @return array
      */
-    public function getObjectIdentifiers($temporary = FALSE)
-    {
+    public function getObjectIdentifiers($temporary = FALSE) {
         $query = $this->createQuery();
 
         $constraints = array(
@@ -96,8 +94,7 @@ 
      *
      * @return array The found Document Objects
      */
-    public function findDocumentsWithoutProcessNumber()
-    {
+    public function findDocumentsWithoutProcessNumber() {
         $query = $this->createQuery();
         $query->getQuerySettings()->setRespectStoragePage(FALSE);
 
@@ -123,8 +120,7 @@ 
      * @param integer $timeout : Time interval (in seconds) in which documents are not outdated.
      * @return array The found Document Objects
      */
-    public function findOutdatedTemporaryDocuments($timeout = 3600)
-    {
+    public function findOutdatedTemporaryDocuments($timeout = 3600) {
         $query = $this->createQuery();
 
         $dateTimeObj= new \DateTime();
@@ -149,8 +145,7 @@ 
      * @param integer $timeout : Time interval (in seconds) in which documents are not outdated.
      * @return array The found Document Objects
      */
-    public function findOutdatedLockedDocuments($timeout = 3600)
-    {
+    public function findOutdatedLockedDocuments($timeout = 3600) {
         $query = $this->createQuery();
 
         $dateTimeObj= new \DateTime();
@@ -174,8 +169,7 @@ 
      * @param string $objectIdentifier
      * @return array
      */
-    public function findWorkingCopyByObjectIdentifier($objectIdentifier)
-    {
+    public function findWorkingCopyByObjectIdentifier($objectIdentifier) {
         $query = $this->createQuery();
 
         $constraints = array(
@@ -193,8 +187,7 @@ 
      * @param string $identifier
      * @return Document
      */
-    public function findByIdentifier($identifier)
-    {
+    public function findByIdentifier($identifier) {
         $query = $this->createQuery();
 
         if (is_numeric($identifier)) {
@@ -218,8 +211,7 @@ 
      * @param bool $includeSuggestion
      * @return Document
      */
-    public function findWorkingCopy($identifier, $includeTemporary = false, $includeSuggestion = false)
-    {
+    public function findWorkingCopy($identifier, $includeTemporary = false, $includeSuggestion = false) {
         $query = $this->createQuery();
 
         if (is_numeric($identifier)) {
@@ -245,8 +237,7 @@ 
      * @param object $modifiedObject The modified object
      * @throws \Exception
      */
-    public function update($modifiedObject)
-    {
+    public function update($modifiedObject) {
         /** @var Document $document */
         $document = $modifiedObject;
 
@@ -272,8 +263,7 @@ 
 
 
 
-    public function updateCreator()
-    {
+    public function updateCreator() {
 
         $query = $this->createQuery();
         $query->statement( "update tx_dpf_domain_model_document set creator = owner");

Upper-Lower-Casing +5 added lines, -5 removed lines

@@ -37,7 +37,7 @@ 
 
             case Security::ROLE_LIBRARIAN:
                 $query->matching(
-                    $query->equals('suggestion', true)
+                    $query->equals('suggestion', TRUE)
                 );
                 break;
 
@@ -45,7 +45,7 @@ 
                 $query->matching(
                     $query->logicalAnd(
                         array(
-                            $query->equals('suggestion', true),
+                            $query->equals('suggestion', TRUE),
                             $query->equals('creator', $creatorUid)
                         )
                     )
@@ -218,7 +218,7 @@ 
      * @param bool $includeSuggestion
      * @return Document
      */
-    public function findWorkingCopy($identifier, $includeTemporary = false, $includeSuggestion = false)
+    public function findWorkingCopy($identifier, $includeTemporary = FALSE, $includeSuggestion = FALSE)
     {
         $query = $this->createQuery();
 
@@ -253,8 +253,8 @@ 
         if (trim($document->getObjectIdentifier()) && !$document->isTemporary() && !$document->isSuggestion()) {
             $query = $this->createQuery();
             $constraints[] = $query->equals('object_identifier', trim($document->getObjectIdentifier()));
-            $constraints[] = $query->equals('temporary', false);
-            $constraints[] = $query->equals('suggestion', false);
+            $constraints[] = $query->equals('temporary', FALSE);
+            $constraints[] = $query->equals('suggestion', FALSE);
             $query->matching($query->logicalAnd($constraints));
 
             /** @var Document $workingCopy */

Classes/Domain/Repository/EditingLockRepository.php

Spacing +2 added lines, -2 removed lines

@@ -29,8 +29,8 @@
     {
         $query = $this->createQuery();
 
-        $dateTimeObj= new \DateTime();
-        $dateTimeObj->sub(new \DateInterval("PT".$timeout."S"));
+        $dateTimeObj = new \DateTime();
+        $dateTimeObj->sub(new \DateInterval("PT" . $timeout . "S"));
 
         $query->matching(
             $query->lessThan('tstamp', $dateTimeObj->getTimestamp())

Braces +2 added lines, -4 removed lines

@@ -17,16 +17,14 @@
 /**
  * The repository for editing lock objects
  */
-class EditingLockRepository extends \EWW\Dpf\Domain\Repository\AbstractRepository
-{
+class EditingLockRepository extends \EWW\Dpf\Domain\Repository\AbstractRepository {
     /**
      * Finds all outdated locks,
      *
      * @param integer $timeout : Time interval (in seconds) in which locks are not outdated.
      * @return array The found Document Objects
      */
-    public function findOutdatedLocks($timeout)
-    {
+    public function findOutdatedLocks($timeout) {
         $query = $this->createQuery();
 
         $dateTimeObj= new \DateTime();

Classes/Domain/Model/EditingLock.php

Braces +5 added lines, -10 removed lines

@@ -21,8 +21,7 @@ 
  *
  * @package EWW\Dpf\Domain\Model
  */
-class EditingLock extends \TYPO3\CMS\Extbase\DomainObject\AbstractEntity
-{
+class EditingLock extends \TYPO3\CMS\Extbase\DomainObject\AbstractEntity {
     /**
      * documentIdentifier : A document uid or a qucosa object identifier.
      *
@@ -42,8 +41,7 @@ 
      *
      * @return int
      */
-    public function getDocumentIdentifier()
-    {
+    public function getDocumentIdentifier() {
         return $this->documentIdentifier;
     }
 
@@ -52,8 +50,7 @@ 
      *
      * @param int $documentIdentifier
      */
-    public function setDocumentIdentifier($documentIdentifier)
-    {
+    public function setDocumentIdentifier($documentIdentifier) {
         $this->documentIdentifier = $documentIdentifier;
     }
 
@@ -62,8 +59,7 @@ 
      *
      * @return int
      */
-    public function getEditorUid()
-    {
+    public function getEditorUid() {
         return $this->editorUid;
     }
 
@@ -72,8 +68,7 @@ 
      *
      * @param int $editorUid
      */
-    public function setEditorUid($editorUid)
-    {
+    public function setEditorUid($editorUid) {
         $this->editorUid = $editorUid;
     }
 

Classes/Domain/Model/Bookmark.php

Braces +5 added lines, -10 removed lines

@@ -20,8 +20,7 @@ 
  *
  * @package EWW\Dpf\Domain\Model
  */
-class Bookmark extends \TYPO3\CMS\Extbase\DomainObject\AbstractEntity
-{
+class Bookmark extends \TYPO3\CMS\Extbase\DomainObject\AbstractEntity {
     /**
      * documentIdentifier : A document uid or a qucosa object identifier.
      *
@@ -41,8 +40,7 @@ 
      *
      * @return int
      */
-    public function getDocumentIdentifier()
-    {
+    public function getDocumentIdentifier() {
         return $this->documentIdentifier;
     }
 
@@ -51,8 +49,7 @@ 
      *
      * @param int $documentIdentifier
      */
-    public function setDocumentIdentifier($documentIdentifier)
-    {
+    public function setDocumentIdentifier($documentIdentifier) {
         $this->documentIdentifier = $documentIdentifier;
     }
 
@@ -61,8 +58,7 @@ 
      *
      * @return int
      */
-    public function getFeUserUid()
-    {
+    public function getFeUserUid() {
         return $this->feUserUid;
     }
 
@@ -71,8 +67,7 @@ 
      *
      * @param int $feUserUid
      */
-    public function setFeUserUid($feUserUid)
-    {
+    public function setFeUserUid($feUserUid) {
         $this->feUserUid = $feUserUid;
     }
 

Classes/Domain/Model/Document.php

Spacing +12 added lines, -12 removed lines

@@ -317,7 +317,7 @@ 
     public function setObjectIdentifier($objectIdentifier)
     {
         // Due to uniqe key uc_object_identifier, which should ignore empty object identifiers.
-        $this->objectIdentifier = empty($objectIdentifier)? null : $objectIdentifier;
+        $this->objectIdentifier = empty($objectIdentifier) ? null : $objectIdentifier;
     }
 
     /**
@@ -499,14 +499,14 @@ 
 
         $fileId = new \EWW\Dpf\Services\Transfer\FileId($this);
 
-        $files = array();
+        $files = array ();
 
         if (is_a($this->getFile(), '\TYPO3\CMS\Extbase\Persistence\ObjectStorage')) {
             foreach ($this->getFile() as $file) {
 
                 if (!$file->isFileGroupDeleted()) {
 
-                    $tmpFile = array(
+                    $tmpFile = array (
                         'path' => $file->getLink(),
                         'type' => $file->getContentType(),
                         'title' => (($file->getLabel()) ? $file->getLabel() : $file->getTitle()),
@@ -550,12 +550,12 @@ 
 
         $fileId = new \EWW\Dpf\Services\Transfer\FileId($this);
 
-        $files = array();
+        $files = array ();
 
         if (is_a($this->getFile(), '\TYPO3\CMS\Extbase\Persistence\ObjectStorage')) {
             foreach ($this->getFile() as $file) {
 
-                $tmpFile = array(
+                $tmpFile = array (
                     'path' => $file->getLink(),
                     'type' => $file->getContentType(),
                     'title' => (($file->getLabel()) ? $file->getLabel() : $file->getTitle()),
@@ -708,7 +708,7 @@ 
      */
     public function getCreator()
     {
-        return $this->creator? $this->creator : 0;
+        return $this->creator ? $this->creator : 0;
     }
 
     /**
@@ -854,7 +854,7 @@ 
 
         foreach ($availableProperties as $propertyName) {
             if (\TYPO3\CMS\Extbase\Reflection\ObjectAccess::isPropertySettable($newDocument, $propertyName)
-                && !in_array($propertyName, array('uid','pid', 'file', 'comment', 'linkedUid', 'suggestion', 'creator'))) {
+                && !in_array($propertyName, array ('uid', 'pid', 'file', 'comment', 'linkedUid', 'suggestion', 'creator'))) {
 
                 $propertyValue = \TYPO3\CMS\Extbase\Reflection\ObjectAccess::getProperty($documentToCopy, $propertyName);
                 \TYPO3\CMS\Extbase\Reflection\ObjectAccess::setProperty($newDocument, $propertyName, $propertyValue);
@@ -876,7 +876,7 @@ 
      */
     public function getDocumentIdentifier()
     {
-        return $this->getObjectIdentifier()? $this->getObjectIdentifier() : $this->getUid();
+        return $this->getObjectIdentifier() ? $this->getObjectIdentifier() : $this->getUid();
     }
 
     /**
@@ -909,8 +909,8 @@ 
     public function getPublicationYear()
     {
         $mods = new Mods($this->getXmlData());
-        $year =  $mods->getPublishingYear();
-        return $year? $year : "";
+        $year = $mods->getPublishingYear();
+        return $year ? $year : "";
     }
 
     /**
@@ -922,7 +922,7 @@ 
     {
         $mods = new Mods($this->getXmlData());
         $title = $mods->getTitle();
-        return $title? $title : "";
+        return $title ? $title : "";
     }
 
 
@@ -935,7 +935,7 @@ 
     {
         if (array_key_exists($this->getState(), DocumentWorkflow::STATE_TO_SIMPLESTATE_MAPPING)) {
             return \TYPO3\CMS\Extbase\Utility\LocalizationUtility::translate(
-                "manager.documentList.state.".DocumentWorkflow::STATE_TO_SIMPLESTATE_MAPPING[$this->getState()],
+                "manager.documentList.state." . DocumentWorkflow::STATE_TO_SIMPLESTATE_MAPPING[$this->getState()],
                 'dpf',
                 $arguments = null
             );

Braces +60 added lines, -120 removed lines

@@ -20,8 +20,7 @@ 
 /**
  * Document
  */
-class Document extends \TYPO3\CMS\Extbase\DomainObject\AbstractEntity
-{
+class Document extends \TYPO3\CMS\Extbase\DomainObject\AbstractEntity {
     /**
      * title
      *
@@ -176,8 +175,7 @@ 
     /**
      * __construct
      */
-    public function __construct()
-    {
+    public function __construct() {
         //Do not remove the next line: It would break the functionality
         $this->initStorageObjects();
     }
@@ -187,8 +185,7 @@ 
      *
      * @return void
      */
-    protected function initStorageObjects()
-    {
+    protected function initStorageObjects() {
         $this->file = new \TYPO3\CMS\Extbase\Persistence\ObjectStorage();
     }
 
@@ -197,8 +194,7 @@ 
      *
      * @return string $title
      */
-    public function getTitle()
-    {
+    public function getTitle() {
         return $this->title;
     }
 
@@ -208,8 +204,7 @@ 
      * @param string $title
      * @return void
      */
-    public function setTitle($title)
-    {
+    public function setTitle($title) {
         $this->title = $title;
         //htmlspecialchars_decode($title,ENT_QUOTES);
     }
@@ -219,8 +214,7 @@ 
      *
      * @return array $authors
      */
-    public function getAuthors()
-    {
+    public function getAuthors() {
         return array_map('trim', explode(";", $this->authors));
     }
 
@@ -230,8 +224,7 @@ 
      * @param array $authors
      * @return void
      */
-    public function setAuthors($authors)
-    {
+    public function setAuthors($authors) {
         $authors = implode("; ", $authors);
         $this->authors = $authors;
     }
@@ -241,8 +234,7 @@ 
      *
      * @return string $xmlData
      */
-    public function getXmlData()
-    {
+    public function getXmlData() {
         return $this->xmlData;
     }
 
@@ -252,8 +244,7 @@ 
      * @param string $xmlData
      * @return void
      */
-    public function setXmlData($xmlData)
-    {
+    public function setXmlData($xmlData) {
         $this->xmlData = $xmlData;
     }
 
@@ -262,8 +253,7 @@ 
      *
      * @return string $slubInfoData
      */
-    public function getSlubInfoData()
-    {
+    public function getSlubInfoData() {
         return $this->slubInfoData;
     }
 
@@ -272,8 +262,7 @@ 
      *
      * @return string $slubInfoData
      */
-    public function setSlubInfoData($slubInfoData)
-    {
+    public function setSlubInfoData($slubInfoData) {
         $this->slubInfoData = $slubInfoData;
     }
 
@@ -282,8 +271,7 @@ 
      *
      * @return \EWW\Dpf\Domain\Model\DocumentType $documentType
      */
-    public function getDocumentType()
-    {
+    public function getDocumentType() {
         return $this->documentType;
     }
 
@@ -293,8 +281,7 @@ 
      * @param \EWW\Dpf\Domain\Model\DocumentType $documentType
      * @return void
      */
-    public function setDocumentType(\EWW\Dpf\Domain\Model\DocumentType $documentType)
-    {
+    public function setDocumentType(\EWW\Dpf\Domain\Model\DocumentType $documentType) {
         $this->documentType = $documentType;
     }
 
@@ -303,8 +290,7 @@ 
      *
      * @return string
      */
-    public function getObjectIdentifier()
-    {
+    public function getObjectIdentifier() {
         return $this->objectIdentifier;
     }
 
@@ -314,8 +300,7 @@ 
      * @param string $objectIdentifier
      * @return void
      */
-    public function setObjectIdentifier($objectIdentifier)
-    {
+    public function setObjectIdentifier($objectIdentifier) {
         // Due to uniqe key uc_object_identifier, which should ignore empty object identifiers.
         $this->objectIdentifier = empty($objectIdentifier)? null : $objectIdentifier;
     }
@@ -325,8 +310,7 @@ 
      *
      * @return string
      */
-    public function getReservedObjectIdentifier()
-    {
+    public function getReservedObjectIdentifier() {
         return $this->reservedObjectIdentifier;
     }
 
@@ -336,8 +320,7 @@ 
      * @param string $reservedObjectIdentifier
      * @return void
      */
-    public function setReservedObjectIdentifier($reservedObjectIdentifier)
-    {
+    public function setReservedObjectIdentifier($reservedObjectIdentifier) {
         $this->reservedObjectIdentifier = $reservedObjectIdentifier;
     }
 
@@ -346,8 +329,7 @@ 
      *
      * @return string
      */
-    public function getTransferStatus()
-    {
+    public function getTransferStatus() {
         return $this->transferStatus;
     }
 
@@ -357,8 +339,7 @@ 
      * @param string
      * @return void
      */
-    public function setTransferStatus($transferStatus)
-    {
+    public function setTransferStatus($transferStatus) {
         $this->transferStatus = $transferStatus;
     }
 
@@ -367,8 +348,7 @@ 
      *
      * @return integer
      */
-    public function getTransferDate()
-    {
+    public function getTransferDate() {
         return $this->transferDate;
     }
 
@@ -378,8 +358,7 @@ 
      * @param integer $transferDate
      * @return void
      */
-    public function setTransferDate($transferDate)
-    {
+    public function setTransferDate($transferDate) {
         $this->transferDate = $transferDate;
     }
 
@@ -388,8 +367,7 @@ 
      *
      * @var integer
      */
-    public function getTransferErrorCode()
-    {
+    public function getTransferErrorCode() {
         return $this->transferErrorCode;
     }
 
@@ -399,8 +377,7 @@ 
      * @param integer $transferErrorCode
      * @return void
      */
-    public function setTransferErrorCode($transferErrorCode)
-    {
+    public function setTransferErrorCode($transferErrorCode) {
         $this->transferErrorCode = $transferErrorCode;
     }
 
@@ -409,8 +386,7 @@ 
      *
      * @var string
      */
-    public function getTransferResponse()
-    {
+    public function getTransferResponse() {
         return $this->transferResponse;
     }
 
@@ -420,8 +396,7 @@ 
      * @param string $transferResponse
      * @return void
      */
-    public function setTransferResponse($transferResponse)
-    {
+    public function setTransferResponse($transferResponse) {
         $this->transferResponse = $transferResponse;
     }
 
@@ -430,8 +405,7 @@ 
      *
      * @var integer
      */
-    public function getTransferHttpStatus()
-    {
+    public function getTransferHttpStatus() {
         return $this->transferHttpStatus;
     }
 
@@ -441,8 +415,7 @@ 
      * @param integer $transferHttpStatus
      * @return void
      */
-    public function setTransferHttpStatus($transferHttpStatus)
-    {
+    public function setTransferHttpStatus($transferHttpStatus) {
         $this->transferHttpStatus = $transferHttpStatus;
     }
 
@@ -452,8 +425,7 @@ 
      * @param \EWW\Dpf\Domain\Model\File $file
      * @return void
      */
-    public function addFile(\EWW\Dpf\Domain\Model\File $file)
-    {
+    public function addFile(\EWW\Dpf\Domain\Model\File $file) {
         $this->file->attach($file);
     }
 
@@ -463,8 +435,7 @@ 
      * @param \EWW\Dpf\Domain\Model\File $fileToRemove The File to be removed
      * @return void
      */
-    public function removeFile(\EWW\Dpf\Domain\Model\File $fileToRemove)
-    {
+    public function removeFile(\EWW\Dpf\Domain\Model\File $fileToRemove) {
         $this->file->detach($fileToRemove);
     }
 
@@ -473,8 +444,7 @@ 
      *
      * @return \TYPO3\CMS\Extbase\Persistence\ObjectStorage<\EWW\Dpf\Domain\Model\File> $file
      */
-    public function getFile()
-    {
+    public function getFile() {
         return $this->file;
     }
 
@@ -484,8 +454,7 @@ 
      * @param \TYPO3\CMS\Extbase\Persistence\ObjectStorage<\EWW\Dpf\Domain\Model\File> $file
      * @return void
      */
-    public function setFile(\TYPO3\CMS\Extbase\Persistence\ObjectStorage $file)
-    {
+    public function setFile(\TYPO3\CMS\Extbase\Persistence\ObjectStorage $file) {
         $this->file = $file;
     }
 
@@ -494,8 +463,7 @@ 
      *
      * @return array
      */
-    public function getFileData()
-    {
+    public function getFileData() {
 
         $fileId = new \EWW\Dpf\Services\Transfer\FileId($this);
 
@@ -545,8 +513,7 @@ 
      *
      * @return array
      */
-    public function getCurrentFileData()
-    {
+    public function getCurrentFileData() {
 
         $fileId = new \EWW\Dpf\Services\Transfer\FileId($this);
 
@@ -594,8 +561,7 @@ 
      *
      * @return boolean $changed
      */
-    public function getChanged()
-    {
+    public function getChanged() {
         return $this->changed;
     }
 
@@ -605,8 +571,7 @@ 
      * @param boolean $changed
      * @return void
      */
-    public function setChanged($changed)
-    {
+    public function setChanged($changed) {
         $this->changed = $changed;
     }
 
@@ -615,8 +580,7 @@ 
      *
      * @return boolean $valid
      */
-    public function getValid()
-    {
+    public function getValid() {
         return $this->valid;
     }
 
@@ -626,8 +590,7 @@ 
      * @param boolean $valid
      * @return void
      */
-    public function setValid($valid)
-    {
+    public function setValid($valid) {
         $this->valid = $valid;
     }
 
@@ -636,8 +599,7 @@ 
      *
      * @return string
      */
-    public function getDateIssued()
-    {
+    public function getDateIssued() {
         return empty($this->dateIssued) ? '' : $this->dateIssued;
     }
 
@@ -647,8 +609,7 @@ 
      * @param string $dateIssued
      * @return void
      */
-    public function setDateIssued($dateIssued)
-    {
+    public function setDateIssued($dateIssued) {
         $this->dateIssued = empty($dateIssued) ? '' : $dateIssued;
     }
 
@@ -658,8 +619,7 @@ 
      *
      * @return string
      */
-    public function getProcessNumber()
-    {
+    public function getProcessNumber() {
         return $this->processNumber;
     }
 
@@ -669,8 +629,7 @@ 
      * @param string $processNumber
      * @return void
      */
-    public function setProcessNumber($processNumber)
-    {
+    public function setProcessNumber($processNumber) {
         $this->processNumber = trim($processNumber);
     }
 
@@ -680,8 +639,7 @@ 
      *
      * @return string
      */
-    public function getSubmitterName()
-    {
+    public function getSubmitterName() {
         try {
             $slub = new \EWW\Dpf\Helper\Slub($this->getSlubInfoData());
             return $slub->getSubmitterName();
@@ -695,8 +653,7 @@ 
      *
      * @return string
      */
-    public function getQucosaUrn()
-    {
+    public function getQucosaUrn() {
         $mods = new \EWW\Dpf\Helper\Mods($this->getXmlData());
         return $mods->getQucosaUrn();
     }
@@ -706,8 +663,7 @@ 
      *
      * @return int
      */
-    public function getCreator()
-    {
+    public function getCreator() {
         return $this->creator? $this->creator : 0;
     }
 
@@ -717,23 +673,19 @@ 
      * @param int $creator
      * @return void
      */
-    public function setCreator($creator)
-    {
+    public function setCreator($creator) {
         $this->creator = $creator;
     }
 
-    public function getState()
-    {
+    public function getState() {
         return $this->state;
     }
 
-    public function setState($state)
-    {
+    public function setState($state) {
         $this->state = $state;
     }
 
-    public function getRemoteState()
-    {
+    public function getRemoteState() {
         $state = explode(':', $this->state);
         if (is_array($state) && array_key_exists(1, $state)) {
             return $state[1];
@@ -771,8 +723,7 @@ 
     /**
      * @return string
      */
-    public function getRemoteLastModDate()
-    {
+    public function getRemoteLastModDate() {
         return $this->remoteLastModDate;
     }
 
@@ -780,16 +731,14 @@ 
      * @param string $remoteLastModDate
      * @return void
      */
-    public function setRemoteLastModDate($remoteLastModDate)
-    {
+    public function setRemoteLastModDate($remoteLastModDate) {
         $this->remoteLastModDate = $remoteLastModDate;
     }
 
     /**
      * @return integer
      */
-    public function getTstamp()
-    {
+    public function getTstamp() {
         return $this->tstamp;
     }
 
@@ -804,8 +753,7 @@ 
     /**
      * @param bool $suggestion
      */
-    public function setSuggestion(bool $suggestion)
-    {
+    public function setSuggestion(bool $suggestion) {
         $this->suggestion = $suggestion;
     }
 
@@ -820,8 +768,7 @@ 
     /**
      * @param string $linkedUid
      */
-    public function setLinkedUid(string $linkedUid)
-    {
+    public function setLinkedUid(string $linkedUid) {
         $this->linkedUid = $linkedUid;
     }
 
@@ -836,8 +783,7 @@ 
     /**
      * @param string $comment
      */
-    public function setComment(string $comment)
-    {
+    public function setComment(string $comment) {
         $this->comment = $comment;
     }
 
@@ -874,8 +820,7 @@ 
      *
      * @return string|int
      */
-    public function getDocumentIdentifier()
-    {
+    public function getDocumentIdentifier() {
         return $this->getObjectIdentifier()? $this->getObjectIdentifier() : $this->getUid();
     }
 
@@ -884,8 +829,7 @@ 
      *
      * @return bool
      */
-    public function isWorkingCopy()
-    {
+    public function isWorkingCopy() {
         return $this->getObjectIdentifier() && !$this->isTemporary() && !$this->isSuggestion();
     }
 
@@ -895,8 +839,7 @@ 
      *
      * @return bool
      */
-    public function isTemporaryCopy()
-    {
+    public function isTemporaryCopy() {
         return $this->getObjectIdentifier() && $this->isTemporary() && !$this->isSuggestion();
     }
 
@@ -906,8 +849,7 @@ 
      *
      * @return string|null
      */
-    public function getPublicationYear()
-    {
+    public function getPublicationYear() {
         $mods = new Mods($this->getXmlData());
         $year =  $mods->getPublishingYear();
         return $year? $year : "";
@@ -918,8 +860,7 @@ 
      *
      * @return string|null
      */
-    public function getMainTitle()
-    {
+    public function getMainTitle() {
         $mods = new Mods($this->getXmlData());
         $title = $mods->getTitle();
         return $title? $title : "";
@@ -931,8 +872,7 @@ 
      *
      * @return NULL|string
      */
-    public function getStateName_()
-    {
+    public function getStateName_() {
         if (array_key_exists($this->getState(), DocumentWorkflow::STATE_TO_SIMPLESTATE_MAPPING)) {
             return \TYPO3\CMS\Extbase\Utility\LocalizationUtility::translate(
                 "manager.documentList.state.".DocumentWorkflow::STATE_TO_SIMPLESTATE_MAPPING[$this->getState()],

Upper-Lower-Casing +10 added lines, -10 removed lines

@@ -55,14 +55,14 @@ 
      *
      * @var \EWW\Dpf\Domain\Model\DocumentType
      */
-    protected $documentType = null;
+    protected $documentType = NULL;
 
     /**
      * objectIdentifier
      *
      * @var string
      */
-    protected $objectIdentifier = null;
+    protected $objectIdentifier = NULL;
 
     /**
      * reservedObjectIdentifier
@@ -90,14 +90,14 @@ 
      *
      * @var boolean
      */
-    protected $changed = false;
+    protected $changed = FALSE;
 
     /**
      * valid
      *
      * @var boolean
      */
-    protected $valid = false;
+    protected $valid = FALSE;
 
     /**
      *
@@ -114,7 +114,7 @@ 
     /**
      * @var bool $suggestion
      */
-    protected $suggestion = false;
+    protected $suggestion = FALSE;
 
     /**
      * creator
@@ -167,7 +167,7 @@ 
      * @var \TYPO3\CMS\Extbase\Persistence\ObjectStorage<\EWW\Dpf\Domain\Model\File>
      * @cascade remove
      */
-    protected $file = null;
+    protected $file = NULL;
 
     const TRANSFER_ERROR = "ERROR";
     const TRANSFER_QUEUED = "QUEUED";
@@ -317,7 +317,7 @@ 
     public function setObjectIdentifier($objectIdentifier)
     {
         // Due to uniqe key uc_object_identifier, which should ignore empty object identifiers.
-        $this->objectIdentifier = empty($objectIdentifier)? null : $objectIdentifier;
+        $this->objectIdentifier = empty($objectIdentifier)? NULL : $objectIdentifier;
     }
 
     /**
@@ -513,7 +513,7 @@ 
                         'download' => $file->getDownload(),
                         'archive' => $file->getArchive(),
                         'use' => '',
-                        'id' => null,
+                        'id' => NULL,
                         'hasFLocat' => ($file->getStatus() == \EWW\Dpf\Domain\Model\File::STATUS_ADDED ||
                             $file->getStatus() == \EWW\Dpf\Domain\Model\File::STATUS_CHANGED),
                     );
@@ -562,7 +562,7 @@ 
                     'download' => $file->getDownload(),
                     'archive' => $file->getArchive(),
                     'use' => '',
-                    'id' => null,
+                    'id' => NULL,
                     'hasFLocat' => ($file->getStatus() == \EWW\Dpf\Domain\Model\File::STATUS_ADDED ||
                         $file->getStatus() == \EWW\Dpf\Domain\Model\File::STATUS_CHANGED),
                 );
@@ -937,7 +937,7 @@ 
             return \TYPO3\CMS\Extbase\Utility\LocalizationUtility::translate(
                 "manager.documentList.state.".DocumentWorkflow::STATE_TO_SIMPLESTATE_MAPPING[$this->getState()],
                 'dpf',
-                $arguments = null
+                $arguments = NULL
             );
         }
     }

Classes/Domain/Workflow/DocumentWorkflow.php

Spacing +12 added lines, -12 removed lines

@@ -34,30 +34,30 @@
     const REMOTE_STATE_INACTIVE     = "INACTIVE";
     const REMOTE_STATE_DELETED      = "DELETED";
 
-    const STATE_NONE_NONE            = self::LOCAL_STATE_NONE.':'.self::REMOTE_STATE_NONE;
+    const STATE_NONE_NONE            = self::LOCAL_STATE_NONE . ':' . self::REMOTE_STATE_NONE;
 
     // New
-    const STATE_NEW_NONE             = self::LOCAL_STATE_NEW.':'.self::REMOTE_STATE_NONE;
+    const STATE_NEW_NONE             = self::LOCAL_STATE_NEW . ':' . self::REMOTE_STATE_NONE;
 
     // Registered
-    const STATE_REGISTERED_NONE      = self::LOCAL_STATE_REGISTERED.':'.self::REMOTE_STATE_NONE;
+    const STATE_REGISTERED_NONE      = self::LOCAL_STATE_REGISTERED . ':' . self::REMOTE_STATE_NONE;
 
     // In progress
-    const STATE_IN_PROGRESS_NONE     = self::LOCAL_STATE_IN_PROGRESS.':'.self::REMOTE_STATE_NONE;
-    const STATE_IN_PROGRESS_ACTIVE   = self::LOCAL_STATE_IN_PROGRESS.":".self::REMOTE_STATE_ACTIVE;
-    const STATE_IN_PROGRESS_INACTIVE = self::LOCAL_STATE_IN_PROGRESS.":".self::REMOTE_STATE_INACTIVE;
-    const STATE_IN_PROGRESS_DELETED  = self::LOCAL_STATE_IN_PROGRESS.":".self::REMOTE_STATE_DELETED;
+    const STATE_IN_PROGRESS_NONE     = self::LOCAL_STATE_IN_PROGRESS . ':' . self::REMOTE_STATE_NONE;
+    const STATE_IN_PROGRESS_ACTIVE   = self::LOCAL_STATE_IN_PROGRESS . ":" . self::REMOTE_STATE_ACTIVE;
+    const STATE_IN_PROGRESS_INACTIVE = self::LOCAL_STATE_IN_PROGRESS . ":" . self::REMOTE_STATE_INACTIVE;
+    const STATE_IN_PROGRESS_DELETED  = self::LOCAL_STATE_IN_PROGRESS . ":" . self::REMOTE_STATE_DELETED;
 
     // Active
-    const STATE_NONE_ACTIVE          = self::LOCAL_STATE_NONE.':'.self::REMOTE_STATE_ACTIVE;
+    const STATE_NONE_ACTIVE          = self::LOCAL_STATE_NONE . ':' . self::REMOTE_STATE_ACTIVE;
 
     // Postponed
-    const STATE_POSTPONED_NONE       = self::LOCAL_STATE_POSTPONED.':'.self::REMOTE_STATE_NONE;
-    const STATE_NONE_INACTIVE        = self::LOCAL_STATE_NONE.':'.self::REMOTE_STATE_INACTIVE;
+    const STATE_POSTPONED_NONE       = self::LOCAL_STATE_POSTPONED . ':' . self::REMOTE_STATE_NONE;
+    const STATE_NONE_INACTIVE        = self::LOCAL_STATE_NONE . ':' . self::REMOTE_STATE_INACTIVE;
 
     // Discarded
-    const STATE_DISCARDED_NONE       = self::LOCAL_STATE_DISCARDED.':'.self::REMOTE_STATE_NONE;
-    const STATE_NONE_DELETED         = self::LOCAL_STATE_NONE.':'.self::REMOTE_STATE_DELETED;
+    const STATE_DISCARDED_NONE       = self::LOCAL_STATE_DISCARDED . ':' . self::REMOTE_STATE_NONE;
+    const STATE_NONE_DELETED         = self::LOCAL_STATE_NONE . ':' . self::REMOTE_STATE_DELETED;
 
     const TRANSITION_CREATE              = "CREATE_TRANSITION";
     const TRANSITION_CREATE_REGISTER     = "CREATE_REGISTER_TRANSITION";

Braces +2 added lines, -4 removed lines

@@ -20,8 +20,7 @@ 
 use Symfony\Component\Workflow\Workflow;
 use Symfony\Component\Workflow\Registry;
 
-class DocumentWorkflow
-{
+class DocumentWorkflow {
     const LOCAL_STATE_NONE          = 'NONE';
     const LOCAL_STATE_NEW           = 'NEW';
     const LOCAL_STATE_REGISTERED    = 'REGISTERED';
@@ -264,8 +263,7 @@ 
         ]
     ];
     
-    public static function getWorkflow()
-    {
+    public static function getWorkflow() {
         $definitionBuilder = new DefinitionBuilder();
 
         $definitionBuilder->addPlaces(self::PLACES);

Classes/Services/Document/DocumentCleaner.php

Braces +4 added lines, -8 removed lines

@@ -14,8 +14,7 @@ 
  * The TYPO3 project - inspiring people to share!
  */
 
-class DocumentCleaner
-{
+class DocumentCleaner {
 
     /**
      * clientRepository
@@ -55,8 +54,7 @@ 
      * @param \EWW\Dpf\Domain\Model\Document $openedDocument
      * @throws \TYPO3\CMS\Extbase\Persistence\Exception\IllegalObjectTypeException
      */
-    public function cleanUpDocuments($actionMethodName, $controllerClass)
-    {
+    public function cleanUpDocuments($actionMethodName, $controllerClass) {
         $excludeActions = [
             \EWW\Dpf\Controller\DocumentController::class => [
                 'showDetailsAction',
@@ -103,8 +101,7 @@ 
      * @throws \TYPO3\CMS\Extbase\Persistence\Exception\IllegalObjectTypeException
      * @throws \TYPO3\CMS\Extbase\Persistence\Exception\UnknownObjectException
      */
-    protected function cleanUpOutdatedTemporaryDocuments()
-    {
+    protected function cleanUpOutdatedTemporaryDocuments() {
         // Remove outdated temporary documents from the document table.
         $outdatedTemporaryDocuments = $this->documentRepository->findOutdatedTemporaryDocuments(3600);
         foreach ($outdatedTemporaryDocuments as $outdatedTemporaryDocument) {
@@ -117,8 +114,7 @@ 
     /**
      * Unlocks all editing locks of the current user.
      */
-    protected function cleanUpEditingLocks($controllerClass, $actionMethodName)
-    {
+    protected function cleanUpEditingLocks($controllerClass, $actionMethodName) {
         $excludeActions = [
             \EWW\Dpf\Controller\DocumentController::class => [
             ],

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -23,7 +23,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\DocumentRepository
      * @inject
      */
-    protected $documentRepository = null;
+    protected $documentRepository = NULL;
 
     /**
      * editingLockService
@@ -31,7 +31,7 @@ 
      * @var \EWW\Dpf\Services\Document\EditingLockService
      * @inject
      */
-    protected $editingLockService = null;
+    protected $editingLockService = NULL;
 
     /**
      * persistence manager
@@ -47,7 +47,7 @@ 
      * @var \EWW\Dpf\Security\Security
      * @inject
      */
-    protected $security = null;
+    protected $security = NULL;
 
     /**
      * @param string $actionMethodName

Classes/Services/Document/EditingLockService.php

Spacing +1 added lines, -1 removed lines

@@ -123,7 +123,7 @@
 
     public function getLockedDocumentIdentifiersByUserUid($userUid)
     {
-        $identifiers = array();
+        $identifiers = array ();
 
         $locks = $this->editingLockRepository->findByEditorUid($userUid);
         /** @var  \EWW\Dpf\Domain\Model\EditingLock $lock */

Braces +7 added lines, -14 removed lines

@@ -16,8 +16,7 @@ 
 
 use EWW\Dpf\Domain\Model\EditingLock;
 
-class EditingLockService
-{
+class EditingLockService {
     /**
      * editingLockRepository
      *
@@ -41,8 +40,7 @@ 
      * @param int $userUid
      * @return bool
      */
-    public function lock($documentIdentifier, $userUid)
-    {
+    public function lock($documentIdentifier, $userUid) {
         if ($this->editingLockRepository->findOneByDocumentIdentifier($documentIdentifier)) {
             return FALSE;
         }
@@ -63,8 +61,7 @@ 
      * @param string $documentIdentifier
      * @throws \TYPO3\CMS\Extbase\Persistence\Exception\IllegalObjectTypeException
      */
-    public function unlock($documentIdentifier)
-    {
+    public function unlock($documentIdentifier) {
         /** @var \EWW\Dpf\Domain\Model\EditingLock $editingLock */
         $editingLock = $this->editingLockRepository->findOneByDocumentIdentifyer($documentIdentifier);
         $this->editingLockRepository->remove($editingLock);
@@ -78,8 +75,7 @@ 
      * @param int $userUid
      * @return bool
      */
-    public function isLocked($documentIdentifier, $userUid)
-    {
+    public function isLocked($documentIdentifier, $userUid) {
         $locks = $this->editingLockRepository->findByDocumentIdentifier($documentIdentifier);
 
         /** @var  \EWW\Dpf\Domain\Model\EditingLock $lock */
@@ -96,8 +92,7 @@ 
      *
      * @param int $timeout : Time interval (in seconds) in which locks are not outdated, default is 1 hour.
      */
-    public function unlockOutdatedLocks($timeout = 3600)
-    {
+    public function unlockOutdatedLocks($timeout = 3600) {
         // Unlock outdated editing locks.
         $outdatedLocks = $this->editingLockRepository->findOutdatedLocks($timeout);
         foreach ($outdatedLocks as $outdatedLock) {
@@ -111,8 +106,7 @@ 
      *
      * @param int $editorUid
      */
-    public function unlockAllByEditor($editorUid)
-    {
+    public function unlockAllByEditor($editorUid) {
         $locks = $this->editingLockRepository->findByEditorUid($editorUid);
         foreach ($locks as $lock) {
             $this->editingLockRepository->remove($lock);
@@ -121,8 +115,7 @@ 
         $this->persistenceManager->persistAll();
     }
 
-    public function getLockedDocumentIdentifiersByUserUid($userUid)
-    {
+    public function getLockedDocumentIdentifiersByUserUid($userUid) {
         $identifiers = array();
 
         $locks = $this->editingLockRepository->findByEditorUid($userUid);

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
      * @var \EWW\Dpf\Domain\Repository\EditingLockRepository
      * @inject
      */
-    protected $editingLockRepository = null;
+    protected $editingLockRepository = NULL;
 
     /**
      * persistence manager