BibTexFileImporter::loadFile() - Code Metrics - Inspection of "Ap5 ap6 ap1 internal format" - kitodo/kitodo-publication - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#195)

unknown

created 2021-02-08 16:49 UTC

BibTexFileImporter::loadFile() C

↳ Parent: BibTexFileImporter

Complexity

Conditions	12
Paths	184

Size

Total Lines	80
Code Lines	45

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	12
eloc	45
nc	184
nop	3
dl	0
loc	80
rs	6.2666
c	1
b	0
f	0

How to fix Long Method Complexity

<?php

namespace EWW\Dpf\Services\ImportExternalMetadata;

use Symfony\Component\Serializer\Encoder\XmlEncoder;
use EWW\Dpf\Domain\Model\BibTexMetadata;
use EWW\Dpf\Domain\Model\ExternalMetadata;

use RenanBr\BibTexParser\Listener;
use RenanBr\BibTexParser\Parser;
use RenanBr\BibTexParser\Processor;

class BibTexFileImporter extends AbstractImporter implements FileImporter
{

    /**
     * @var array
     */
    protected $mandatoryErrors = [];

    /**
     * Returns the list of all publication types
     *
     * @return array
     */
    public static function types()
    {
        return [
            'article',
            'book',
            'booklet',
            'inbook',
            'incollection',
            'inproceedings',
            'manual',
            'mastersthesis',
            'misc',
            'phdthesis',
            'proceedings',
            'techreport',
            'unpublished'
        ];
    }

    /**
     * @param string $file Can be a path to a file or a string with the file content
     * @param bool $contentOnly Determines if $file is a path or content as a string
     * @return array
     * @throws \ErrorException
     * @throws \RenanBr\BibTexParser\Exception\ParserException
     */
    protected function parseFile($file, $contentOnly = false)
    {
        //$data = json_decode($response->__toString(),true);
        //$encoder = new XmlEncoder();
        $listener = new Listener();
        $listener->addProcessor(new Processor\TagNameCaseProcessor(CASE_LOWER));
        $parser = new Parser();
        $parser->addListener($listener);

        if ($contentOnly) {
            $parser->parseString($file);
        } else {
            $parser->parseFile($file);
        }

        $entries = $listener->export();

        foreach ($entries as $index => $fields) {
            foreach ($fields as $key => $field) {
                $field = str_replace("{\\\"o}", "ö", $field);
                $field = str_replace("{\\\"O}", "Ö", $field);
                $field = str_replace("{\\\"a}", "ä", $field);
                $field = str_replace("{\\\"A}", "Ä", $field);
                $field = str_replace("{\\\"u}", "ü", $field);
                $field = str_replace("{\\\"U}", "Ü", $field);
                $field = str_replace("\\textendash", "-", $field);
                $field = str_replace("\\textemdash", "—", $field);
                $field = str_replace("\\textquoteright", "'", $field);
                $field = str_replace("\\textquoteleft", "'", $field);
                $field = str_replace("{\\ss}", "ß", $field);
                $field = preg_replace("/{\s*[\\\]textunderscore\s*}/", '_', $field);
                $field = preg_replace("/{\s*[\\\]textquotedbl\s*}/", '"', $field);
                $entries[$index][$key] = preg_replace("/{\s*[\\\]&\s*}/", '&', $field);
            }
        }

        return $entries;
    }

    /**
     * @param string $filePath
     * @param string $mandatoryFieldSettings
     * @param bool $contentOnly Determines if $file is a path or content as a string
     * @return array
     */
    public function loadFile($filePath, $mandatoryFieldSettings, $contentOnly = false)
    {
        $results = [];
        $mandatoryErrors = [];
        $mandatoryFieldErrors = [];


        $mandatoryFields = array_map(
            'trim',
            explode(',', $mandatoryFieldSettings)
        );

        foreach ($mandatoryFields as $key => $value) {
            $orFields = array_map(
                'trim',
                explode('|', $value)
            );
            $mandatoryFields[$key] = $orFields;
        }

        if ($contentOnly) {
            $bibTexEntries = $this->parseFile($filePath, $contentOnly);
        } else {
            $bibTexEntries = $this->parseFile($filePath);
        }

        $encoder = new XmlEncoder();

        foreach ($bibTexEntries as $index => $bibTexItem) {

            $mandatoryFieldErrors = [];
            foreach ($mandatoryFields as $combinedMandatoryField) {

                $mandatoryOk = false;
                foreach ($combinedMandatoryField as $key => $value) {
                    $mandatoryOk = $mandatoryOk || (
                            array_key_exists($value, $bibTexItem)
                            && $bibTexItem[$value]
                        );
                }

                if (!$mandatoryOk) {
                    $mandatoryFieldErrors[implode('|', $combinedMandatoryField)] = implode(
                        '|',
                        $combinedMandatoryField
                    );
                    $mandatoryErrors[$index] = [
                        'index' => $index + 1,
                        'title' => $bibTexItem['title'],
                        'fields' => $mandatoryFieldErrors
                    ];
                }
            }

            if (!$mandatoryErrors[$index]) {

                $bibTexData = $bibTexItem;

                if (array_key_exists('author', $bibTexItem)) {
                    $bibTexData['author'] = $this->splitPersons($bibTexItem['author']);
                }

                if (array_key_exists('editor', $bibTexItem)) {
                    $bibTexData['editor'] = $this->splitPersons($bibTexItem['editor']);
                }

                /** @var BibTexMetadata $bibTexMetadata */
                $bibTexMetadata = $this->objectManager->get(BibTexMetadata::class);

                $bibTexMetadata->setSource(get_class($this));
                $bibTexMetadata->setFeUser($this->security->getUser()->getUid());
                $bibTexMetadata->setData($encoder->encode($bibTexData, 'xml'));

                $results[] = $bibTexMetadata;
            }

        }

        $this->mandatoryErrors = $mandatoryErrors;

        return $results;
    }

    /**
     * @return array
     */
    public function getMandatoryErrors()
    {
        return $this->mandatoryErrors;
    }

    /**
     * @return bool
     */
    public function hasMandatoryErrors()
    {
        return !empty($this->mandatoryErrors);
    }

    /**
     * @return \EWW\Dpf\Domain\Model\TransformationFile|void
     */
    protected function getDefaultXsltTransformation()
    {
        /** @var \EWW\Dpf\Domain\Model\Client $client */
        $client = $this->clientRepository->findAll()->current();

        /** @var \EWW\Dpf\Domain\Model\TransformationFile $xsltTransformationFile */
        return $client->getBibTexTransformation()->current();
    }

    /**
     * @return string|void
     */
    protected function getDefaultXsltFilePath()
    {
        return \TYPO3\CMS\Core\Utility\GeneralUtility::getFileAbsFileName(
            'EXT:dpf/Resources/Private/Xslt/bibtex-default.xsl'
        );
    }

    /**
     * @return string|void
     */
    protected function getImporterName()
    {
        return 'bibtex';
    }

    /**
     * @param string $persons
     */
    protected function splitPersons($persons)
    {
        $results = [];

        $persons = array_map('trim', explode(' and ', $persons));

        foreach ($persons as $person) {
            list($family, $given) = array_map('trim', explode(',', $person));
            $results[] = [
                'family' => $family,
                'given' => $given
            ];
        }

        return $results;
    }

}

1			<?php
2
3			namespace EWW\Dpf\Services\ImportExternalMetadata;
4
5			use Symfony\Component\Serializer\Encoder\XmlEncoder;
6			use EWW\Dpf\Domain\Model\BibTexMetadata;
7			use EWW\Dpf\Domain\Model\ExternalMetadata;
8
9			use RenanBr\BibTexParser\Listener;
10			use RenanBr\BibTexParser\Parser;
11			use RenanBr\BibTexParser\Processor;
12
13			class BibTexFileImporter extends AbstractImporter implements FileImporter
14			{
15
16			/**
17			* @var array
18			*/
19			protected $mandatoryErrors = [];
20
21			/**
22			* Returns the list of all publication types
23			*
24			* @return array
25			*/
26			public static function types()
27			{
28			return [
29			'article',
30			'book',
31			'booklet',
32			'inbook',
33			'incollection',
34			'inproceedings',
35			'manual',
36			'mastersthesis',
37			'misc',
38			'phdthesis',
39			'proceedings',
40			'techreport',
41			'unpublished'
42			];
43			}
44
45			/**
46			* @param string $file Can be a path to a file or a string with the file content
47			* @param bool $contentOnly Determines if $file is a path or content as a string
48			* @return array
49			* @throws \ErrorException
50			* @throws \RenanBr\BibTexParser\Exception\ParserException
51			*/
52			protected function parseFile($file, $contentOnly = false)
53			{
54			//$data = json_decode($response->__toString(),true);
55			//$encoder = new XmlEncoder();
56			$listener = new Listener();
57			$listener->addProcessor(new Processor\TagNameCaseProcessor(CASE_LOWER));
58			$parser = new Parser();
59			$parser->addListener($listener);
60
61			if ($contentOnly) {
62			$parser->parseString($file);
63			} else {
64			$parser->parseFile($file);
65			}
66
67			$entries = $listener->export();
68
69			foreach ($entries as $index => $fields) {
70			foreach ($fields as $key => $field) {
71			$field = str_replace("{\\\"o}", "ö", $field);
72			$field = str_replace("{\\\"O}", "Ö", $field);
73			$field = str_replace("{\\\"a}", "ä", $field);
74			$field = str_replace("{\\\"A}", "Ä", $field);
75			$field = str_replace("{\\\"u}", "ü", $field);
76			$field = str_replace("{\\\"U}", "Ü", $field);
77			$field = str_replace("\\textendash", "-", $field);
78			$field = str_replace("\\textemdash", "—", $field);
79			$field = str_replace("\\textquoteright", "'", $field);
80			$field = str_replace("\\textquoteleft", "'", $field);
81			$field = str_replace("{\\ss}", "ß", $field);
82			$field = preg_replace("/{\s[\\\]textunderscore\s}/", '_', $field);
83			$field = preg_replace("/{\s[\\\]textquotedbl\s}/", '"', $field);
84			$entries[$index][$key] = preg_replace("/{\s[\\\]&\s}/", '&', $field);
85			}
86			}
87
88			return $entries;
89			}
90
91			/**
92			* @param string $filePath
93			* @param string $mandatoryFieldSettings
94			* @param bool $contentOnly Determines if $file is a path or content as a string
95			* @return array
96			*/
97			public function loadFile($filePath, $mandatoryFieldSettings, $contentOnly = false)
98			{
99			$results = [];
100			$mandatoryErrors = [];
101			$mandatoryFieldErrors = [];
			0 ignored issues – show Unused Code introduced 2021-02-08 09:32 UTC by Report Bug Copy Issue Report The assignment to `$mandatoryFieldErrors` is dead and can be removed. Loading history...
102
103			$mandatoryFields = array_map(
104			'trim',
105			explode(',', $mandatoryFieldSettings)
106			);
107
108			foreach ($mandatoryFields as $key => $value) {
109			$orFields = array_map(
110			'trim',
111			explode('\|', $value)
112			);
113			$mandatoryFields[$key] = $orFields;
114			}
115
116			if ($contentOnly) {
117			$bibTexEntries = $this->parseFile($filePath, $contentOnly);
118			} else {
119			$bibTexEntries = $this->parseFile($filePath);
120			}
121
122			$encoder = new XmlEncoder();
123
124			foreach ($bibTexEntries as $index => $bibTexItem) {
125
126			$mandatoryFieldErrors = [];
127			foreach ($mandatoryFields as $combinedMandatoryField) {
128
129			$mandatoryOk = false;
130			foreach ($combinedMandatoryField as $key => $value) {
131			$mandatoryOk = $mandatoryOk \|\| (
132			array_key_exists($value, $bibTexItem)
133			&& $bibTexItem[$value]
134			);
135			}
136
137			if (!$mandatoryOk) {
138			$mandatoryFieldErrors[implode('\|', $combinedMandatoryField)] = implode(
139			'\|',
140			$combinedMandatoryField
141			);
142			$mandatoryErrors[$index] = [
143			'index' => $index + 1,
144			'title' => $bibTexItem['title'],
145			'fields' => $mandatoryFieldErrors
146			];
147			}
148			}
149
150			if (!$mandatoryErrors[$index]) {
151
152			$bibTexData = $bibTexItem;
153
154			if (array_key_exists('author', $bibTexItem)) {
155			$bibTexData['author'] = $this->splitPersons($bibTexItem['author']);
156			}
157
158			if (array_key_exists('editor', $bibTexItem)) {
159			$bibTexData['editor'] = $this->splitPersons($bibTexItem['editor']);
160			}
161
162			/** @var BibTexMetadata $bibTexMetadata */
163			$bibTexMetadata = $this->objectManager->get(BibTexMetadata::class);
164
165			$bibTexMetadata->setSource(get_class($this));
166			$bibTexMetadata->setFeUser($this->security->getUser()->getUid());
167			$bibTexMetadata->setData($encoder->encode($bibTexData, 'xml'));
168
169			$results[] = $bibTexMetadata;
170			}
171
172			}
173
174			$this->mandatoryErrors = $mandatoryErrors;
175
176			return $results;
177			}
178
179			/**
180			* @return array
181			*/
182			public function getMandatoryErrors()
183			{
184			return $this->mandatoryErrors;
185			}
186
187			/**
188			* @return bool
189			*/
190			public function hasMandatoryErrors()
191			{
192			return !empty($this->mandatoryErrors);
193			}
194
195			/**
196			* @return \EWW\Dpf\Domain\Model\TransformationFile\|void
197			*/
198			protected function getDefaultXsltTransformation()
199			{
200			/** @var \EWW\Dpf\Domain\Model\Client $client */
201			$client = $this->clientRepository->findAll()->current();
202
203			/** @var \EWW\Dpf\Domain\Model\TransformationFile $xsltTransformationFile */
204			return $client->getBibTexTransformation()->current();
205			}
206
207			/**
208			* @return string\|void
209			*/
210			protected function getDefaultXsltFilePath()
211			{
212			return \TYPO3\CMS\Core\Utility\GeneralUtility::getFileAbsFileName(
213			'EXT:dpf/Resources/Private/Xslt/bibtex-default.xsl'
214			);
215			}
216
217			/**
218			* @return string\|void
219			*/
220			protected function getImporterName()
221			{
222			return 'bibtex';
223			}
224
225			/**
226			* @param string $persons
227			*/
228			protected function splitPersons($persons)
229			{
230			$results = [];
231
232			$persons = array_map('trim', explode(' and ', $persons));
233
234			foreach ($persons as $person) {
235			list($family, $given) = array_map('trim', explode(',', $person));
236			$results[] = [
237			'family' => $family,
238			'given' => $given
239			];
240			}
241
242			return $results;
243			}
244
245			}

kitodo / kitodo-publication

Pull Request — master (#195)

BibTexFileImporter::loadFile() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like