IsFisIdMissingViewHelper::render() - Code Metrics - Inspection of "Ap5 ap6 ap1 internal format" - kitodo/kitodo-publication - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#195)

unknown

created 2021-02-08 17:01 UTC

IsFisIdMissingViewHelper::render() A

↳ Parent: IsFisIdMissingViewHelper

Complexity

Conditions	2
Paths	2

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	3
c	1
b	0
f	0
nc	2
nop	0
dl	0
loc	5
rs	10

<?php
namespace EWW\Dpf\ViewHelpers;

/*
 * This file is part of the TYPO3 CMS project.
 *
 * It is free software; you can redistribute it and/or modify it under
 * the terms of the GNU General Public License, either version 2
 * of the License, or any later version.
 *
 * For the full copyright and license information, please read the
 * LICENSE.txt file that was distributed with this source code.
 *
 * The TYPO3 project - inspiring people to share!
 */

use \EWW\Dpf\Security\Security;

class IsFisIdMissingViewHelper extends \TYPO3\CMS\Fluid\Core\ViewHelper\AbstractViewHelper
{
    /**
     * security
     *
     * @var \EWW\Dpf\Security\Security
     * @inject
     */
    protected $security = null;

    /**
     *
     * @param  $condition
     * @return string
     */
    public function render()
    {
        return  !(

            $this->security->getUser()->getFisPersId() ||
            $this->security->getUser()->getUserRole() != Security::ROLE_RESEARCHER
        );
    }

}


1			<?php
2			namespace EWW\Dpf\ViewHelpers;
3
4			/*
5			* This file is part of the TYPO3 CMS project.
6			*
7			* It is free software; you can redistribute it and/or modify it under
8			* the terms of the GNU General Public License, either version 2
9			* of the License, or any later version.
10			*
11			* For the full copyright and license information, please read the
12			* LICENSE.txt file that was distributed with this source code.
13			*
14			* The TYPO3 project - inspiring people to share!
15			*/
16
17			use \EWW\Dpf\Security\Security;
18
19			class IsFisIdMissingViewHelper extends \TYPO3\CMS\Fluid\Core\ViewHelper\AbstractViewHelper
20			{
21			/**
22			* security
23			*
24			* @var \EWW\Dpf\Security\Security
25			* @inject
26			*/
27			protected $security = null;
28
29			/**
30			*
31			* @param $condition
32			* @return string
33			*/
34			public function render()
35			{
36			return !(
			0 ignored issues – show Bug Best Practice introduced 2020-12-15 14:55 UTC by Report Bug Copy Issue Report The expression `return ! $this->security...curity::ROLE_RESEARCHER` returns the type `boolean` which is incompatible with the documented return type `string`. Loading history...
37			$this->security->getUser()->getFisPersId() \|\|
38			$this->security->getUser()->getUserRole() != Security::ROLE_RESEARCHER
39			);
40			}
41
42			}
43

kitodo / kitodo-publication

Pull Request — master (#195)

IsFisIdMissingViewHelper::render() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like