kitodo / kitodo-publication

Classes/Services/Identifier/UrnBuilder.php

Spacing +2 added lines, -2 removed lines

@@ -150,13 +150,13 @@
         $nbn = strtolower($urn);
 
         // array of characters to match
-        $search_pattern = array('/9/', '/8/', '/7/', '/6/', '/5/', '/4/', '/3/', '/2/', '/1/', '/0/', '/a/', '/b/', '/c/',
+        $search_pattern = array ('/9/', '/8/', '/7/', '/6/', '/5/', '/4/', '/3/', '/2/', '/1/', '/0/', '/a/', '/b/', '/c/',
             '/d/', '/e/', '/f/', '/g/', '/h/', '/i/', '/j/', '/k/', '/l/', '/m/', '/n/', '/o/', '/p/', '/q/', '/r/', '/s/',
             '/t/', '/u/', '/v/', '/w/', '/x/', '/y/', '/z/', '/-/', '/:/');
 
         // array of corresponding replacements, '9' will be temporarily replaced with placeholder '_' to prevent
         // replacement of '41' with '52'
-        $replacements = array('_', 9, 8, 7, 6, 5, 4, 3, 2, 1, 18, 14, 19, 15, 16, 21, 22, 23, 24, 25, 42, 26, 27, 13, 28, 29,
+        $replacements = array ('_', 9, 8, 7, 6, 5, 4, 3, 2, 1, 18, 14, 19, 15, 16, 21, 22, 23, 24, 25, 42, 26, 27, 13, 28, 29,
             31, 12, 32, 33, 11, 34, 35, 36, 37, 38, 39, 17);
 
         // replace matching pattern in given nbn with corresponding replacement

Braces +5 added lines, -10 removed lines

@@ -14,8 +14,7 @@ 
  * The TYPO3 project - inspiring people to share!
  */
 
-class UrnBuilder
-{
+class UrnBuilder {
 
     /**
      * Standard prefix of the URN for DNB (Deutsche Nationalbibliothek).
@@ -46,8 +45,7 @@ 
      * @throws InvalidArgumentException Thrown if at least one of the subnamespace parts contain other
      *                                  characters than characters.
      */
-    public function __construct($snid1, $snid2)
-    {
+    public function __construct($snid1, $snid2) {
 
         if (0 === preg_match('/^[a-zA-Z]+$/', $snid1)) {
             throw new \InvalidArgumentException('Used invalid first subnamespace identifier.');
@@ -67,8 +65,7 @@ 
      * @throws InvalidArgumentException Thrown if the niss contains invalid characters.
      * @return string The URN.
      */
-    public function getUrn($niss)
-    {
+    public function getUrn($niss) {
 
         // regexp pattern for valid niss
         if (0 === preg_match('/^[a-zA-Z0-9\-]+$/', $niss)) {
@@ -89,8 +86,7 @@ 
      * @throws InvalidArgumentException Thrown if the niss contains invalid characters.
      * @return integer Check digit.
      */
-    public function getCheckDigit($niss)
-    {
+    public function getCheckDigit($niss) {
 
         // regexp pattern for valid niss
         if (0 === preg_match('/^[a-zA-Z0-9\-]+$/', $niss)) {
@@ -140,8 +136,7 @@ 
      * @param string $urn A partial URN with the checkdigit missing.
      * @return string The given URN with all characters replaced by numbers.
      */
-    private function replaceUrnChars($urn)
-    {
+    private function replaceUrnChars($urn) {
         // However, the preg_replace function calls itself on the result of a previos run. In order to get
         // the replacement right, characters and numbers in the arrays below have got a specific order to make
         // it work. Be careful when changing those numbers! Tests may help ;)

Classes/ViewHelpers/Widget/Controller/PaginateController.php

Spacing +6 added lines, -6 removed lines

@@ -34,7 +34,7 @@ 
     /**
      * @var array
      */
-    protected $configuration = array(
+    protected $configuration = array (
         'itemsPerPage'         => 10,
         'insertAbove'          => false,
         'insertBelow'          => true,
@@ -92,7 +92,7 @@ 
     public function indexAction($currentPage = 1)
     {
         // set current page
-        if(!empty($this->widgetConfiguration['currentPage'])) {
+        if (!empty($this->widgetConfiguration['currentPage'])) {
             $currentPage = $this->widgetConfiguration['currentPage'];
         };
         $this->currentPage = (int) $currentPage;
@@ -110,7 +110,7 @@ 
                 $offset = ((int) ($itemsPerPage * ($this->currentPage - 1)));
             }
         }
-        $this->view->assign('contentArguments', array(
+        $this->view->assign('contentArguments', array (
             $this->widgetConfiguration['as'] => $this->objects,
         ));
         $this->view->assign('configuration', $this->configuration);
@@ -151,11 +151,11 @@ 
     protected function buildPagination()
     {
         $this->calculateDisplayRange();
-        $pages = array();
+        $pages = array ();
         for ($i = $this->displayRangeStart; $i <= $this->displayRangeEnd; $i++) {
-            $pages[] = array('number' => $i, 'isCurrent' => $i === $this->currentPage);
+            $pages[] = array ('number' => $i, 'isCurrent' => $i === $this->currentPage);
         }
-        $pagination = array(
+        $pagination = array (
             'pages'             => $pages,
             'current'           => $this->currentPage,
             'numberOfPages'     => $this->numberOfPages,

Braces +5 added lines, -10 removed lines

@@ -29,8 +29,7 @@ 
 /*
  * Class PaginateController
  */
-class PaginateController extends AbstractWidgetController
-{
+class PaginateController extends AbstractWidgetController {
     /**
      * @var array
      */
@@ -76,8 +75,7 @@ 
     /**
      * @return void
      */
-    public function initializeAction()
-    {
+    public function initializeAction() {
         $this->objects = $this->widgetConfiguration['objects'];
         ArrayUtility::mergeRecursiveWithOverrule($this->configuration, $this->widgetConfiguration['configuration'], false);
         $itemsPerPage               = (int) $this->configuration['itemsPerPage'];
@@ -89,8 +87,7 @@ 
      * @param int $currentPage
      * @return void
      */
-    public function indexAction($currentPage = 1)
-    {
+    public function indexAction($currentPage = 1) {
         // set current page
         if(!empty($this->widgetConfiguration['currentPage'])) {
             $currentPage = $this->widgetConfiguration['currentPage'];
@@ -123,8 +120,7 @@ 
      *
      * @return void
      */
-    protected function calculateDisplayRange()
-    {
+    protected function calculateDisplayRange() {
         $maximumNumberOfLinks = $this->maximumNumberOfLinks;
         if ($maximumNumberOfLinks > $this->numberOfPages) {
             $maximumNumberOfLinks = $this->numberOfPages;
@@ -148,8 +144,7 @@ 
      *
      * @return array
      */
-    protected function buildPagination()
-    {
+    protected function buildPagination() {
         $this->calculateDisplayRange();
         $pages = array();
         for ($i = $this->displayRangeStart; $i <= $this->displayRangeEnd; $i++) {

Upper-Lower-Casing +6 added lines, -6 removed lines

@@ -36,8 +36,8 @@ 
      */
     protected $configuration = array(
         'itemsPerPage'         => 10,
-        'insertAbove'          => false,
-        'insertBelow'          => true,
+        'insertAbove'          => FALSE,
+        'insertBelow'          => TRUE,
         'maximumNumberOfLinks' => 99,
         'addQueryStringMethod' => '',
         'section'              => '',
@@ -66,12 +66,12 @@ 
     /**
      * @var int
      */
-    protected $displayRangeStart = null;
+    protected $displayRangeStart = NULL;
 
     /**
      * @var int
      */
-    protected $displayRangeEnd = null;
+    protected $displayRangeEnd = NULL;
 
     /**
      * @return void
@@ -79,7 +79,7 @@ 
     public function initializeAction()
     {
         $this->objects = $this->widgetConfiguration['objects'];
-        ArrayUtility::mergeRecursiveWithOverrule($this->configuration, $this->widgetConfiguration['configuration'], false);
+        ArrayUtility::mergeRecursiveWithOverrule($this->configuration, $this->widgetConfiguration['configuration'], FALSE);
         $itemsPerPage               = (int) $this->configuration['itemsPerPage'];
         $this->numberOfPages        = $itemsPerPage > 0 ? ceil($this->widgetConfiguration['total'] / $itemsPerPage) : 0;
         $this->maximumNumberOfLinks = (int) $this->configuration['maximumNumberOfLinks'];
@@ -101,7 +101,7 @@ 
         }
         if ($this->currentPage > $this->numberOfPages) {
             // set $modifiedObjects to NULL if the page does not exist
-            $modifiedObjects = null;
+            $modifiedObjects = NULL;
         } else {
             // modify query
             $itemsPerPage = (int) $this->configuration['itemsPerPage'];

Classes/Domain/Repository/DocumentTransferLogRepository.php

Braces +1 added lines, -2 removed lines

@@ -17,7 +17,6 @@
 /**
  * The repository for DocumentTransferLogs
  */
-class DocumentTransferLogRepository extends \TYPO3\CMS\Extbase\Persistence\Repository
-{
+class DocumentTransferLogRepository extends \TYPO3\CMS\Extbase\Persistence\Repository {
 
 }

Classes/Domain/Repository/InputOptionListRepository.php

Braces +1 added lines, -2 removed lines

@@ -17,7 +17,6 @@
 /**
  * The repository for InputOptionLists
  */
-class InputOptionListRepository extends \TYPO3\CMS\Extbase\Persistence\Repository
-{
+class InputOptionListRepository extends \TYPO3\CMS\Extbase\Persistence\Repository {
 
 }

Classes/Domain/Repository/ClientRepository.php

Braces +2 added lines, -4 removed lines

@@ -17,16 +17,14 @@
 /**
  * The repository for Clients
  */
-class ClientRepository extends \TYPO3\CMS\Extbase\Persistence\Repository
-{
+class ClientRepository extends \TYPO3\CMS\Extbase\Persistence\Repository {
 
     /**
      * findAllByPid
      *
      * @return
      */
-    public function findAllByPid($pid)
-    {
+    public function findAllByPid($pid) {
         $query = $this->createQuery();
         $query->getQuerySettings()->setRespectStoragePage(false);
         $query->matching($query->equals('pid', $pid));

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
     public function findAllByPid($pid)
     {
         $query = $this->createQuery();
-        $query->getQuerySettings()->setRespectStoragePage(false);
+        $query->getQuerySettings()->setRespectStoragePage(FALSE);
         $query->matching($query->equals('pid', $pid));
         return $query->execute();
     }

Classes/Domain/Repository/FileRepository.php

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -28,7 +28,7 @@ 
             $query->logicalAnd(
                 $query->equals("document", $document),
                 $query->logicalNot($query->equals("status", \EWW\Dpf\Domain\Model\File::STATUS_DELETED)),
-                $query->logicalNot($query->equals("primary_file", true))
+                $query->logicalNot($query->equals("primary_file", TRUE))
             ));
 
         return $query->execute();
@@ -41,7 +41,7 @@ 
         $query->matching(
             $query->logicalAnd(
                 $query->equals("document", $document),
-                $query->equals("primary_file", true),
+                $query->equals("primary_file", TRUE),
                 $query->logicalNot($query->equals("status", \EWW\Dpf\Domain\Model\File::STATUS_DELETED))
             ));
 
@@ -51,7 +51,7 @@ 
             return $file->current();
         }
 
-        return null;
+        return NULL;
 
     }
 

Braces +3 added lines, -6 removed lines

@@ -17,11 +17,9 @@ 
 /**
  * The repository for Files
  */
-class FileRepository extends \TYPO3\CMS\Extbase\Persistence\Repository
-{
+class FileRepository extends \TYPO3\CMS\Extbase\Persistence\Repository {
 
-    public function getSecondaryFilesByDocument(\EWW\Dpf\Domain\Model\Document $document)
-    {
+    public function getSecondaryFilesByDocument(\EWW\Dpf\Domain\Model\Document $document) {
 
         $query = $this->createQuery();
         $query->matching(
@@ -34,8 +32,7 @@ 
         return $query->execute();
     }
 
-    public function getPrimaryFileByDocument(\EWW\Dpf\Domain\Model\Document $document)
-    {
+    public function getPrimaryFileByDocument(\EWW\Dpf\Domain\Model\Document $document) {
 
         $query = $this->createQuery();
         $query->matching(

Classes/Domain/Repository/ProcessNumberRepository.php

Spacing +3 added lines, -3 removed lines

@@ -33,12 +33,12 @@ 
      * @var string ownerId
      * @return array The found ProcessNumber Object
      */
-    public function getHighestProcessNumberByOwnerIdAndYear($ownerId,$year)
+    public function getHighestProcessNumberByOwnerIdAndYear($ownerId, $year)
     {
 
         $query = $this->createQuery();
 
-        $constraints = array();
+        $constraints = array ();
         $constraints[] = $query->equals('owner_id', $ownerId, false);
 
         $constraints[] = $query->equals('year', $year);
@@ -47,7 +47,7 @@ 
             $query->matching($query->logicalAnd($constraints));
         }
 
-        $query->setOrderings(array("counter" => \TYPO3\CMS\Extbase\Persistence\QueryInterface::ORDER_DESCENDING));
+        $query->setOrderings(array ("counter" => \TYPO3\CMS\Extbase\Persistence\QueryInterface::ORDER_DESCENDING));
 
         $result = $query->execute();
 

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -39,7 +39,7 @@
         $query = $this->createQuery();
 
         $constraints = array();
-        $constraints[] = $query->equals('owner_id', $ownerId, false);
+        $constraints[] = $query->equals('owner_id', $ownerId, FALSE);
 
         $constraints[] = $query->equals('year', $year);
 

Braces +3 added lines, -6 removed lines

@@ -22,8 +22,7 @@ 
 /**
  * The repository for ProcessNumbers
  */
-class ProcessNumberRepository extends \TYPO3\CMS\Extbase\Persistence\Repository
-{
+class ProcessNumberRepository extends \TYPO3\CMS\Extbase\Persistence\Repository {
 
     public function initializeObject() {
         $querySettings = $this->objectManager->get(Typo3QuerySettings::class);
@@ -38,8 +37,7 @@ 
      * @var string ownerId
      * @return array The found ProcessNumber Object
      */
-    public function getHighestProcessNumberByOwnerIdAndYear($ownerId,$year)
-    {
+    public function getHighestProcessNumberByOwnerIdAndYear($ownerId,$year) {
 
         $query = $this->createQuery();
 
@@ -68,8 +66,7 @@ 
      *
      * @return Connection
      */
-    protected function getConnection()
-    {
+    protected function getConnection() {
         return GeneralUtility::makeInstance(ConnectionPool::class)->getConnectionForTable(
             "tx_dpf_domain_model_processnumber"
         );

Classes/Domain/Model/DocumentForm.php

Spacing +1 added lines, -1 removed lines

@@ -247,7 +247,7 @@
 
     public function getNewFileNames()
     {
-        $fileNames = array();
+        $fileNames = array ();
         foreach ($this->getNewFiles() as $file) {
             $fileNames[] = $file->getTitle();
         }

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -87,7 +87,7 @@
      *
      * @var boolean
      */
-    protected $valid = false;
+    protected $valid = FALSE;
 
     /**
      *

Braces +29 added lines, -58 removed lines

@@ -20,8 +20,7 @@ 
  * The TYPO3 project - inspiring people to share!
  */
 
-class DocumentForm extends AbstractFormElement
-{
+class DocumentForm extends AbstractFormElement {
 
     /**
      * @var string CSRF token for this form
@@ -103,8 +102,7 @@ 
      *
      * @param string $csrfToken
      */
-    public function generateCsrfToken()
-    {
+    public function generateCsrfToken() {
         $formProtection = FormProtectionFactory::get();
         $this->csrfToken = $formProtection->generateToken('DocumentForm', 'construct', 'DocumentForm');
         $formProtection->persistSessionToken();
@@ -119,10 +117,8 @@ 
      * @throws Exception if the given string is empty.
      * @throws TypeError if the given string is null
      */
-    public function setCsrfToken(string $csrfToken)
-    {
-        if ($csrfToken === "")
-        {
+    public function setCsrfToken(string $csrfToken) {
+        if ($csrfToken === "") {
             throw new Exception("A forms CSRF token cannot be empty");
         }
         $this->csrfToken = $csrfToken;
@@ -134,8 +130,7 @@ 
      *
      * @return string CSRF token for this form
      */
-    public function getCsrfToken()
-    {
+    public function getCsrfToken() {
         return $this->csrfToken;
     }
 
@@ -145,8 +140,7 @@ 
      *
      * @return bool True, is CSRF token is considered valid. False if the token is invalid or missing.
      */
-    public function hasValidCsrfToken()
-    {
+    public function hasValidCsrfToken() {
         $formProtection = FormProtectionFactory::get();
         return $formProtection->validateToken($this->csrfToken, 'DocumentForm', 'construct', 'DocumentForm');
     }
@@ -155,8 +149,7 @@ 
      *
      * @return integer
      */
-    public function getDocumentUid()
-    {
+    public function getDocumentUid() {
         return $this->documentUid;
     }
 
@@ -164,8 +157,7 @@ 
      *
      * @param integer $documentUid
      */
-    public function setDocumentUid($documentUid)
-    {
+    public function setDocumentUid($documentUid) {
         $this->documentUid = $documentUid;
     }
 
@@ -173,8 +165,7 @@ 
      *
      * @return boolean
      */
-    public function getPrimaryFileMandatory()
-    {
+    public function getPrimaryFileMandatory() {
         return $this->primaryFileMandatory;
     }
 
@@ -182,8 +173,7 @@ 
      *
      * @param boolean $primaryFileMandatory
      */
-    public function setPrimaryFileMandatory($primaryFileMandatory)
-    {
+    public function setPrimaryFileMandatory($primaryFileMandatory) {
         $this->primaryFileMandatory = boolval($primaryFileMandatory);
     }
 
@@ -191,8 +181,7 @@ 
      *
      * @return string
      */
-    public function getFedoraPid()
-    {
+    public function getFedoraPid() {
         return $this->fedoraPid;
     }
 
@@ -200,8 +189,7 @@ 
      *
      * @param string $fedoraPid
      */
-    public function setFedoraPid($fedoraPid)
-    {
+    public function setFedoraPid($fedoraPid) {
         $this->fedoraPid = $fedoraPid;
     }
 
@@ -209,8 +197,7 @@ 
      *
      * @param type \EWW\Dpf\Domain\Model\File $primaryFile
      */
-    public function setPrimaryFile($primaryFile)
-    {
+    public function setPrimaryFile($primaryFile) {
         $this->primaryFile = $primaryFile;
     }
 
@@ -218,59 +205,49 @@ 
      *
      * @return \EWW\Dpf\Domain\Model\File
      */
-    public function getPrimaryFile()
-    {
+    public function getPrimaryFile() {
         return $this->primaryFile;
     }
 
-    public function setSecondaryFiles($secondaryFiles)
-    {
+    public function setSecondaryFiles($secondaryFiles) {
         $this->secondaryFiles = $secondaryFiles;
     }
 
-    public function getSecondaryFiles()
-    {
+    public function getSecondaryFiles() {
         return $this->secondaryFiles;
     }
 
-    public function getDeletedFiles()
-    {
+    public function getDeletedFiles() {
         return $this->deletedFiles;
     }
 
-    public function setDeletedFiles($deletedFiles)
-    {
+    public function setDeletedFiles($deletedFiles) {
         $this->deletedFiles = $deletedFiles;
     }
 
-    public function getNewFiles()
-    {
+    public function getNewFiles() {
         return $this->newFiles;
     }
 
-    public function setNewFiles($newFiles)
-    {
+    public function setNewFiles($newFiles) {
         $this->newFiles = $newFiles;
     }
 
     /**
      * @return bool
      */
-    public function getValid()
-    {
+    public function getValid() {
         return $this->valid;
     }
 
     /**
      * @param bool $valid
      */
-    public function setValid($valid)
-    {
+    public function setValid($valid) {
         $this->valid = boolval($valid);
     }
 
-    public function getNewFileNames()
-    {
+    public function getNewFileNames() {
         $fileNames = array();
         foreach ($this->getNewFiles() as $file) {
             $fileNames[] = $file->getTitle();
@@ -283,8 +260,7 @@ 
      *
      * @return string
      */
-    public function getProcessNumber()
-    {
+    public function getProcessNumber() {
         return $this->processNumber;
     }
 
@@ -293,8 +269,7 @@ 
      *
      * @param string $processNumber
      */
-    public function setProcessNumber($processNumber)
-    {
+    public function setProcessNumber($processNumber) {
         $this->processNumber = $processNumber;
     }
 
@@ -303,8 +278,7 @@ 
      *
      * @return bool
      */
-    public function isTemporary()
-    {
+    public function isTemporary() {
         return $this->temporary;
     }
 
@@ -312,24 +286,21 @@ 
      * Sets if a document is a temporary document or not.
      * @param bool $temporary
      */
-    public function setTemporary($temporary)
-    {
+    public function setTemporary($temporary) {
         $this->temporary = boolval($temporary);
     }
 
     /**
      * @return string
      */
-    public function getComment()
-    {
+    public function getComment() {
         return $this->comment;
     }
 
     /**
      * @param string $comment
      */
-    public function setComment($comment)
-    {
+    public function setComment($comment) {
         $this->comment = $comment;
     }
 }

Classes/Domain/Model/DocumentFormPage.php

Braces +1 added lines, -2 removed lines

@@ -14,7 +14,6 @@
  * The TYPO3 project - inspiring people to share!
  */
 
-class DocumentFormPage extends AbstractFormElement
-{
+class DocumentFormPage extends AbstractFormElement {
 
 }