kitodo / kitodo-publication

Classes/Domain/Model/Document.php

Upper-Lower-Casing +12 added lines, -12 removed lines

@@ -60,7 +60,7 @@ 
      *
      * @var \EWW\Dpf\Domain\Model\DocumentType
      */
-    protected $documentType = null;
+    protected $documentType = NULL;
 
     /**
      * objectIdentifier
@@ -95,14 +95,14 @@ 
      *
      * @var boolean
      */
-    protected $changed = false;
+    protected $changed = FALSE;
 
     /**
      * valid
      *
      * @var boolean
      */
-    protected $valid = false;
+    protected $valid = FALSE;
 
     /**
      *
@@ -119,7 +119,7 @@ 
     /**
      * @var bool $suggestion
      */
-    protected $suggestion = false;
+    protected $suggestion = FALSE;
 
     /**
      * creator
@@ -185,7 +185,7 @@ 
      *
      * @var \DateTime
      */
-    protected $embargoDate = null;
+    protected $embargoDate = NULL;
 
     /**
      * newlyAssignedFobIdentifiers
@@ -197,7 +197,7 @@ 
     /**
      * @var bool
      */
-    protected $stateChange = false;
+    protected $stateChange = FALSE;
 
     /**
      * file
@@ -205,7 +205,7 @@ 
      * @var \TYPO3\CMS\Extbase\Persistence\ObjectStorage<\EWW\Dpf\Domain\Model\File>
      * @TYPO3\CMS\Extbase\Annotation\ORM\Cascade("remove")
      */
-    protected $file = null;
+    protected $file = NULL;
 
     const TRANSFER_ERROR = "ERROR";
     const TRANSFER_QUEUED = "QUEUED";
@@ -378,7 +378,7 @@ 
     public function setObjectIdentifier($objectIdentifier)
     {
         // Due to uniqe key uc_object_identifier, which should ignore empty object identifiers.
-        $this->objectIdentifier = empty($objectIdentifier)? null : $objectIdentifier;
+        $this->objectIdentifier = empty($objectIdentifier)? NULL : $objectIdentifier;
     }
 
     /**
@@ -561,7 +561,7 @@ 
                 return $file;
             }
         }
-        return null;
+        return NULL;
     }
 
     /**
@@ -575,7 +575,7 @@ 
                 return $file;
             }
         }
-        return null;
+        return NULL;
     }
 
     /**
@@ -587,12 +587,12 @@ 
             foreach ($this->getFile() as $file) {
                 /** @var File $file */
                 if (!$file->isFileGroupDeleted()) {
-                    return true;
+                    return TRUE;
                 }
             }
         }
 
-        return false;
+        return FALSE;
     }
 
     /**

Classes/Controller/DocumentFormBackofficeController.php

Upper-Lower-Casing +32 added lines, -32 removed lines

@@ -52,7 +52,7 @@ 
      * @var \EWW\Dpf\Services\Document\EditingLockService
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $editingLockService = null;
+    protected $editingLockService = NULL;
 
     /**
      * documentManager
@@ -60,7 +60,7 @@ 
      * @var \EWW\Dpf\Services\Document\DocumentManager
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $documentManager = null;
+    protected $documentManager = NULL;
 
     /**
      * bookmarkRepository
@@ -68,7 +68,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\BookmarkRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $bookmarkRepository = null;
+    protected $bookmarkRepository = NULL;
 
     /**
      * clientConfigurationManager
@@ -125,10 +125,10 @@ 
      */
     public function editAction(
         \EWW\Dpf\Domain\Model\DocumentForm $documentForm,
-        bool $suggestMod = false,
+        bool $suggestMod = FALSE,
         $activeGroup = '',
         $activeGroupIndex = 0,
-        $addCurrentFeUser = true
+        $addCurrentFeUser = TRUE
     )
     {
         /** @var \EWW\Dpf\Domain\Model\Document $document */
@@ -157,7 +157,7 @@ 
             }
 
             $this->addFlashMessage($message, '', AbstractMessage::ERROR);
-            $this->redirect('showDetails', 'Document', null, ['document' => $document]);
+            $this->redirect('showDetails', 'Document', NULL, ['document' => $document]);
             return FALSE;
         }
 
@@ -186,7 +186,7 @@ 
         $workingCopy = $this->documentRepository->findByUid($documentForm->getDocumentUid());
 
         if ($workingCopy->isTemporary()) {
-            $workingCopy->setTemporary(false);
+            $workingCopy->setTemporary(FALSE);
         }
 
         $newDocument = $this->objectManager->get(Document::class);
@@ -206,7 +206,7 @@ 
             $newDocument->setLinkedUid($document->getUid());
         }
 
-        $newDocument->setSuggestion(true);
+        $newDocument->setSuggestion(TRUE);
         $newDocument->setComment($document->getComment());
 
         if ($restore) {
@@ -245,7 +245,7 @@ 
                     ''
                 );
             }
-            $this->addFlashMessage($flashMessage, '', AbstractMessage::OK, true);
+            $this->addFlashMessage($flashMessage, '', AbstractMessage::OK, TRUE);
 
             $notifier = $this->objectManager->get(Notifier::class);
             $notifier->sendAdminNewSuggestionNotification($newDocument);
@@ -281,7 +281,7 @@ 
 
         } catch (\Throwable $t) {
             $severity = \TYPO3\CMS\Core\Messaging\AbstractMessage::ERROR;
-            $this->addFlashMessage("Failed", '', $severity,false);
+            $this->addFlashMessage("Failed", '', $severity,FALSE);
         }
 
         $this->redirectToDocumentList();
@@ -292,7 +292,7 @@ 
     {
         if ($this->request->getArgument('documentData')['suggestMod']) {
             $restore = $this->request->getArgument('documentData')['suggestRestore'];
-            $this->forward('createSuggestionDocument', null, null, ['documentForm' => $documentForm, 'restore' => $restore]);
+            $this->forward('createSuggestionDocument', NULL, NULL, ['documentForm' => $documentForm, 'restore' => $restore]);
         }
 
         $backToList = $this->request->getArgument('documentData')['backToList'];
@@ -302,7 +302,7 @@ 
         } elseif ($this->request->hasArgument('saveWorkingCopy')) {
             $saveMode = 'saveWorkingCopy';
         } else {
-            $saveMode = null;
+            $saveMode = NULL;
         }
 
         $this->forward(
@@ -326,7 +326,7 @@ 
      * @throws \TYPO3\CMS\Extbase\Mvc\Exception\StopActionException
      * @throws \TYPO3\CMS\Extbase\Mvc\Exception\UnsupportedRequestTypeException
      */
-    public function updateDocumentAction(\EWW\Dpf\Domain\Model\DocumentForm $documentForm, $saveMode = null, $backToList = false)
+    public function updateDocumentAction(\EWW\Dpf\Domain\Model\DocumentForm $documentForm, $saveMode = NULL, $backToList = FALSE)
     {
         try {
             /** @var \EWW\Dpf\Domain\Model\Document $document */
@@ -348,8 +348,8 @@ 
                 $this->addFlashMessage($message, '', AbstractMessage::ERROR);
 
                 $this->redirect('cancelEdit',
-                    null,
-                    null,
+                    NULL,
+                    NULL,
                     ['documentUid' => $document->getUid(), 'backToList' => $backToList]
                 );
                 /*
@@ -367,13 +367,13 @@ 
             /** @var \EWW\Dpf\Domain\Model\Document $updateDocument */
             $updateDocument = $documentMapper->getDocument($documentForm);
 
-            $saveWorkingCopy = false;
-            $workflowTransition = null;
+            $saveWorkingCopy = FALSE;
+            $workflowTransition = NULL;
 
             // Convert the temporary copy into a local working copy if needed.
             if ( $updateDocument->isTemporaryCopy() && $saveMode == 'saveWorkingCopy') {
-                $saveWorkingCopy = true;
-                $updateDocument->setTemporary(false);
+                $saveWorkingCopy = TRUE;
+                $updateDocument->setTemporary(FALSE);
                 $workflowTransition = DocumentWorkflow::TRANSITION_IN_PROGRESS;
             } elseif ($updateDocument->isTemporaryCopy() && $saveMode == 'saveAndUpdate') {
                 $workflowTransition = DocumentWorkflow::TRANSITION_REMOTE_UPDATE;
@@ -481,8 +481,8 @@ 
                 $this->redirectToDocumentList();
             } else {
                 $this->redirect('cancelEdit',
-                    null,
-                    null,
+                    NULL,
+                    NULL,
                     ['documentUid' => $updateDocument->getUid(), 'backToList' => $backToList]
                 );
                 // $this->redirect('showDetails', 'Document', null, ['document' => $updateDocument]);
@@ -507,13 +507,13 @@ 
 
             $exceptionMsg[] = LocalizationUtility::translate($key, 'dpf');
 
-            $this->addFlashMessage(implode(" ", $exceptionMsg), '', $severity, true);
+            $this->addFlashMessage(implode(" ", $exceptionMsg), '', $severity, TRUE);
             $this->redirect('cancelEdit',
-                null,
-                null,
+                NULL,
+                NULL,
                 ['documentUid' => $updateDocument->getUid(), 'backToList' => $backToList]
             );
-            $this->redirect('showDetails', 'Document', null, ['document' => $updateDocument]);
+            $this->redirect('showDetails', 'Document', NULL, ['document' => $updateDocument]);
         }
     }
 
@@ -530,7 +530,7 @@ 
             $args[] = $document->getTitle();
             $message = LocalizationUtility::translate($key, 'dpf', $args);
             $this->addFlashMessage($message, '', AbstractMessage::ERROR);
-            $this->redirect('showDetails', 'Document', null, ['document' => $document]);
+            $this->redirect('showDetails', 'Document', NULL, ['document' => $document]);
             return FALSE;
         }
 
@@ -544,7 +544,7 @@ 
                 $message,
                 '',
                 $severity,
-                true
+                TRUE
             );
 
         } catch (\TYPO3\CMS\Extbase\Mvc\Exception\StopActionException $e) {
@@ -566,7 +566,7 @@ 
                 implode(" ", $message),
                 '',
                 $severity,
-                true
+                TRUE
             );
         }
 
@@ -584,7 +584,7 @@ 
      *
      * @return void
      */
-    public function cancelEditAction($documentUid = 0, $backToList = false)
+    public function cancelEditAction($documentUid = 0, $backToList = FALSE)
     {
         if (empty($documentUid) || $backToList) {
             $this->redirectToDocumentList();
@@ -592,7 +592,7 @@ 
 
         /** @var $document \EWW\Dpf\Domain\Model\Document */
         $document = $this->documentRepository->findByUid($documentUid);
-        $this->redirect('showDetails', 'Document', null, ['document' => $document]);
+        $this->redirect('showDetails', 'Document', NULL, ['document' => $document]);
     }
 
     /**
@@ -624,14 +624,14 @@ 
      * @throws \TYPO3\CMS\Extbase\Mvc\Exception\StopActionException
      * @throws \TYPO3\CMS\Extbase\Mvc\Exception\UnsupportedRequestTypeException
      */
-    protected function redirectToDocumentList($message = null)
+    protected function redirectToDocumentList($message = NULL)
     {
         list($action, $controller, $redirectUri) = $this->session->getStoredAction();
 
         if ($redirectUri) {
             $this->redirectToUri($redirectUri);
         } else {
-            $this->redirect($action, $controller, null, array('message' => $message));
+            $this->redirect($action, $controller, NULL, array('message' => $message));
         }
     }
 }

Classes/Controller/GetFileController.php

Upper-Lower-Casing +14 added lines, -14 removed lines

@@ -199,22 +199,22 @@ 
         // allow dissemination if a request parameter 'deliverInactive' has the secret
         // TYPOScript configuration value 'deliverInactiveSecretKey'
 
-        $restrictToActiveDocuments = true;
+        $restrictToActiveDocuments = TRUE;
         $deliverInactiveSecretKey = $this->settings['deliverInactiveSecretKey'];
 
         if ($deliverInactiveSecretKey == $piVars['deliverInactive']) {
-            $restrictToActiveDocuments = false;
+            $restrictToActiveDocuments = FALSE;
         }
 
-        if (true === $isRepositoryObject) {
-            if (true === $restrictToActiveDocuments) {
+        if (TRUE === $isRepositoryObject) {
+            if (TRUE === $restrictToActiveDocuments) {
                 // if restriction applies, check object state before dissemination
                 $objectProfileURI = rtrim('http://' . $fedoraHost,
                         "/") . '/fedora/objects/' . $piVars['qid'] . '?format=XML';
                 $objectProfileXML = file_get_contents($objectProfileURI);
-                if (false !== $objectProfileXML) {
+                if (FALSE !== $objectProfileXML) {
                     $objectProfileDOM = new \DOMDocument('1.0', 'UTF-8');
-                    if (true === $objectProfileDOM->loadXML($objectProfileXML)) {
+                    if (TRUE === $objectProfileDOM->loadXML($objectProfileXML)) {
                         $objectState = $objectProfileDOM->getElementsByTagName('objState')[0];
                         if ('I' === $objectState->nodeValue) {
                             $this->response->setStatus(403);
@@ -235,29 +235,29 @@ 
         // get remote header and set it before passtrough
         $headers = get_headers($path);
 
-        if (false === $headers) {
+        if (FALSE === $headers) {
             $this->response->setStatus(500);
             return 'Error while fetching headers';
         }
 
-        $contentDispFlag = false;
-        $contentTypeFlag = false;
+        $contentDispFlag = FALSE;
+        $contentTypeFlag = FALSE;
 
         foreach ($headers as $value) {
 
-            if (false !== stripos($value, 'Content-Disposition')) {
+            if (FALSE !== stripos($value, 'Content-Disposition')) {
                 header($value);
-                $contentDispFlag = true;
+                $contentDispFlag = TRUE;
                 continue;
             }
 
-            if (false !== stripos($value, 'Content-Type')) {
+            if (FALSE !== stripos($value, 'Content-Type')) {
                 header($value);
-                $contentTypeFlag = true;
+                $contentTypeFlag = TRUE;
                 continue;
             }
 
-            if (false !== stripos($value, 'Content-Length')) {
+            if (FALSE !== stripos($value, 'Content-Length')) {
                 header($value);
                 continue;
             }

Classes/Controller/AjaxDocumentFormController.php

Upper-Lower-Casing +8 added lines, -8 removed lines

@@ -31,7 +31,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\MetadataGroupRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $metadataGroupRepository = null;
+    protected $metadataGroupRepository = NULL;
 
     /**
      * metadataObjectRepository
@@ -39,7 +39,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\MetadataObjectRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $metadataObjectRepository = null;
+    protected $metadataObjectRepository = NULL;
 
     /**
      * fisDataService
@@ -47,7 +47,7 @@ 
      * @var \EWW\Dpf\Services\FeUser\FisDataService
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $fisDataService = null;
+    protected $fisDataService = NULL;
 
     /**
      *
@@ -90,7 +90,7 @@ 
         $groupItem->setGroupType($group->getGroupType());
         $groupItem->setMandatory($group->getMandatory());
         $groupItem->setMaxIteration($group->getMaxIteration());
-        $groupItem->setEmptyGroup(true);
+        $groupItem->setEmptyGroup(TRUE);
 
         if ($this->security->getFisPersId()) {
             $this->view->assign('fisPersId', $this->security->getFisPersId());
@@ -232,7 +232,7 @@ 
 
             return json_encode(
                 array(
-                    'error' => false,
+                    'error' => FALSE,
                     'fedoraPid' => $fedoraPid,
                     'value'    => $urn,
                 )
@@ -241,9 +241,9 @@ 
         } catch (\Exception $exception) {
             return json_encode(
                 array(
-                    'error' =>  true,
-                    'fedoraPid' => null,
-                    'value'    => null,
+                    'error' =>  TRUE,
+                    'fedoraPid' => NULL,
+                    'value'    => NULL,
                 )
             );
         }

Classes/Controller/ApiController.php

Upper-Lower-Casing +19 added lines, -19 removed lines

@@ -51,7 +51,7 @@ 
      * @var \EWW\Dpf\Security\Security
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $security = null;
+    protected $security = NULL;
 
     /**
      * documentRepository
@@ -59,7 +59,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\DocumentRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $documentRepository = null;
+    protected $documentRepository = NULL;
 
     /**
      * frontendUserRepository
@@ -67,7 +67,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\FrontendUserRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $frontendUserRepository = null;
+    protected $frontendUserRepository = NULL;
 
     /**
      * documentManager
@@ -75,7 +75,7 @@ 
      * @var \EWW\Dpf\Services\Document\DocumentManager
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $documentManager = null;
+    protected $documentManager = NULL;
 
     /**
      * clientRepository
@@ -99,16 +99,16 @@ 
      * @var \TYPO3\CMS\Extbase\SignalSlot\Dispatcher
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $signalSlotDispatcher = null;
+    protected $signalSlotDispatcher = NULL;
 
     /**
      * logger
      *
      * @var \TYPO3\CMS\Core\Log\Logger
      */
-    protected $logger = null;
+    protected $logger = NULL;
 
-    protected $frontendUser = null;
+    protected $frontendUser = NULL;
 
     protected $validActions = [
         'show', 'create', 'suggestion', 'importDoiWithoutSaving',
@@ -129,9 +129,9 @@ 
 
         if ($frontendUser) {
             $this->frontendUser = $frontendUser;
-            return true;
+            return TRUE;
         } else {
-            return false;
+            return FALSE;
         }
     }
 
@@ -258,7 +258,7 @@ 
                 $doc->setProcessNumber($processNumber);
             }
 
-            if ($this->documentManager->update($doc, null,true)) {
+            if ($this->documentManager->update($doc, NULL,TRUE)) {
                 return '{"success": "Document '.$document.' added '.$id.'"}';
             } else {
                 return '{"failed": Could not update the Document"}';
@@ -289,7 +289,7 @@ 
      * @param bool $restore
      * @return string
      */
-    public function suggestionAction($document, $json, $comment, $token, $restore = false) {
+    public function suggestionAction($document, $json, $comment, $token, $restore = FALSE) {
 
         if ($this->checkToken($token)) {
 
@@ -298,7 +298,7 @@ 
                     return '{"error": "Invalid data in parameter json."}';
                 }
             } else {
-                if (empty($json) || json_decode($json,true) === []) {
+                if (empty($json) || json_decode($json,TRUE) === []) {
                     return '{"error": "Parameter json can not be empty."}';
                 }
                 if (is_null(json_decode($json))) {
@@ -525,14 +525,14 @@ 
      * @param bool $force
      * @return string
      */
-    public function importBibtexWithoutSavingAction($bibtex, $token, $force = false) {
+    public function importBibtexWithoutSavingAction($bibtex, $token, $force = FALSE) {
 
         if ($this->checkToken($token)) {
             $importer = $this->objectManager->get(BibTexFileImporter::class);
             $importer->deactivateProcessNumberGeneration();
 
             try {
-                $externalMetadata = $importer->loadFile($bibtex, $this->settings['bibTexMandatoryFields'], true);
+                $externalMetadata = $importer->loadFile($bibtex, $this->settings['bibTexMandatoryFields'], TRUE);
                 $mandatoryErrors = $importer->getMandatoryErrors();
             } catch (\Throwable $throwable) {
                 return '{"failed": "' . $throwable->getMessage() . '"}';
@@ -605,7 +605,7 @@ 
      * @param bool $force
      * @return string
      */
-    public function importRisWithoutSavingAction($ris, $token, $force = false) {
+    public function importRisWithoutSavingAction($ris, $token, $force = FALSE) {
 
         if ($this->checkToken($token)) {
             /** @var FileImporter $fileImporter */
@@ -613,7 +613,7 @@ 
             $importer->deactivateProcessNumberGeneration();
 
             try {
-                $externalMetadata = $importer->loadFile($ris, $this->settings['riswosMandatoryFields'], true);
+                $externalMetadata = $importer->loadFile($ris, $this->settings['riswosMandatoryFields'], TRUE);
                 $mandatoryErrors = $importer->getMandatoryErrors();
             } catch (\Throwable $throwable) {
                 return '{"failed": "' . $throwable->getMessage() . '"}';
@@ -688,7 +688,7 @@ 
         if ($missingArguments) {
             $this->throwStatus(
                 400,
-                null,
+                NULL,
                 '{"error": "Missing parameters: '.implode(", ", $missingArguments).'"}'
             );
         }
@@ -709,7 +709,7 @@ 
         if (empty($actionName)) {
             $this->throwStatus(
                 400,
-                null,
+                NULL,
                 '{"error": "No action has been specified"}'
             );
 
@@ -718,7 +718,7 @@ 
         if (!in_array($actionName, $this->validActions)) {
             $this->throwStatus(
                 400,
-                null,
+                NULL,
             '{"error": "An invalid action hes been called: '.$actionName.'"}'
             );
         }

Classes/Controller/DocumentFormController.php

Upper-Lower-Casing +6 added lines, -6 removed lines

@@ -21,9 +21,9 @@ 
 class DocumentFormController extends AbstractDocumentFormController
 {
 
-    protected function redirectToList($message = null)
+    protected function redirectToList($message = NULL)
     {
-        $this->redirect('list', 'DocumentForm', null, array('message' => $message));
+        $this->redirect('list', 'DocumentForm', NULL, array('message' => $message));
     }
 
     /**
@@ -34,7 +34,7 @@ 
      * @TYPO3\CMS\Extbase\Annotation\IgnoreValidation("newDocumentForm")
      * @return void
      */
-    public function newAction(\EWW\Dpf\Domain\Model\DocumentForm $newDocumentForm = null, $returnDocumentId = 0)
+    public function newAction(\EWW\Dpf\Domain\Model\DocumentForm $newDocumentForm = NULL, $returnDocumentId = 0)
     {
         $this->view->assign('documentForm', $newDocumentForm);
     }
@@ -50,7 +50,7 @@ 
         foreach ($newDocumentForm->getFiles() as $file) {
             $uid = $file->getUID();
             if (empty($uid)) {
-                $file->setDownload(true);
+                $file->setDownload(TRUE);
             }
             $files[] = $file;
         }
@@ -90,8 +90,8 @@ 
 
             $message[] = \TYPO3\CMS\Extbase\Utility\LocalizationUtility::translate($key, 'dpf');
 
-            $this->addFlashMessage(implode(" ", $message), '', $severity,true);
-            $this->forward('new', 'DocumentForm', null, array('newDocumentForm' => $newDocumentForm));
+            $this->addFlashMessage(implode(" ", $message), '', $severity,TRUE);
+            $this->forward('new', 'DocumentForm', NULL, array('newDocumentForm' => $newDocumentForm));
         }
     }
 }

Classes/Controller/AbstractDocumentFormController.php

Upper-Lower-Casing +14 added lines, -14 removed lines

@@ -36,7 +36,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\DocumentRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $documentRepository = null;
+    protected $documentRepository = NULL;
 
     /**
      * fileRepository
@@ -44,7 +44,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\FileRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $fileRepository = null;
+    protected $fileRepository = NULL;
 
     /**
      * documentTypeRepository
@@ -52,7 +52,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\DocumentTypeRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $documentTypeRepository = null;
+    protected $documentTypeRepository = NULL;
 
     /**
      * metadataGroupRepository
@@ -60,7 +60,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\MetadataGroupRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $metadataGroupRepository = null;
+    protected $metadataGroupRepository = NULL;
 
     /**
      * metadataObjectRepository
@@ -68,7 +68,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\MetadataObjectRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $metadataObjectRepository = null;
+    protected $metadataObjectRepository = NULL;
 
     /**
      * depositLicenseLogRepository
@@ -76,7 +76,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\DepositLicenseLogRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $depositLicenseLogRepository = null;
+    protected $depositLicenseLogRepository = NULL;
 
     /**
      * persistence manager
@@ -92,7 +92,7 @@ 
      * @var \EWW\Dpf\Services\FeUser\FisDataService
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $fisDataService = null;
+    protected $fisDataService = NULL;
 
     /**
      * action list
@@ -151,7 +151,7 @@ 
      * @TYPO3\CMS\Extbase\Annotation\IgnoreValidation("newDocumentForm")
      * @return void
      */
-    public function newAction(DocumentForm $newDocumentForm = null, $returnDocumentId = 0)
+    public function newAction(DocumentForm $newDocumentForm = NULL, $returnDocumentId = 0)
     {
         $this->view->assign('returnDocumentId', $returnDocumentId);
         $this->view->assign('documentForm', $newDocumentForm);
@@ -188,11 +188,11 @@ 
             $documentType = $this->documentTypeRepository->findByUid($docTypeUid);
             $virtualType = $documentType->getVirtualType();
 
-            if (!$formDataReader->uploadError() || $virtualType === true) {
+            if (!$formDataReader->uploadError() || $virtualType === TRUE) {
                 $this->request->setArguments($requestArguments);
             } else {
                 $t = $docForm->getFileNames();
-                $this->redirect('list', 'DocumentForm', null, array('message' => 'UPLOAD_MAX_FILESIZE_ERROR', 'errorFiles' => $t));
+                $this->redirect('list', 'DocumentForm', NULL, array('message' => 'UPLOAD_MAX_FILESIZE_ERROR', 'errorFiles' => $t));
             }
         } else {
             $this->redirectToList("UPLOAD_POST_SIZE_ERROR");
@@ -351,11 +351,11 @@ 
             $virtualType = $documentType->getVirtualType();
 
 
-            if (!$formDataReader->uploadError() || $virtualType === true) {
+            if (!$formDataReader->uploadError() || $virtualType === TRUE) {
                 $this->request->setArguments($requestArguments);
             } else {
                 $t = $docForm->getFileNames();
-                $this->redirect('list', 'Document', null, array('message' => 'UPLOAD_MAX_FILESIZE_ERROR', 'errorFiles' => $t));
+                $this->redirect('list', 'Document', NULL, array('message' => 'UPLOAD_MAX_FILESIZE_ERROR', 'errorFiles' => $t));
             }
         } else {
             $this->redirectToList("UPLOAD_POST_SIZE_ERROR");
@@ -388,7 +388,7 @@ 
         // send document to index
         $elasticsearchRepository->add($updateDocument, $json);
 
-        $updateDocument->setChanged(true);
+        $updateDocument->setChanged(TRUE);
         $this->documentRepository->update($updateDocument);
 
         // index the document
@@ -410,7 +410,7 @@ 
         $this->redirect('list');
     }
 
-    protected function redirectToList($message = null)
+    protected function redirectToList($message = NULL)
     {
         $this->redirect('list');
     }

Classes/Services/Document/DocumentManager.php

Upper-Lower-Casing +32 added lines, -32 removed lines

@@ -23,7 +23,7 @@ 
      * @var \TYPO3\CMS\Extbase\Object\ObjectManager
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $objectManager = null;
+    protected $objectManager = NULL;
 
     /**
      * documentRepository
@@ -31,7 +31,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\DocumentRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $documentRepository = null;
+    protected $documentRepository = NULL;
 
     /**
      * fileRepository
@@ -39,7 +39,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\FileRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $fileRepository = null;
+    protected $fileRepository = NULL;
 
     /**
      * bookmarkRepository
@@ -47,7 +47,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\BookmarkRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $bookmarkRepository = null;
+    protected $bookmarkRepository = NULL;
 
     /**
      * persistence manager
@@ -63,7 +63,7 @@ 
      * @var \TYPO3\CMS\Extbase\SignalSlot\Dispatcher
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $signalSlotDispatcher = null;
+    protected $signalSlotDispatcher = NULL;
 
     /**
      * notifier
@@ -71,7 +71,7 @@ 
      * @var \EWW\Dpf\Services\Email\Notifier
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $notifier = null;
+    protected $notifier = NULL;
 
     /**
      * security
@@ -79,7 +79,7 @@ 
      * @var \EWW\Dpf\Security\Security
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $security = null;
+    protected $security = NULL;
 
     /**
      * frontendUserRepository
@@ -87,7 +87,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\FrontendUserRepository
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $frontendUserRepository = null;
+    protected $frontendUserRepository = NULL;
 
     /**
      * elasticSearch
@@ -95,7 +95,7 @@ 
      * @var \EWW\Dpf\Services\ElasticSearch\ElasticSearch
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $elasticSearch = null;
+    protected $elasticSearch = NULL;
 
     /**
      * queryBuilder
@@ -103,7 +103,7 @@ 
      * @var \EWW\Dpf\Services\ElasticSearch\QueryBuilder
      * @TYPO3\CMS\Extbase\Annotation\Inject
      */
-    protected $queryBuilder = null;
+    protected $queryBuilder = NULL;
 
     /**
      * Returns the localized document identifiers (uid/objectIdentifier).
@@ -130,7 +130,7 @@ 
 
             $query = $this->queryBuilder->buildQuery(
                 1, [], 0,
-                [], [], [], null, null,
+                [], [], [], NULL, NULL,
                 'identifier:"'.$identifier.'"'
             );
 
@@ -158,7 +158,7 @@ 
     public function read($identifier)
     {
         if (!$identifier) {
-            return null;
+            return NULL;
         }
 
         $localizedIdentifiers = $this->resolveIdentifier($identifier);
@@ -179,11 +179,11 @@ 
 
                 return $document;
             } catch (\Exception $exception) {
-                return null;
+                return NULL;
             }
         }
 
-        return null;
+        return NULL;
     }
 
     /**
@@ -198,7 +198,7 @@ 
      * @throws \TYPO3\CMS\Extbase\Persistence\Exception\UnknownObjectException
      */
     public function update(
-        Document $document, $workflowTransition = null, $addedFisIdOnly = false
+        Document $document, $workflowTransition = NULL, $addedFisIdOnly = FALSE
     )
     {
         // xml data fields are limited to 64 KB
@@ -212,7 +212,7 @@ 
 
         if ($workflowTransition) {
             if (!$workflow->can($document, $workflowTransition)) {
-                return false;
+                return FALSE;
             }
             $workflow->apply($document, $workflowTransition);
         }
@@ -220,7 +220,7 @@ 
         if ($document->isSuggestion()) {
 
             // if local suggestion copy
-            $updateResult = false;
+            $updateResult = FALSE;
 
         } elseif ($document->isTemporaryCopy()) {
 
@@ -268,7 +268,7 @@ 
                 }
                 $updateResult = $document->getDocumentIdentifier();
             } else {
-                $updateResult = false;
+                $updateResult = FALSE;
             }
         } else {
             $this->documentRepository->update($document);
@@ -342,13 +342,13 @@ 
      * @throws \TYPO3\CMS\Extbase\Persistence\Exception\IllegalObjectTypeException
      * @throws \TYPO3\CMS\Extbase\Persistence\Exception\UnknownObjectException
      */
-    protected function updateRemotely($document, $workflowTransition = null)
+    protected function updateRemotely($document, $workflowTransition = NULL)
     {
         $lastModDate = $this->getDocumentTransferManager()->getLastModDate($document->getObjectIdentifier());
         $docLastModDate = $document->getRemoteLastModDate();
         if ($lastModDate !== $docLastModDate && !empty($docLastModDate)) {
             // There is a newer version in the fedora repository.
-            return false;
+            return FALSE;
         }
 
         $this->documentRepository->update($document);
@@ -367,13 +367,13 @@ 
                 break;
 
             default:
-                $transferState = null;
+                $transferState = NULL;
                 break;
         }
 
         if ($transferState) {
             if (!$this->getDocumentTransferManager()->delete($document, $transferState)) {
-                return false;
+                return FALSE;
             }
         }
 
@@ -387,10 +387,10 @@ 
             return $document->getDocumentIdentifier();
         }
 
-        return false;
+        return FALSE;
     }
 
-    public function addSuggestion($editDocument, $restore = false, $comment = '') {
+    public function addSuggestion($editDocument, $restore = FALSE, $comment = '') {
         // add new document
         /** @var Document $suggestionDocument */
         $suggestionDocument = $this->objectManager->get(Document::class);
@@ -402,7 +402,7 @@ 
         $suggestionDocument->setCreator($editDocument->getCreator());
 
         if ($suggestionDocument->isTemporary()) {
-            $suggestionDocument->setTemporary(false);
+            $suggestionDocument->setTemporary(FALSE);
         }
 
         if ($editDocument->getObjectIdentifier()) {
@@ -411,7 +411,7 @@ 
             $suggestionDocument->setLinkedUid($editDocument->getUid());
         }
 
-        $suggestionDocument->setSuggestion(true);
+        $suggestionDocument->setSuggestion(TRUE);
         if ($comment) {
             $suggestionDocument->setComment($comment);
         }
@@ -423,7 +423,7 @@ 
         try {
             $this->documentRepository->add($suggestionDocument);
         } catch (\Throwable $t) {
-            return null;
+            return NULL;
         }
 
         return $suggestionDocument;
@@ -440,9 +440,9 @@ 
         $currentDate = new \DateTime('now');
         if($currentDate > $document->getEmbargoDate()){
             // embargo is expired
-            return false;
+            return FALSE;
         } else {
-            return true;
+            return TRUE;
         }
 
     }
@@ -586,13 +586,13 @@ 
                             $embargoDate = $document->getEmbargoDate();
                             $currentDate = new \DateTime('now');
 
-                            $fulltextPublished = false;
+                            $fulltextPublished = FALSE;
                             foreach ($document->getFile() as $file) {
                                 if ($file->getStatus() != 'added') {
-                                    $fulltextPublished = false;
+                                    $fulltextPublished = FALSE;
                                     break;
                                 } else {
-                                    $fulltextPublished = true;
+                                    $fulltextPublished = TRUE;
                                 }
                             }
 

Classes/Helper/XSLTransformator.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -102,7 +102,7 @@
      * @param string $xmlData
      * @return string The transformed xml
      */
-    public function getTransformedOutputXML(Document $document, $xmlData = null): string
+    public function getTransformedOutputXML(Document $document, $xmlData = NULL): string
     {
         $objectManager = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(ObjectManager::class);
         $this->clientConfigurationManager = $objectManager->get(ClientConfigurationManager::class);